dzieyzone [dzieyzone]

The previous application was #604928: dzieyzone [dzieyzone].

Remember to change status, when you upload new code; other metadata are not thought to be used from the applicant.

Have you filed any issues with PNGfix or PNGbehave to include this background-fixing feature?

In Apply for contributions CVS access is clearly stated that we tend to avoid duplication of modules. If the modules have different code, but have the same purpose, it's a kind of duplication too.

Is that so? what about the pngfix and pngbehave?

The page I am referring to is for who applies for a CVS account; if you are applying for a CVS account, and you propose a module that is the duplicate of an existing module, it is probable that your account is rejected.

If you look at all the issues present in this queue, you will not find an application that attaches one of those modules; if you are suggesting that we made an exception for one of those modules, you are wrong.

1. /*
    * Version: 0.0.8a
    * Licensed under the MIT License: http://dillerdesign.com/experiment/DD_belatedPNG/#license
    *
    */
   

   In Drupal.org CVS the only accepted files are the ones licensed under GPL license v2+; compatible licenses are not accepted.
   Files available from third-party sites, then, should not be included in Drupal.org CVS.

2. The file LICENSE.txt needs to be removed; Drupal.org CVS doesn't allow to commit that file.

I still agree with Dave about the necessity of offering to integrate the proposed code with existing modules.

It is then possible to do what the module does by creating a custom block; there is no need to use a module that only fixes the transparent issue in Internet Explorer.

I have to say, I'm impressed with the belatedPNG module. I'm usually very hesitant about using non-contributed modules, and having tried pretty much every pngfix out there at one time or another and found limitations with them all, this one actually seems to work really well.

I tried the pngFix, and it didn't work on my CSS sprites (it compresses the width of the entire background image into the width of the visible portion, which defeats the purpose of the CSS sprite. I used pngbehave, but due to the number of transparent images I am using on the site I am developing, it froze up my site. Eventually it worked, but the whole site disappeared for seconds at a time after clicking on it. But this belatedPNG seems to work with my site very well, and doesn't noticably slow down anything.

I understand Drupal not wanting to allow duplicate modules, but with pngfixes, no pngfix is the same. They all have their positive points and their limitations, so I think that cutting this module off, when it seems to work really well, would be a mistake.

See my comment #9, which is still valid.
Also, files available from third-party modules should not be placed in Drupal.org CVS. The main issue here, anyway, is the license used for the code, which is not GPL License v2+, as requested for all the files committed in CVS.

Ahh, that's a fairly big thing. Too bad - this is the best pngfix I have found so far.

@dzieyzone

You need to remove the license file and the script, then provide a link to download the script and instructions for users on where to place it.

Not a bit fan of the camelCasing, and needs to run through coder and cleaned up.

Removing the license file is the first step; dzieyzone needs to understand that his module would be released under GPL License, not MIT License as he reported in LICENCE.txt.

1.   if (!empty($belatedpngapply)) {
       drupal_set_html_head('<!--[if lt IE 7]>
   <script type="text/javascript" src="'. base_path() . drupal_get_path('module', 'belatedpng') . '/belatedpng.js"></script>
   <script type="text/javascript">
   	DD_belatedPNG.fix("'.$belatedPNGapply.'");
   </script>															 
   <![endif]-->');
     }
   

   The code could use drupal_add_js().

2. The file belatedpng.admin.inc contains just a function; its content can be moved into the module file.

Thanks for this module! I tried the other two and neither worked for me. I was about ready to give up but gave this one a try and it worked. Hope it becomes an official contributed module.

Great module! PNGfix had bugs when it came to background positioning.

belatedPNG works well...could be cleaner though.

For example, this shouldn't be here:

    drupal_set_html_head('<!--[if lt IE 7]>
<script type="text/javascript" src="'. base_path() . drupal_get_path('module', 'belatedpng') . '/belatedpng.js"></script>
<script type="text/javascript">
	DD_belatedPNG.fix("'.$belatedpngapply.'");
</script>															 
<![endif]-->');
  }

...maybe you could use PHP's $_SERVER['HTTP_USER_AGENT'] to check for IE 6.....then use drupal_add_js

Also, why does the readme file talk about the FCKeditor?

...either way....really helped me out. Thanks!

maybe you could use PHP's $_SERVER['HTTP_USER_AGENT'] to check for IE 6

The user agent identifier is not reliable, as some browsers have an option that allows the user to change the user agent it uses.
The conditional HTML comments used by Internet Explorer is the only way to verify if the browser is really Internet Explorer (at least in the versions higher than 4.0).

I agree. Conditional comments are the most reliable way to target IE browsers.

I apologize for the delay in approving this CVS application.

Will it be released? Worked well for me.

This has worked well for me too (in a situation where the similar pngfix and pngbehave modules did not). Thanks dzieyzone!

I made a small change to the module, instead of a text-field (limited to 150 chars), now there's a textarea you add your selectors 1 per line without commas the script will take care of the rest.

when adding selectors to the text area try to disable the WYSIWYG editor as it adds some unwanted markup (I'm already removing it but better to be aware), if you're using the CKeditor you can go to /admin/settings/ckeditor/editg and then add admin/settings/belatedpng.edit-belatedpng-css-toapply under visibility *exclude* to avoid it to render for that field not sure about Tiny on any other Rich editor

@emudojo - please post your patch to the issue queue for this module, cheers.

Oh my! This is the best module to tackle IE6 bugs. Better then all the PNG fixes I've tried so far. Can't express my gratitude enough!

Please, accept this module into Drupal's project list.

This looks like an awesome module! However, one issue i am having is where the conditional statement (set_html_head) is placing the belated PNG fix. It sets it before all my CSS and javascript is loaded on the page. So, should this be setting this AFTER jquery, and other javascript is loaded? or does it work independently of that?

cheers

Helmet