-
Coding standards improvements per the http://ventral.org/ output in the commit description FILE: /var/www/drupal-7-pareview/pareview_temp/amazon_sns_endpoint.info -------------------------------------------------------------------------------- FOUND 4 ERROR(S) AFFECTING 4 LINE(S) -------------------------------------------------------------------------------- 9 | ERROR | It's only necessary to declare files[] if they declare a class or | | interface. 10 | ERROR | It's only necessary to declare files[] if they declare a class or | | interface. 13 | ERROR | It's only necessary to declare files[] if they declare a class or | | interface. 14 | ERROR | It's only necessary to declare files[] if they declare a class or | | interface. -------------------------------------------------------------------------------- FILE: /var/www/drupal-7-pareview/pareview_temp/amazon_sns_endpoint.install -------------------------------------------------------------------------------- FOUND 4 ERROR(S) AND 2 WARNING(S) AFFECTING 4 LINE(S) -------------------------------------------------------------------------------- 4 | ERROR | The second line in the file doc comment must be " * @file" 5 | ERROR | The third line in the file doc comment must contain a | | description and must not be indented 8 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().", or "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar.tpl.php.". 8 | ERROR | Function comment short description must end with a full stop 19 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().", or "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar.tpl.php.". 19 | ERROR | Function comment short description must end with a full stop -------------------------------------------------------------------------------- FILE: /var/www/drupal-7-pareview/pareview_temp/amazon_sns_endpoint.module -------------------------------------------------------------------------------- FOUND 19 ERROR(S) AND 9 WARNING(S) AFFECTING 21 LINE(S) -------------------------------------------------------------------------------- 4 | ERROR | The second line in the file doc comment must be " * @file" 16 | WARNING | Format should be "* Implements hook_foo().", "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar().", or "* Implements | | hook_foo_BAR_ID_bar() for xyz_bar.tpl.php.". 16 | ERROR | Function comment short description must end with a full stop 59 | ERROR | Function comment short description must be on a single line 59 | ERROR | Function comment short description must end with a full stop 65 | ERROR | Inline doc block comments are not allowed; use "// Comment" | | instead 73 | WARNING | Line exceeds 80 characters; contains 115 characters 74 | WARNING | Line exceeds 80 characters; contains 111 characters 75 | WARNING | Line exceeds 80 characters; contains 110 characters 76 | WARNING | Line exceeds 80 characters; contains 99 characters 81 | ERROR | Inline doc block comments are not allowed; use "// Comment" | | instead 88 | WARNING | Line exceeds 80 characters; contains 127 characters 89 | WARNING | Line exceeds 80 characters; contains 91 characters 154 | WARNING | Line exceeds 80 characters; contains 117 characters 249 | WARNING | Avoid backslash escaping in translatable strings when | | possible, use "" quotes instead 264 | ERROR | Missing parameter type at position 1 264 | ERROR | Missing comment for param "$key_file_url" at position 1 265 | ERROR | Missing parameter type at position 2 265 | ERROR | Missing comment for param "$signature_string" at position 2 266 | ERROR | Missing parameter type at position 3 266 | ERROR | Missing comment for param "$data" at position 3 268 | ERROR | Missing comment for @return statement 273 | ERROR | Inline comments must start with a capital letter 273 | ERROR | Inline comments must end in full-stops, exclamation marks, or | | question marks 289 | ERROR | Missing parameter type at position 1 289 | ERROR | Missing comment for param "$url_string" at position 1 291 | ERROR | Missing comment for @return statement 300 | ERROR | Files must end in a single new line character -------------------------------------------------------------------------------- FILE: .../drupal-7-pareview/pareview_temp/includes/amazon_sns_endpoint.admin.inc -------------------------------------------------------------------------------- FOUND 13 ERROR(S) AFFECTING 8 LINE(S) -------------------------------------------------------------------------------- 4 | ERROR | The second line in the file doc comment must be " * @file" 11 | ERROR | Missing parameter type at position 1 11 | ERROR | Missing comment for param "$form" at position 1 12 | ERROR | Missing parameter type at position 2 12 | ERROR | Missing comment for param "$form_state" at position 2 52 | ERROR | Concatenating translatable strings is not allowed, use | | placeholders instead and only one string literal 76 | ERROR | Function comment short description must be on a single line 79 | ERROR | Missing parameter type at position 1 79 | ERROR | Missing comment for param "$form" at position 1 80 | ERROR | Missing parameter type at position 2 80 | ERROR | Missing comment for param "$form_state" at position 2 81 | ERROR | Missing parameter type at position 3 81 | ERROR | Missing comment for param "$form_id" at position 3 -------------------------------------------------------------------------------- FILE: ...pal-7-pareview/pareview_temp/includes/amazon_sns_endpoint.test_form.inc -------------------------------------------------------------------------------- FOUND 30 ERROR(S) AND 2 WARNING(S) AFFECTING 22 LINE(S) -------------------------------------------------------------------------------- 4 | ERROR | The second line in the file doc comment must be " * @file" 11 | ERROR | Missing parameter type at position 1 11 | ERROR | Missing comment for param "$form" at position 1 12 | ERROR | Missing parameter type at position 2 12 | ERROR | Missing comment for param "$form_state" at position 2 32 | WARNING | Avoid backslash escaping in translatable strings when | | possible, use "" quotes instead 33 | ERROR | Concatenating translatable strings is not allowed, use | | placeholders instead and only one string literal 40 | ERROR | Array indentation error, expected 8 spaces but found 6 41 | ERROR | Array indentation error, expected 8 spaces but found 6 71 | ERROR | Function comment short description must be on a single line 75 | ERROR | Missing parameter type at position 1 75 | ERROR | Missing comment for param "$form" at position 1 76 | ERROR | Missing parameter type at position 2 76 | ERROR | Missing comment for param "$form_state" at position 2 77 | ERROR | Superfluous doc comment at position 3 77 | ERROR | Missing parameter type at position 3 77 | ERROR | Missing comment for param "$form_id" at position 3 92 | WARNING | Line exceeds 80 characters; contains 85 characters 101 | ERROR | Function comment short description must be on a single line 104 | ERROR | Missing parameter type at position 1 104 | ERROR | Missing comment for param "$form" at position 1 105 | ERROR | Missing parameter type at position 2 105 | ERROR | Missing comment for param "$form_state" at position 2 106 | ERROR | Superfluous doc comment at position 3 106 | ERROR | Missing parameter type at position 3 106 | ERROR | Missing comment for param "$form_id" at position 3 115 | ERROR | Expected 1 space after comma in function call; 12 found 117 | ERROR | Expected 1 space after comma in function call; 11 found 118 | ERROR | Expected 1 space after comma in function call; 5 found 119 | ERROR | Expected 1 space after comma in function call; 5 found 121 | ERROR | Space before opening parenthesis of function call prohibited 127 | ERROR | Files must end in a single new line character -------------------------------------------------------------------------------- Signed-off-by: Alex Harries <alex@greyhead.co.uk>