diff --git a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/widget/TaxonomyAutocompleteWidget.php b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/widget/TaxonomyAutocompleteWidget.php index 4aeb711..87a73d2 100644 --- a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/widget/TaxonomyAutocompleteWidget.php +++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/field/widget/TaxonomyAutocompleteWidget.php @@ -63,7 +63,7 @@ public function massageFormValues(array $values, array $form, array &$form_state // Collect candidate vocabularies. foreach ($field['settings']['allowed_values'] as $tree) { - if ($vocabulary = taxonomy_vocabulary_load($tree['vocabulary'])) { + if ($vocabulary = entity_load('taxonomy_vocabulary', $tree['vocabulary'])) { $vocabularies[$vocabulary->id()] = $vocabulary; } } diff --git a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/VocabularyVid.php b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/VocabularyVid.php index f479f66..9ee2920 100644 --- a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/VocabularyVid.php +++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/VocabularyVid.php @@ -26,15 +26,12 @@ class VocabularyVid extends Numeric { * Override the behavior of title(). Get the name of the vocabulary. */ function title() { - $query = db_select('taxonomy_vocabulary', 'v'); - $query->addField('v', 'name'); - $query->condition('v.vid', $this->argument); - $title = $query->execute()->fetchField(); - if (empty($title)) { - return t('No vocabulary'); + $vocabulary = entity_load('taxonomy_vocabulary', $this->argument); + if ($vocabulary) { + return check_plain($vocabulary->label()); } - return check_plain($title); + return t('No vocabulary'); } } diff --git a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_default/Tid.php b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_default/Tid.php index e657ea6..755e6bc 100644 --- a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_default/Tid.php +++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_default/Tid.php @@ -30,8 +30,8 @@ public function init(ViewExecutable $view, &$argument, $options) { if (!empty($this->options['vids'])) { $vocabularies = taxonomy_vocabulary_get_names(); foreach ($this->options['vids'] as $vid) { - if (isset($vocabularies[$vid], $vocabularies[$vid]->machine_name)) { - $this->options['vocabularies'][$vocabularies[$vid]->machine_name] = $vocabularies[$vid]->machine_name; + if (isset($vocabularies[$vid])) { + $this->options['vocabularies'][$vid] = $vid; } } } @@ -73,9 +73,9 @@ public function buildOptionsForm(&$form, &$form_state) { ); $options = array(); - $vocabularies = taxonomy_vocabulary_get_names(); + $vocabularies = entity_load_multiple('taxonomy_vocabulary'); foreach ($vocabularies as $voc) { - $options[$voc->machine_name] = check_plain($voc->name); + $options[$voc->id()] = check_plain($voc->label()); } $form['vocabularies'] = array( diff --git a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_validator/Term.php b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_validator/Term.php index 955be61..9a8402f 100644 --- a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_validator/Term.php +++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument_validator/Term.php @@ -28,10 +28,10 @@ public function init(ViewExecutable $view, &$argument, $options) { // Convert legacy vids option to machine name vocabularies. if (!empty($this->options['vids'])) { - $vocabularies = taxonomy_vocabulary_get_names(); + $vocabularies = entity_load_multiple('taxonomy_vocabulary'); foreach ($this->options['vids'] as $vid) { - if (isset($vocabularies[$vid], $vocabularies[$vid]->machine_name)) { - $this->options['vocabularies'][$vocabularies[$vid]->machine_name] = $vocabularies[$vid]->machine_name; + if (isset($vocabularies[$vid])) { + $this->options['vocabularies'][$vid] = $vocabularies[$vid]->label(); } } } @@ -47,10 +47,10 @@ protected function defineOptions() { } public function buildOptionsForm(&$form, &$form_state) { - $vocabularies = taxonomy_vocabulary_get_names(); + $vocabularies = entity_load_multiple('taxonomy_vocabulary'); $options = array(); foreach ($vocabularies as $voc) { - $options[$voc->machine_name] = check_plain($voc->name); + $options[$voc->id()] = check_plain($voc->label()); } $form['vocabularies'] = array( @@ -105,7 +105,7 @@ function validate_argument($argument) { return FALSE; } $this->argument->validated_title = check_plain($term->name); - return empty($vocabularies) || !empty($vocabularies[$term->vocabulary_machine_name]); + return empty($vocabularies) || !empty($vocabularies[$term->vid]); case 'tids': // An empty argument is not a term so doesn't pass. @@ -141,7 +141,7 @@ function validate_argument($argument) { if (count($test)) { $result = entity_load_multiple('taxonomy_term', $test); foreach ($result as $term) { - if ($vocabularies && empty($vocabularies[$term->vocabulary_machine_name])) { + if ($vocabularies && empty($vocabularies[$term->vid])) { $validated_cache[$term->id()] = FALSE; return FALSE; } @@ -166,7 +166,7 @@ function validate_argument($argument) { $term->name = str_replace(' ', '-', $term->name); } - if ($term && (empty($vocabularies) || !empty($vocabularies[$term->vocabulary_machine_name]))) { + if ($term && (empty($vocabularies) || !empty($vocabularies[$term->vid]))) { if ($type == 'convert') { $this->argument->argument = $term->id(); } diff --git a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/Taxonomy.php b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/Taxonomy.php index ec56116..a098bfd 100644 --- a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/Taxonomy.php +++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/Taxonomy.php @@ -37,10 +37,6 @@ public function init(ViewExecutable $view, &$options) { $this->additional_fields['vid'] = 'vid'; $this->additional_fields['tid'] = 'tid'; - $this->additional_fields['vocabulary_machine_name'] = array( - 'table' => 'taxonomy_vocabulary', - 'field' => 'machine_name', - ); } protected function defineOptions() { @@ -80,7 +76,6 @@ function render_link($data, $values) { $term = entity_create('taxonomy_term', array( 'tid' => $tid, 'vid' => $this->get_value($values, 'vid'), - 'vocabulary_machine_name' => $values->{$this->aliases['vocabulary_machine_name']}, )); $this->options['alter']['make_link'] = TRUE; $uri = $term->uri(); diff --git a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/TaxonomyIndexTid.php b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/TaxonomyIndexTid.php index 0b49698..9b8aa44 100644 --- a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/TaxonomyIndexTid.php +++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/TaxonomyIndexTid.php @@ -71,9 +71,9 @@ public function buildOptionsForm(&$form, &$form_state) { ); $options = array(); - $vocabularies = taxonomy_vocabulary_get_names(); + $vocabularies = entity_load_multiple('taxonomy_vocabulary'); foreach ($vocabularies as $voc) { - $options[$voc->machine_name] = check_plain($voc->name); + $options[$voc->id()] = $voc->label(); } $form['vocabularies'] = array( @@ -100,6 +100,7 @@ public function query() { } function pre_render(&$values) { + $vocabularies = entity_load_multiple('taxonomy_vocabulary'); $this->field_alias = $this->aliases['nid']; $nids = array(); foreach ($values as $result) { @@ -111,26 +112,26 @@ function pre_render(&$values) { if ($nids) { $query = db_select('taxonomy_term_data', 'td'); $query->innerJoin('taxonomy_index', 'tn', 'td.tid = tn.tid'); - $query->innerJoin('taxonomy_vocabulary', 'tv', 'td.vid = tv.vid'); + //$query->innerJoin('taxonomy_vocabulary', 'tv', 'td.vid = tv.vid'); $query->fields('td'); $query->addField('tn', 'nid', 'node_nid'); - $query->addField('tv', 'name', 'vocabulary'); - $query->addField('tv', 'machine_name', 'vocabulary_machine_name'); + //$query->addField('tv', 'name', 'vocabulary'); + //$query->addField('tv', 'machine_name', 'vocabulary_machine_name'); $query->orderby('td.weight'); $query->orderby('td.name'); $query->condition('tn.nid', $nids); $query->addTag('term_access'); $vocabs = array_filter($this->options['vocabularies']); if (!empty($this->options['limit']) && !empty($vocabs)) { - $query->condition('tv.machine_name', $vocabs); + $query->condition('td.vid', $vocabs); } $result = $query->execute(); foreach ($result as $term) { $this->items[$term->node_nid][$term->tid]['name'] = check_plain($term->name); $this->items[$term->node_nid][$term->tid]['tid'] = $term->tid; - $this->items[$term->node_nid][$term->tid]['vocabulary_machine_name'] = check_plain($term->vocabulary_machine_name); - $this->items[$term->node_nid][$term->tid]['vocabulary'] = check_plain($term->vocabulary); + $this->items[$term->node_nid][$term->tid]['vocabulary_machine_name'] = $term->id(); + $this->items[$term->node_nid][$term->tid]['vocabulary'] = check_plain($vocabularies[$term->vid]); if (!empty($this->options['link_to_taxonomy'])) { $this->items[$term->node_nid][$term->tid]['make_link'] = TRUE; diff --git a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/filter/TaxonomyIndexTid.php b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/filter/TaxonomyIndexTid.php index fa8f3de..8e38c1d 100644 --- a/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/filter/TaxonomyIndexTid.php +++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/filter/TaxonomyIndexTid.php @@ -36,8 +36,8 @@ public function init(ViewExecutable $view, &$options) { if (isset($this->options['vid']) && !empty($this->options['vid']) & empty($this->options['vocabulary'])) { $vocabularies = taxonomy_vocabulary_get_names(); $vid = $this->options['vid']; - if (isset($vocabularies[$vid], $vocabularies[$vid]->machine_name)) { - $this->options['vocabulary'] = $vocabularies[$vid]->machine_name; + if (isset($vocabularies[$vid])) { + $this->options['vocabulary'] = $vid; } } } @@ -59,17 +59,17 @@ protected function defineOptions() { } public function buildExtraOptionsForm(&$form, &$form_state) { - $vocabularies = taxonomy_vocabulary_get_names(); + $vocabularies = entity_load_multiple('taxonomy_vocabulary'); $options = array(); foreach ($vocabularies as $voc) { - $options[$voc->machine_name] = check_plain($voc->name); + $options[$voc->id()] = $voc->label(); } if ($this->options['limit']) { // We only do this when the form is displayed. if (empty($this->options['vocabulary'])) { $first_vocabulary = reset($vocabularies); - $this->options['vocabulary'] = $first_vocabulary->machine_name; + $this->options['vocabulary'] = $first_vocabulary->id(); } if (empty($this->definition['vocabulary'])) { @@ -103,7 +103,7 @@ public function buildExtraOptionsForm(&$form, &$form_state) { } function value_form(&$form, &$form_state) { - $vocabulary = taxonomy_vocabulary_machine_name_load($this->options['vocabulary']); + $vocabulary = entity_load('taxonomy_vocabulary', $this->options['vocabulary']); if (empty($vocabulary) && $this->options['limit']) { $form['markup'] = array( '#markup' => '