Index: includes/coder_i18n.inc =================================================================== RCS file: /cvs/drupal-contrib/contributions/modules/coder/includes/Attic/coder_i18n.inc,v retrieving revision 1.1.2.9 diff -u -u -p -r1.1.2.9 coder_i18n.inc --- includes/coder_i18n.inc 22 Sep 2008 12:21:32 -0000 1.1.2.9 +++ includes/coder_i18n.inc 23 Sep 2008 13:13:37 -0000 @@ -79,6 +79,7 @@ function coder_i18n_reviews() { array( '#type' => 'regex', '#value' => '[\s\(]t\s*\(\s*[\'"](\s+|.*\s+[\'"]\s*[,\)])', + '#never' => '[\s\(]t\s*\(\s*[\'"](\s+|([\'"]\s+[^,\)])*.*[^\s][\'"][,\)])', '#source' => 'allphp', '#warning_callback' => '_coder_i18n_space_starts_or_ends_t', ), Index: tests/coder_i18n.test =================================================================== RCS file: /cvs/drupal-contrib/contributions/modules/coder/tests/Attic/coder_i18n.test,v retrieving revision 1.1.2.1 diff -u -u -p -r1.1.2.1 coder_i18n.test --- tests/coder_i18n.test 22 Sep 2008 12:21:56 -0000 1.1.2.1 +++ tests/coder_i18n.test 23 Sep 2008 13:13:37 -0000 @@ -26,6 +26,11 @@ class CoderI18NTest extends CoderTestCas " \$var = t('Your rating') .'hello ';" => CODER_OK, " \$var = t('Your rating') .' hello';" => CODER_OK, " 'titleUser' => t('Your rating') .': '," => CODER_OK, + " \$var = t('This isn't a false positive ');" => CODER_NOT_OK, + " \$var = t('This isn\\'t a \"false\" positive ');" => CODER_NOT_OK, + " \$var = t('This is a false positive') . implode(', ', \$array);" => CODER_OK, + " \$var = t('This is a \\'false\\\" positive');" => CODER_OK, + " \$var = t('This is a \"false\" positive');" => CODER_OK, ); $this->runCoderTests($snippets, 'i18n'); }