Index: coder_review/coder_review.module =================================================================== RCS file: /cvs/drupal-contrib/contributions/modules/coder/coder_review/coder_review.module,v retrieving revision 1.25 diff -u -p -r1.25 coder_review.module --- coder_review/coder_review.module 26 Sep 2009 23:00:50 -0000 1.25 +++ coder_review/coder_review.module 7 Oct 2009 22:16:09 -0000 @@ -1598,6 +1598,9 @@ function do_coder_review($coder_args, $r case 'callback': do_coder_review_callback($coder_args, $review, $rule, $lines, $results); break; + case 'hook': + do_coder_review_hook($coder_args, $review, $rule, $lines, $results); + break; } } } @@ -1771,6 +1774,27 @@ function do_coder_review_callback(&$code } /** + * Check for the presence of a hook. + * + * @note + * See do_coder_review_regex() for arguments. + */ +function do_coder_review_hook(&$coder_args, $review, $rule, $lines, &$results) { + if (($module_name = basename($coder_args['#filename'], '.module')) && !empty($rule['#value'])) { + $hook = array('#value' => ' ' . $module_name . '_' . $rule['#value'] . '('); + foreach ($lines as $lineno => $line_array) { + foreach ($line_array as $line) { + if (_coder_review_search_string($line, $hook)) { + $line = $coder_args['#all_lines'][$lineno]; + $severity_name = _coder_review_severity_name($coder_args, $review, $rule); + _coder_review_error($results, $rule, $severity_name, $lineno, $line); + } + } + } + } +} + +/** * Search for a string. * * Uses the fastest available php function for searching. Index: coder_review/includes/coder_review_7x.inc =================================================================== RCS file: /cvs/drupal-contrib/contributions/modules/coder/coder_review/includes/coder_review_7x.inc,v retrieving revision 1.40 diff -u -p -r1.40 coder_review_7x.inc --- coder_review/includes/coder_review_7x.inc 26 Sep 2009 23:28:00 -0000 1.40 +++ coder_review/includes/coder_review_7x.inc 7 Oct 2009 22:16:10 -0000 @@ -190,8 +190,8 @@ function coder_review_7x_reviews() { ), // http://drupal.org/node/224333#node_access array( - '#type' => 'regex', - '#value' => 'function\s+[a-z0-9_]+_(access)\s*\(', + '#type' => 'hook', + '#value' => 'access', '#function-not' => '^\w+_node_access$', '#warning_callback' => '_coder_review_7x_hook_access_warning', ),