Index: includes/coder_6x.inc =================================================================== RCS file: /cvs/drupal-contrib/contributions/modules/coder/includes/coder_6x.inc,v retrieving revision 1.17.2.68 diff -u -p -r1.17.2.68 coder_6x.inc --- includes/coder_6x.inc 24 Sep 2008 16:40:17 -0000 1.17.2.68 +++ includes/coder_6x.inc 8 Oct 2008 21:56:55 -0000 @@ -26,6 +26,13 @@ function coder_6x_reviews() { ), array( '#type' => 'regex', + '#function' => '_menu$', + '#value' => '[\'"]access callback.*=.*\(', + '#source' => 'allphp', + '#warning_callback' => '_coder_6x_menu_access_callback_warning', + ), + array( + '#type' => 'regex', '#value' => '_form_alter\s*\(\$', '#warning_callback' => '_coder_6x_form_alter_warning', ), @@ -590,6 +597,13 @@ function _coder_6x_new_menu_loop_warning ); } +function _coder_6x_menu_access_callback_warning() { + return array( + '#warning' => t("The value for the 'access callback' must always be a string which is the the name of the function - never a function call. It may also be assigned the value TRUE or FALSE if the callback is always (or never) accessible."), + '#link' => 'http://drupal.org/node/109157', + ); +} + function _coder_6x_form_alter_warning() { return array( '#warning' => t('!hook_form_alter() parameters have changed',