BUEditor coder.module test: Fails bueditor.module * severity: normalLine 21: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $items[] = array('path' => $path.'/'.$eid, * severity: normalLine 25: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $items[] = array('path' => $path.'/'.$eid.'/delete', * severity: normalLine 30: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $items[] = array('path' => $path.'/new', * severity: normalLine 45: Arrays should be formatted with a space separating each element and assignment operator foreach ($editors as $eid=>$editor) { * severity: normalLine 46: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $rows[] = array($editor->name, l(t('Edit'), 'admin/settings/bueditor/'.$eid), l(t('Delete'), 'admin/settings/bueditor/'. $eid .'/delete')); * severity: normalLine 49: string concatenation should be formatted without a space separating the operators (dot .) and a quote $output = '

'. t('Available editors'). '

'; * severity: normalLine 49: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output = '

'. t('Available editors'). '

'; * severity: normalLine 60: missing space after comma $form = array('#tree' => TRUE,); * severity: normalLine 62: Arrays should be formatted with a space separating each element and assignment operator foreach (bueditor_editors('all') as $eid=>$editor) { * severity: normalLine 66: missing space after comma $form['user1editor'] = array('#type' => 'select', '#options' => $options, '#default_value' => variable_get('bueditor_user1', 1),); * severity: normalLine 68: Arrays should be formatted with a space separating each element and assignment operator foreach (bueditor_sorted_roles() as $rid=>$role) { * severity: normalLine 69: missing space after comma $form['roles'][$rid]['name'] = array('#type' => 'markup', '#value' => $role['name'],); * severity: normalLine 70: missing space after comma $form['roles'][$rid]['weight'] = array('#type' => 'weight', '#default_value' => $role['weight'],); * severity: normalLine 71: missing space after comma $form['roles'][$rid]['editor'] = array('#type' => 'select', '#options' => $options, '#default_value' => $role['editor'],); * severity: normalLine 73: missing space after comma $form['submit'] = array('#type' => 'submit', '#value' => t('Save'),); * severity: normalLine 97: Arrays should be formatted with a space separating each element and assignment operator foreach (bueditor_sorted_roles() as $rid=>$role) { * severity: normalLine 100: string concatenation should be formatted without a space separating the operators (dot .) and a quote $output = '

'. t('User access settings'). '

'; * severity: normalLine 100: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output = '

'. t('User access settings'). '

'; * severity: normalLine 122: Arrays should be formatted with a space separating each element and assignment operator '#options' => array(''=>t('Caption')) + bueditor_icons(), * severity: normalLine 145: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_css($path.'/admin/admin.css'); * severity: normalLine 146: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js($path.'/admin/admin.js'); * severity: normalLine 147: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js('var editorPath = "'. base_path(). $path .'/";', 'inline'); * severity: normalLine 150: string concatenation should be formatted without a space separating the operators (dot .) and a quote $demo = '

'. t('Demo'). '

'; * severity: normalLine 150: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $demo = '

'. t('Demo'). '

'; * severity: normalLine 152: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms return $help.drupal_get_form('bueditor_form_editor').$demo; * severity: normalLine 162: missing space after comma $form = array('#tree' => TRUE, '#attributes' => array('enctype' => 'multipart/form-data'),); * severity: normalLine 180: Arrays should be formatted with a space separating each element and assignment operator foreach (bueditor_buttons($eid) as $bid=>$button) { * severity: normalLine 188: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $form['button']['new'.$i] = bueditor_form_button($button); * severity: normalLine 199: Arrays should be formatted with a space separating each element and assignment operator $form['go'] = array('#type' => 'submit', '#value' => t('Go'), '#id' =>'edit-go'); * severity: normalLine 200: missing space after comma $form['submit'] = array('#type' => 'submit', '#value' => t('Save'),); * severity: normalLine 201: missing space after comma $form['buecsv'] = array('#type' => 'file', '#title' => t('CSV file containing the buttons'),); * severity: normalLine 202: missing space after comma $form['import'] = array('#type' => 'submit', '#value' => t('Import'),); * severity: normalLine 213: Arrays should be formatted with a space separating each element and assignment operator foreach ($form['button'] as $bid=>$button) { * severity: normalLine 219: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $cells[] = drupal_render($form['button'][$bid]['icon']). drupal_render($form['button'][$bid]['caption']); * severity: normalLine 222: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $cells[] = $new ? ''.t('new').'' : drupal_render($form['checks'][$bid]); * severity: normalLine 227: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $vis = theme('fieldset', array('#title' => t('Visibility settings'), '#children' => drupal_render($form['editor']['pages']). drupal_render($form['editor']['excludes']), '#collapsible' => TRUE, '#collapsed' => $eid != 'new',)); * severity: normalLine 227: missing space after comma $vis = theme('fieldset', array('#title' => t('Visibility settings'), '#children' => drupal_render($form['editor']['pages']). drupal_render($form['editor']['excludes']), '#collapsible' => TRUE, '#collapsed' => $eid != 'new',)); * severity: normalLine 230: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output .= '

'. t('Buttons') .'

'.$table.$selaction; * severity: normalLine 232: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output .= theme('fieldset', array('#title' => t('Import Buttons'), '#children' => drupal_render($form['buecsv']). drupal_render($form['import']), '#collapsible' => TRUE, '#collapsed' => TRUE,)); * severity: normalLine 232: missing space after comma $output .= theme('fieldset', array('#title' => t('Import Buttons'), '#children' => drupal_render($form['buecsv']). drupal_render($form['import']), '#collapsible' => TRUE, '#collapsed' => TRUE,)); * severity: normalLine 246: Arrays should be formatted with a space separating each element and assignment operator foreach ($_POST['button'] as $bid=>$button) { * severity: normalLine 257: Arrays should be formatted with a space separating each element and assignment operator foreach ($edit['checks'] as $bid=>$val) { * severity: normalLine 282: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms return 'admin/settings/bueditor/'.$eid; * severity: normalLine 295: Arrays should be formatted with a space separating each element and assignment operator foreach ($button as $key=>$val) { * severity: normalLine 296: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $sets[] = $key."='%s'"; * severity: normalLine 323: Arrays should be formatted with a space separating each element and assignment operator foreach ($editor as $key=>$val) { * severity: normalLine 324: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $sets[] = $key."='%s'"; * severity: normalLine 364: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms return confirm_form($form, t('Are you sure you want to delete the editor !name?', array('!name' => theme('placeholder', $name))), 'admin/settings/bueditor', t('All buttons and settings for this editor will be removed.').' '.t('This action cannot be undone.'), t('Delete'), t('Cancel')); * severity: normalLine 405: Arrays should be formatted with a space separating each element and assignment operator foreach ($buttons as $bid=>$button) { * severity: normalLine 425: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $dir = drupal_get_path('module', 'bueditor').'/icons'; * severity: normalLine 467: Control statements should have one space between the control keyword and opening parenthesis while($values = fgetcsv($fp, 100000)) { * severity: normalLine 512: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms bueditor_js_library($dir.'/library');//load common js files. * severity: normalLine 513: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if (is_dir($edir = $dir.'/library/'.$editor->name)) { * severity: normalLine 575: Arrays should be formatted with a space separating each element and assignment operator foreach ($stored as $rid=>$role) { * severity: normalLine 592: Arrays should be formatted with a space separating each element and assignment operator foreach ($roles as $rid=>$rname) { * severity: normalLine 623: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if (($now - $last) > $period && is_dir($dir = file_directory_path().'/bueditor') && $handle = @opendir($dir)) { * severity: normalLine 626: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms @unlink($dir.'/'.$file); =============================================== FCKEditor: coder.module test: FAIL (details below) # Line 48: Arrays should be formatted with a space separating each element and assignment operator $output = t("

Note: FCKeditor is highly configurable. The most commonly used features are listed below. If you want to take a look at all available settings, open !fckconfig and then customize !fckeditor_config to your needs. This is also the only way to define new toolbar sets. It is advised to not edit fckconfig.js because you may overwrite it accidentally when you update the editor.

", array('!fckconfig' =>drupal_get_path('module', 'fckeditor')."/fckeditor/fckconfig.js", '!fckeditor_config'=>drupal_get_path('module', 'fckeditor')."/fckeditor.config.js")); # severity: normalLine 48: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output = t("

Note: FCKeditor is highly configurable. The most commonly used features are listed below. If you want to take a look at all available settings, open !fckconfig and then customize !fckeditor_config to your needs. This is also the only way to define new toolbar sets. It is advised to not edit fckconfig.js because you may overwrite it accidentally when you update the editor.

", array('!fckconfig' =>drupal_get_path('module', 'fckeditor')."/fckeditor/fckconfig.js", '!fckeditor_config'=>drupal_get_path('module', 'fckeditor')."/fckeditor.config.js")); # severity: normalLine 74: missing space after comma $output .= t('The correct directory structure is as follows: 
!structure
',array( # severity: normalLine 75: Arrays should be formatted with a space separating each element and assignment operator '!structure'=>"modules\n fckeditor\n fckeditor.module\n fckeditor\n _samples\n editor\n COPY_HERE.txt\n fckconfig.js\n ..." # severity: normalLine 79: missing space after comma '!path1' => l(t('Administer > Settings > FCKeditor'),'admin/settings/fckeditor'), # severity: normalLine 80: missing space after comma '!path2' => l(t('Administer > User Management > Access Control'),'admin/user/access'), # severity: normalLine 85: Arrays should be formatted with a space separating each element and assignment operator '!filterlink'=> l(t('filters'), 'admin/settings/filters')) # severity: normalLine 89: Use an indent of 2 spaces, with no tabs '!fckeditor.config.js' => base_path() . drupal_get_path('module', 'fckeditor') . 'fckeditor.config.js', # severity: normalLine 89: string concatenation should be formatted without a space separating the operators (dot .) and a quote '!fckeditor.config.js' => base_path() . drupal_get_path('module', 'fckeditor') . 'fckeditor.config.js', # severity: normalLine 90: Use an indent of 2 spaces, with no tabs '!code' => " # severity: normalLine 95: Use an indent of 2 spaces, with no tabs '!buttons1' => "['Image','Flash','Table','Rule','SpecialChar']", # severity: normalLine 96: Use an indent of 2 spaces, with no tabs '!buttons2' => "['Image','Flash','Table','Rule','SpecialChar', 'DrupalBreak', 'DrupalPageBreak']", # severity: normalLine 103: missing space after comma $output .= t('

Security

Note that enabling file uploads is a security risk. That\'s why there is a !link in Administer > User Management > Access Control for enabling the file browser to certain groups.

', array('!link' => l(t('separate permission'),'admin/user/access'))); # severity: normalLine 114: missing space after comma HEREDOC,array( # severity: normalLine 242: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 243: string concatenation should be formatted without a space separating the operators (dot .) and a quote $fckconfig_file = $module_drupal_path . '/fckeditor/fckconfig.js'; # severity: normalLine 249: Arrays should be formatted with a space separating each element and assignment operator '!fckeditorlink'=>l(t('FCKeditor homepage'), 'http://www.fckeditor.net'), # severity: normalLine 338: string concatenation should be formatted without a space separating the operators (dot .) and a quote $rows[] = array(array('data' => $p->name, 'valign' => 'top'), array('data' => implode("
\n", $p->rids)), array('data' => l(t('edit'), 'admin/settings/fckeditor/edit/'. urlencode($p->name)) . ' '. l(t('delete'), 'admin/settings/fckeditor/delete/'. urlencode($p->name)), 'valign' => 'top')); # severity: normalLine 380: Functions should be called with no spaces between the function name case (1): # severity: normalLine 384: Functions should be called with no spaces between the function name case (2): # severity: normalLine 390: Control statements should have one space between the control keyword and opening parenthesis if(preg_match($regexp, $path)) { # severity: normalLine 394: Functions should be called with no spaces between the function name case (3): # severity: normalLine 399: Control statements should have one space between the control keyword and opening parenthesis if(preg_match($regexp, $path)) { # severity: normalLine 403: Functions should be called with no spaces between the function name case (0): # severity: normalLine 446: string concatenation should be formatted without a space separating the operators (dot .) and a quote $js_id = 'oFCK_' . $num++; # severity: normalLine 453: missing space after comma foreach (array('default','show_toggle','popup','skin','toolbar','expand','width','lang','auto_lang') as $setting) { # severity: normalLine 461: string concatenation should be formatted without a space separating the operators (dot .) and a quote $themepath = path_to_theme() . '/'; # severity: normalLine 472: do not use mixed case (camelCase), use lower case and _ $fckeditorOn = ($conf['default']=='t') ? 1 : 0 ; # severity: normalLine 474: string concatenation should be formatted without a space separating the operators (dot .) and a quote $wysiwyg_link = "
\n"; # severity: normalLine 474: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $wysiwyg_link = "
\n"; # severity: normalLine 475: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $wysiwyg_link .= ""; # severity: normalLine 475: do not use mixed case (camelCase), use lower case and _ $wysiwyg_link .= ""; # severity: normalLine 476: do not use mixed case (camelCase), use lower case and _ $wysiwyg_link .= $fckeditorOn ? t("Switch to plain text editor") : t("Switch to rich text editor"); # severity: normalLine 488: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 489: Use an indent of 2 spaces, with no tabs $module_full_path = base_path() . $module_drupal_path; # severity: normalLine 509: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($module_drupal_path . '/fckeditor/fckeditor.js'); # severity: normalLine 510: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($module_drupal_path . '/fckeditor.utils.js'); # severity: normalLine 517: do not use mixed case (camelCase), use lower case and _ $forceSimpleToolbar = fckeditor_is_enabled($conf['simple_incl_mode'], $conf['simple_incl_list'], $element['#id'], $_GET['q']); # severity: normalLine 518: do not use mixed case (camelCase), use lower case and _ if ($forceSimpleToolbar) { # severity: normalLine 522: do not use mixed case (camelCase), use lower case and _ $textareaID = $profile->settings['show_toggle'] == 't' ? $js_id : $element['#id']; # severity: normalLine 525: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms var ".$js_id." = new FCKeditor( '".$textareaID."' ); # severity: normalLine 525: do not use mixed case (camelCase), use lower case and _ var ".$js_id." = new FCKeditor( '".$textareaID."' ); # severity: normalLine 526: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".BasePath = '".$module_full_path."/fckeditor/'; # severity: normalLine 527: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['CustomConfigurationsPath'] = '".$module_full_path."/fckeditor.config.js'; # severity: normalLine 528: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['TextareaID'] = '".$element['#id']."';"; # severity: normalLine 531: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= "\n".$js_id.".ToolbarSet = '".$toolbar."'; # severity: normalLine 532: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['SkinPath'] = ".$js_id.".BasePath + 'editor/skins/".$conf['skin']."/'; # severity: normalLine 533: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['DefaultLanguage'] = '".$conf['lang']."'; # severity: normalLine 534: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['AutoDetectLanguage'] = '".($conf['auto_lang']=="t"?"true":"false")."'; # severity: normalLine 535: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Height = '".$height."'; # severity: normalLine 536: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ToolbarStartExpanded'] = '".($conf['expand']=="t"?"true":"false")."'; # severity: normalLine 537: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Width = '".$width."';\n"; # severity: normalLine 540: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= "\n".$js_id.".Config['EnterMode'] = '".$conf['enter_mode']."'; # severity: normalLine 541: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ShiftEnterMode'] = '".$conf['shift_enter_mode']."'; # severity: normalLine 542: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FontFormats'] = '".str_replace(",",";",$conf['font_format'])."'; # severity: normalLine 542: missing space after comma ".$js_id.".Config['FontFormats'] = '".str_replace(",",";",$conf['font_format'])."'; # severity: normalLine 543: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FormatSource'] = '".($conf['format_source']=="t"?"true":"false")."'; # severity: normalLine 544: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FormatOutput'] = '".($conf['format_output']=="t"?"true":"false")."';\n"; # severity: normalLine 559: string concatenation should be formatted without a space separating the operators (dot .) and a quote $connector_path = $module_drupal_path . "/fckeditor/editor/filemanager/connectors/php/connector.php" ; # severity: normalLine 561: string concatenation should be formatted without a space separating the operators (dot .) and a quote $upload_path = $module_drupal_path . "/fckeditor/editor/filemanager/connectors/php/upload.php" ; # severity: normalLine 564: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkBrowserURL'] = '".$module_full_path."/fckeditor/editor/filemanager/browser/default/browser.html?Connector=".$connector_path."&ServerPath=".$files_path."'; # severity: normalLine 565: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageBrowserURL'] = '".$module_full_path."/fckeditor/editor/filemanager/browser/default/browser.html?Type=Image&Connector=".$connector_path."&ServerPath=".$files_path."'; # severity: normalLine 566: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashBrowserURL'] = '".$module_full_path."/fckeditor/editor/filemanager/browser/default/browser.html?Type=Flash&Connector=".$connector_path."&ServerPath=".$files_path."';\n"; # severity: normalLine 569: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkBrowser'] = false; # severity: normalLine 570: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageBrowser'] = false; # severity: normalLine 571: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashBrowser'] = false;\n"; # severity: normalLine 574: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkUploadURL'] = '".$module_full_path . $upload_path."'; # severity: normalLine 575: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageUploadURL'] = '".$module_full_path . $upload_path."?Type=Image'; # severity: normalLine 576: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashUploadURL'] = '".$module_full_path . $upload_path."?Type=Flash';\n"; # severity: normalLine 579: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkUpload'] = false; # severity: normalLine 580: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageUpload'] = false; # severity: normalLine 581: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashUpload'] = false;\n"; # severity: normalLine 586: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkBrowser'] = false; # severity: normalLine 587: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageBrowser'] = false; # severity: normalLine 588: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashBrowser'] = false; # severity: normalLine 589: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['LinkUpload'] = false; # severity: normalLine 590: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageUpload'] = false; # severity: normalLine 591: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashUpload'] = false;\n"; # severity: normalLine 595: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if (file_exists($themepath.'/fckstyles.xml')) { # severity: normalLine 596: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $styles_xml_path = $host.$themepath.'/fckstyles.xml'; # severity: normalLine 597: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['StylesXmlPath'] = '".$styles_xml_path."';\n"; # severity: normalLine 603: string concatenation should be formatted without a space separating the operators (dot .) and a quote $css = $themepath . 'style.css'; # severity: normalLine 605: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['EditorAreaCSS'] = '".$host . $css.",".$module_full_path."/fckeditor.css';"; # severity: normalLine 609: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['EditorAreaCSS'] = '".str_replace(array('%h', '%t'), array($host, $themepath), $conf['css_path']).",".$module_full_path."/fckeditor.css';"; # severity: normalLine 616: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($module_drupal_path . '/fckeditor.popup.js'); # severity: normalLine 617: string concatenation should be formatted without a space separating the operators (dot .) and a quote $element['#suffix'] .= " (" . t('Open rich editor') . ")"; # severity: normalLine 617: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= " (" . t('Open rich editor') . ")"; # severity: normalLine 622: do not use mixed case (camelCase), use lower case and _ if ($fckeditorOn) { # severity: normalLine 623: Use an indent of 2 spaces, with no tabs drupal_add_js('if (Drupal.jsEnabled) {$(document).ready(function() {'.$js_id.'.ReplaceTextarea();});}', 'inline', 'footer'); # severity: normalLine 623: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js('if (Drupal.jsEnabled) {$(document).ready(function() {'.$js_id.'.ReplaceTextarea();});}', 'inline', 'footer'); # severity: normalLine 630: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= '
The ID for for excluding or including this element is: '.$element['#id'].' - the path is: '.$_GET['q'].'
'; # severity: normalLine 660: missing space after comma '#options' => array('t' => t('enabled'),'f' => t('disabled')), # severity: normalLine 760: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 761: string concatenation should be formatted without a space separating the operators (dot .) and a quote $fckconfig_js = $module_drupal_path . '/fckeditor/fckconfig.js'; # severity: normalLine 762: string concatenation should be formatted without a space separating the operators (dot .) and a quote $fckeditor_config_js = $module_drupal_path . '/fckeditor.config.js'; # severity: normalLine 767: missing space after comma $line = fgets($fp,1024); # severity: normalLine 779: missing space after comma $line = fgets($fp,1024); # severity: normalLine 802: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 803: string concatenation should be formatted without a space separating the operators (dot .) and a quote $skin_dir = $module_drupal_path . '/fckeditor/editor/skins'; # severity: normalLine 806: Control statements should have one space between the control keyword and opening parenthesis if( false !== $dh ) { # severity: normalLine 807: Control statements should have one space between the control keyword and opening parenthesis while(($file = readdir($dh)) !== false ) { # severity: normalLine 808: Control statements should have one space between the control keyword and opening parenthesis if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 808: use a space between the closing parenthesis and the open bracket if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 808: missing space after comma if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 811: Control statements should have one space between the control keyword and opening parenthesis if(is_dir($skin_dir.DIRECTORY_SEPARATOR.$file)) { # severity: normalLine 811: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if(is_dir($skin_dir.DIRECTORY_SEPARATOR.$file)) { # severity: normalLine 832: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 833: string concatenation should be formatted without a space separating the operators (dot .) and a quote $lang_dir = $module_drupal_path . '/fckeditor/editor/lang'; # severity: normalLine 836: Control statements should have one space between the control keyword and opening parenthesis if( false !== $dh ) { # severity: normalLine 837: Control statements should have one space between the control keyword and opening parenthesis while(($file = readdir($dh)) !== false) { # severity: normalLine 838: Control statements should have one space between the control keyword and opening parenthesis if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 838: use a space between the closing parenthesis and the open bracket if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 838: missing space after comma if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 841: Control statements should have one space between the control keyword and opening parenthesis if(is_file($lang_dir.DIRECTORY_SEPARATOR.$file) && preg_match("/^(.*?)\.js$/",$file,$matches)) { # severity: normalLine 841: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if(is_file($lang_dir.DIRECTORY_SEPARATOR.$file) && preg_match("/^(.*?)\.js$/",$file,$matches)) { # severity: normalLine 841: missing space after comma if(is_file($lang_dir.DIRECTORY_SEPARATOR.$file) && preg_match("/^(.*?)\.js$/",$file,$matches)) { # severity: normalLine 864: Use an indent of 2 spaces, with no tabs 'en-au' => 'English (Australia)', # severity: normalLine 865: Use an indent of 2 spaces, with no tabs 'en-ca' => 'English (Canadian)', # severity: normalLine 866: Use an indent of 2 spaces, with no tabs 'en-uk' => 'English (United Kingdom)', # severity: normalLine 893: Use an indent of 2 spaces, with no tabs 'pt-br' => 'Portuguese (Brazil)', # severity: normalLine 899: Use an indent of 2 spaces, with no tabs 'sr-latn' => 'Serbian (Latin)', # severity: normalLine 906: Use an indent of 2 spaces, with no tabs 'zh-cn' => 'Chinese Simplified', # severity: normalLine 932: use a space between the closing parenthesis and the open bracket if (!in_array($data->rid, array_keys((array) $edit->rids)) && !form_get_errors()){ # severity: normalLine 937: Arrays should be formatted with a space separating each element and assignment operator drupal_set_message(t('You must assign at least one role with the \'access fckeditor\' permission before creating a profile.', array('!access-control-url' => url('admin/user/access'),'!access1'=>t('access fckeditor'))), 'error'); # severity: normalLine 937: missing space after comma drupal_set_message(t('You must assign at least one role with the \'access fckeditor\' permission before creating a profile.', array('!access-control-url' => url('admin/user/access'),'!access1'=>t('access fckeditor'))), 'error'); # severity: normalLine 1033: missing space after comma '#description' => t('Choose what to do with the following values.
FCKeditor will force the !simple toolbar on the selected fields.
Useful for smaller textareas where we usually don\'t use very complicated HTML code, like in signatures.',array('!simple' => FCKEDITOR_FORCE_SIMPLE_TOOLBAR_NAME)), # severity: normalLine 1061: missing space after comma '#options' => array('t' => t('enabled'),'f' => t('disabled')), # severity: normalLine 1219: string concatenation should be formatted without a space separating the operators (dot .) and a quote '#description' => t('Enter path to CSS file (example: "css/editor.css") or a list of css files seperated by a comma (example: /themes/garland/style.css,http://example.com/style.css).
Macros: %h (host name: !host), %t (path to theme: !theme)
Be sure to select "define css" above.', array('!host' => base_path(), '!theme' => path_to_theme() . '/')) # severity: normalLine 1226: string concatenation should be formatted without a space separating the operators (dot .) and a quote '#description' => t('Style dropdown list loads styles defined in !fckstyles.xml. Copy this file inside your theme directory (!theme) and adjust it to your needs. If you modify the original file, changes will be applied to all themes, however it may get overwritten if you upgrade FCKeditor.', array('!fckstyles.xml' => drupal_get_path('module', 'fckeditor').'/fckeditor/fckstyles.xml', '!theme' => path_to_theme() . '/fckstyles.xml')) # severity: normalLine 1226: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms '#description' => t('Style dropdown list loads styles defined in !fckstyles.xml. Copy this file inside your theme directory (!theme) and adjust it to your needs. If you modify the original file, changes will be applied to all themes, however it may get overwritten if you upgrade FCKeditor.', array('!fckstyles.xml' => drupal_get_path('module', 'fckeditor').'/fckeditor/fckstyles.xml', '!theme' => path_to_theme() . '/fckstyles.xml')) # severity: normalLine 1299: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if (!empty($value) && preg_match('/^'.str_replace('*','.*',addslashes($value)).'$/i', $search)) { # severity: normalLine 1299: missing space after comma if (!empty($value) && preg_match('/^'.str_replace('*','.*',addslashes($value)).'$/i', $search)) { # severity: normalLine 1317: string concatenation should be formatted without a space separating the operators (dot .) and a quote $fckeditor_main_file = drupal_get_path('module', 'fckeditor') . '/fckeditor/fckeditor.php'; # severity: normalLine 1321: do not use mixed case (camelCase), use lower case and _ return FCKeditor_IsCompatibleBrowser(); # severity: normalLine 1324: do not use mixed case (camelCase), use lower case and _ $fck = new FCKeditor("fake"); # severity: normalLine 1325: do not use mixed case (camelCase), use lower case and _ return $fck->IsCompatible(); # severity: normalLine 1332: use a space between the closing parenthesis and the open bracket function fckeditor_user_get_setting($user, $profile, $setting){ # severity: normalLine 1347: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $status = isset($user->{"fckeditor_".$setting}) ? $user->{"fckeditor_".$setting} : (isset($settings[$setting]) ? $settings[$setting] : $default[$setting]); # severity: normalLine 1358: use a space between the closing parenthesis and the open bracket if ($profile_name){ ======================================================= HTMLArea coder.module test: FAIL (details below) # Line 48: Arrays should be formatted with a space separating each element and assignment operator $output = t("

Note: FCKeditor is highly configurable. The most commonly used features are listed below. If you want to take a look at all available settings, open !fckconfig and then customize !fckeditor_config to your needs. This is also the only way to define new toolbar sets. It is advised to not edit fckconfig.js because you may overwrite it accidentally when you update the editor.

", array('!fckconfig' =>drupal_get_path('module', 'fckeditor')."/fckeditor/fckconfig.js", '!fckeditor_config'=>drupal_get_path('module', 'fckeditor')."/fckeditor.config.js")); # severity: normalLine 48: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output = t("

Note: FCKeditor is highly configurable. The most commonly used features are listed below. If you want to take a look at all available settings, open !fckconfig and then customize !fckeditor_config to your needs. This is also the only way to define new toolbar sets. It is advised to not edit fckconfig.js because you may overwrite it accidentally when you update the editor.

", array('!fckconfig' =>drupal_get_path('module', 'fckeditor')."/fckeditor/fckconfig.js", '!fckeditor_config'=>drupal_get_path('module', 'fckeditor')."/fckeditor.config.js")); # severity: normalLine 74: missing space after comma $output .= t('The correct directory structure is as follows: 
!structure
',array( # severity: normalLine 75: Arrays should be formatted with a space separating each element and assignment operator '!structure'=>"modules\n fckeditor\n fckeditor.module\n fckeditor\n _samples\n editor\n COPY_HERE.txt\n fckconfig.js\n ..." # severity: normalLine 79: missing space after comma '!path1' => l(t('Administer > Settings > FCKeditor'),'admin/settings/fckeditor'), # severity: normalLine 80: missing space after comma '!path2' => l(t('Administer > User Management > Access Control'),'admin/user/access'), # severity: normalLine 85: Arrays should be formatted with a space separating each element and assignment operator '!filterlink'=> l(t('filters'), 'admin/settings/filters')) # severity: normalLine 89: Use an indent of 2 spaces, with no tabs '!fckeditor.config.js' => base_path() . drupal_get_path('module', 'fckeditor') . 'fckeditor.config.js', # severity: normalLine 89: string concatenation should be formatted without a space separating the operators (dot .) and a quote '!fckeditor.config.js' => base_path() . drupal_get_path('module', 'fckeditor') . 'fckeditor.config.js', # severity: normalLine 90: Use an indent of 2 spaces, with no tabs '!code' => " # severity: normalLine 95: Use an indent of 2 spaces, with no tabs '!buttons1' => "['Image','Flash','Table','Rule','SpecialChar']", # severity: normalLine 96: Use an indent of 2 spaces, with no tabs '!buttons2' => "['Image','Flash','Table','Rule','SpecialChar', 'DrupalBreak', 'DrupalPageBreak']", # severity: normalLine 103: missing space after comma $output .= t('

Security

Note that enabling file uploads is a security risk. That\'s why there is a !link in Administer > User Management > Access Control for enabling the file browser to certain groups.

', array('!link' => l(t('separate permission'),'admin/user/access'))); # severity: normalLine 114: missing space after comma HEREDOC,array( # severity: normalLine 242: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 243: string concatenation should be formatted without a space separating the operators (dot .) and a quote $fckconfig_file = $module_drupal_path . '/fckeditor/fckconfig.js'; # severity: normalLine 249: Arrays should be formatted with a space separating each element and assignment operator '!fckeditorlink'=>l(t('FCKeditor homepage'), 'http://www.fckeditor.net'), # severity: normalLine 338: string concatenation should be formatted without a space separating the operators (dot .) and a quote $rows[] = array(array('data' => $p->name, 'valign' => 'top'), array('data' => implode("
\n", $p->rids)), array('data' => l(t('edit'), 'admin/settings/fckeditor/edit/'. urlencode($p->name)) . ' '. l(t('delete'), 'admin/settings/fckeditor/delete/'. urlencode($p->name)), 'valign' => 'top')); # severity: normalLine 380: Functions should be called with no spaces between the function name case (1): # severity: normalLine 384: Functions should be called with no spaces between the function name case (2): # severity: normalLine 390: Control statements should have one space between the control keyword and opening parenthesis if(preg_match($regexp, $path)) { # severity: normalLine 394: Functions should be called with no spaces between the function name case (3): # severity: normalLine 399: Control statements should have one space between the control keyword and opening parenthesis if(preg_match($regexp, $path)) { # severity: normalLine 403: Functions should be called with no spaces between the function name case (0): # severity: normalLine 446: string concatenation should be formatted without a space separating the operators (dot .) and a quote $js_id = 'oFCK_' . $num++; # severity: normalLine 453: missing space after comma foreach (array('default','show_toggle','popup','skin','toolbar','expand','width','lang','auto_lang') as $setting) { # severity: normalLine 461: string concatenation should be formatted without a space separating the operators (dot .) and a quote $themepath = path_to_theme() . '/'; # severity: normalLine 472: do not use mixed case (camelCase), use lower case and _ $fckeditorOn = ($conf['default']=='t') ? 1 : 0 ; # severity: normalLine 474: string concatenation should be formatted without a space separating the operators (dot .) and a quote $wysiwyg_link = "
\n"; # severity: normalLine 474: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $wysiwyg_link = "
\n"; # severity: normalLine 475: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $wysiwyg_link .= ""; # severity: normalLine 475: do not use mixed case (camelCase), use lower case and _ $wysiwyg_link .= ""; # severity: normalLine 476: do not use mixed case (camelCase), use lower case and _ $wysiwyg_link .= $fckeditorOn ? t("Switch to plain text editor") : t("Switch to rich text editor"); # severity: normalLine 488: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 489: Use an indent of 2 spaces, with no tabs $module_full_path = base_path() . $module_drupal_path; # severity: normalLine 509: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($module_drupal_path . '/fckeditor/fckeditor.js'); # severity: normalLine 510: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($module_drupal_path . '/fckeditor.utils.js'); # severity: normalLine 517: do not use mixed case (camelCase), use lower case and _ $forceSimpleToolbar = fckeditor_is_enabled($conf['simple_incl_mode'], $conf['simple_incl_list'], $element['#id'], $_GET['q']); # severity: normalLine 518: do not use mixed case (camelCase), use lower case and _ if ($forceSimpleToolbar) { # severity: normalLine 522: do not use mixed case (camelCase), use lower case and _ $textareaID = $profile->settings['show_toggle'] == 't' ? $js_id : $element['#id']; # severity: normalLine 525: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms var ".$js_id." = new FCKeditor( '".$textareaID."' ); # severity: normalLine 525: do not use mixed case (camelCase), use lower case and _ var ".$js_id." = new FCKeditor( '".$textareaID."' ); # severity: normalLine 526: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".BasePath = '".$module_full_path."/fckeditor/'; # severity: normalLine 527: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['CustomConfigurationsPath'] = '".$module_full_path."/fckeditor.config.js'; # severity: normalLine 528: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['TextareaID'] = '".$element['#id']."';"; # severity: normalLine 531: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= "\n".$js_id.".ToolbarSet = '".$toolbar."'; # severity: normalLine 532: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['SkinPath'] = ".$js_id.".BasePath + 'editor/skins/".$conf['skin']."/'; # severity: normalLine 533: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['DefaultLanguage'] = '".$conf['lang']."'; # severity: normalLine 534: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['AutoDetectLanguage'] = '".($conf['auto_lang']=="t"?"true":"false")."'; # severity: normalLine 535: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Height = '".$height."'; # severity: normalLine 536: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ToolbarStartExpanded'] = '".($conf['expand']=="t"?"true":"false")."'; # severity: normalLine 537: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Width = '".$width."';\n"; # severity: normalLine 540: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= "\n".$js_id.".Config['EnterMode'] = '".$conf['enter_mode']."'; # severity: normalLine 541: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ShiftEnterMode'] = '".$conf['shift_enter_mode']."'; # severity: normalLine 542: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FontFormats'] = '".str_replace(",",";",$conf['font_format'])."'; # severity: normalLine 542: missing space after comma ".$js_id.".Config['FontFormats'] = '".str_replace(",",";",$conf['font_format'])."'; # severity: normalLine 543: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FormatSource'] = '".($conf['format_source']=="t"?"true":"false")."'; # severity: normalLine 544: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FormatOutput'] = '".($conf['format_output']=="t"?"true":"false")."';\n"; # severity: normalLine 559: string concatenation should be formatted without a space separating the operators (dot .) and a quote $connector_path = $module_drupal_path . "/fckeditor/editor/filemanager/connectors/php/connector.php" ; # severity: normalLine 561: string concatenation should be formatted without a space separating the operators (dot .) and a quote $upload_path = $module_drupal_path . "/fckeditor/editor/filemanager/connectors/php/upload.php" ; # severity: normalLine 564: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkBrowserURL'] = '".$module_full_path."/fckeditor/editor/filemanager/browser/default/browser.html?Connector=".$connector_path."&ServerPath=".$files_path."'; # severity: normalLine 565: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageBrowserURL'] = '".$module_full_path."/fckeditor/editor/filemanager/browser/default/browser.html?Type=Image&Connector=".$connector_path."&ServerPath=".$files_path."'; # severity: normalLine 566: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashBrowserURL'] = '".$module_full_path."/fckeditor/editor/filemanager/browser/default/browser.html?Type=Flash&Connector=".$connector_path."&ServerPath=".$files_path."';\n"; # severity: normalLine 569: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkBrowser'] = false; # severity: normalLine 570: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageBrowser'] = false; # severity: normalLine 571: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashBrowser'] = false;\n"; # severity: normalLine 574: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkUploadURL'] = '".$module_full_path . $upload_path."'; # severity: normalLine 575: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageUploadURL'] = '".$module_full_path . $upload_path."?Type=Image'; # severity: normalLine 576: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashUploadURL'] = '".$module_full_path . $upload_path."?Type=Flash';\n"; # severity: normalLine 579: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkUpload'] = false; # severity: normalLine 580: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageUpload'] = false; # severity: normalLine 581: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashUpload'] = false;\n"; # severity: normalLine 586: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['LinkBrowser'] = false; # severity: normalLine 587: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageBrowser'] = false; # severity: normalLine 588: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashBrowser'] = false; # severity: normalLine 589: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['LinkUpload'] = false; # severity: normalLine 590: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['ImageUpload'] = false; # severity: normalLine 591: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms ".$js_id.".Config['FlashUpload'] = false;\n"; # severity: normalLine 595: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if (file_exists($themepath.'/fckstyles.xml')) { # severity: normalLine 596: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $styles_xml_path = $host.$themepath.'/fckstyles.xml'; # severity: normalLine 597: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['StylesXmlPath'] = '".$styles_xml_path."';\n"; # severity: normalLine 603: string concatenation should be formatted without a space separating the operators (dot .) and a quote $css = $themepath . 'style.css'; # severity: normalLine 605: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['EditorAreaCSS'] = '".$host . $css.",".$module_full_path."/fckeditor.css';"; # severity: normalLine 609: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= $js_id.".Config['EditorAreaCSS'] = '".str_replace(array('%h', '%t'), array($host, $themepath), $conf['css_path']).",".$module_full_path."/fckeditor.css';"; # severity: normalLine 616: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($module_drupal_path . '/fckeditor.popup.js'); # severity: normalLine 617: string concatenation should be formatted without a space separating the operators (dot .) and a quote $element['#suffix'] .= " (" . t('Open rich editor') . ")"; # severity: normalLine 617: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= " (" . t('Open rich editor') . ")"; # severity: normalLine 622: do not use mixed case (camelCase), use lower case and _ if ($fckeditorOn) { # severity: normalLine 623: Use an indent of 2 spaces, with no tabs drupal_add_js('if (Drupal.jsEnabled) {$(document).ready(function() {'.$js_id.'.ReplaceTextarea();});}', 'inline', 'footer'); # severity: normalLine 623: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js('if (Drupal.jsEnabled) {$(document).ready(function() {'.$js_id.'.ReplaceTextarea();});}', 'inline', 'footer'); # severity: normalLine 630: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $element['#suffix'] .= '
The ID for for excluding or including this element is: '.$element['#id'].' - the path is: '.$_GET['q'].'
'; # severity: normalLine 660: missing space after comma '#options' => array('t' => t('enabled'),'f' => t('disabled')), # severity: normalLine 760: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 761: string concatenation should be formatted without a space separating the operators (dot .) and a quote $fckconfig_js = $module_drupal_path . '/fckeditor/fckconfig.js'; # severity: normalLine 762: string concatenation should be formatted without a space separating the operators (dot .) and a quote $fckeditor_config_js = $module_drupal_path . '/fckeditor.config.js'; # severity: normalLine 767: missing space after comma $line = fgets($fp,1024); # severity: normalLine 779: missing space after comma $line = fgets($fp,1024); # severity: normalLine 802: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 803: string concatenation should be formatted without a space separating the operators (dot .) and a quote $skin_dir = $module_drupal_path . '/fckeditor/editor/skins'; # severity: normalLine 806: Control statements should have one space between the control keyword and opening parenthesis if( false !== $dh ) { # severity: normalLine 807: Control statements should have one space between the control keyword and opening parenthesis while(($file = readdir($dh)) !== false ) { # severity: normalLine 808: Control statements should have one space between the control keyword and opening parenthesis if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 808: use a space between the closing parenthesis and the open bracket if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 808: missing space after comma if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 811: Control statements should have one space between the control keyword and opening parenthesis if(is_dir($skin_dir.DIRECTORY_SEPARATOR.$file)) { # severity: normalLine 811: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if(is_dir($skin_dir.DIRECTORY_SEPARATOR.$file)) { # severity: normalLine 832: Use an indent of 2 spaces, with no tabs $module_drupal_path = drupal_get_path('module', 'fckeditor'); # severity: normalLine 833: string concatenation should be formatted without a space separating the operators (dot .) and a quote $lang_dir = $module_drupal_path . '/fckeditor/editor/lang'; # severity: normalLine 836: Control statements should have one space between the control keyword and opening parenthesis if( false !== $dh ) { # severity: normalLine 837: Control statements should have one space between the control keyword and opening parenthesis while(($file = readdir($dh)) !== false) { # severity: normalLine 838: Control statements should have one space between the control keyword and opening parenthesis if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 838: use a space between the closing parenthesis and the open bracket if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 838: missing space after comma if(in_array($file, array(".","..","CVS",".svn"))){ # severity: normalLine 841: Control statements should have one space between the control keyword and opening parenthesis if(is_file($lang_dir.DIRECTORY_SEPARATOR.$file) && preg_match("/^(.*?)\.js$/",$file,$matches)) { # severity: normalLine 841: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if(is_file($lang_dir.DIRECTORY_SEPARATOR.$file) && preg_match("/^(.*?)\.js$/",$file,$matches)) { # severity: normalLine 841: missing space after comma if(is_file($lang_dir.DIRECTORY_SEPARATOR.$file) && preg_match("/^(.*?)\.js$/",$file,$matches)) { # severity: normalLine 864: Use an indent of 2 spaces, with no tabs 'en-au' => 'English (Australia)', # severity: normalLine 865: Use an indent of 2 spaces, with no tabs 'en-ca' => 'English (Canadian)', # severity: normalLine 866: Use an indent of 2 spaces, with no tabs 'en-uk' => 'English (United Kingdom)', # severity: normalLine 893: Use an indent of 2 spaces, with no tabs 'pt-br' => 'Portuguese (Brazil)', # severity: normalLine 899: Use an indent of 2 spaces, with no tabs 'sr-latn' => 'Serbian (Latin)', # severity: normalLine 906: Use an indent of 2 spaces, with no tabs 'zh-cn' => 'Chinese Simplified', # severity: normalLine 932: use a space between the closing parenthesis and the open bracket if (!in_array($data->rid, array_keys((array) $edit->rids)) && !form_get_errors()){ # severity: normalLine 937: Arrays should be formatted with a space separating each element and assignment operator drupal_set_message(t('You must assign at least one role with the \'access fckeditor\' permission before creating a profile.', array('!access-control-url' => url('admin/user/access'),'!access1'=>t('access fckeditor'))), 'error'); # severity: normalLine 937: missing space after comma drupal_set_message(t('You must assign at least one role with the \'access fckeditor\' permission before creating a profile.', array('!access-control-url' => url('admin/user/access'),'!access1'=>t('access fckeditor'))), 'error'); # severity: normalLine 1033: missing space after comma '#description' => t('Choose what to do with the following values.
FCKeditor will force the !simple toolbar on the selected fields.
Useful for smaller textareas where we usually don\'t use very complicated HTML code, like in signatures.',array('!simple' => FCKEDITOR_FORCE_SIMPLE_TOOLBAR_NAME)), # severity: normalLine 1061: missing space after comma '#options' => array('t' => t('enabled'),'f' => t('disabled')), # severity: normalLine 1219: string concatenation should be formatted without a space separating the operators (dot .) and a quote '#description' => t('Enter path to CSS file (example: "css/editor.css") or a list of css files seperated by a comma (example: /themes/garland/style.css,http://example.com/style.css).
Macros: %h (host name: !host), %t (path to theme: !theme)
Be sure to select "define css" above.', array('!host' => base_path(), '!theme' => path_to_theme() . '/')) # severity: normalLine 1226: string concatenation should be formatted without a space separating the operators (dot .) and a quote '#description' => t('Style dropdown list loads styles defined in !fckstyles.xml. Copy this file inside your theme directory (!theme) and adjust it to your needs. If you modify the original file, changes will be applied to all themes, however it may get overwritten if you upgrade FCKeditor.', array('!fckstyles.xml' => drupal_get_path('module', 'fckeditor').'/fckeditor/fckstyles.xml', '!theme' => path_to_theme() . '/fckstyles.xml')) # severity: normalLine 1226: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms '#description' => t('Style dropdown list loads styles defined in !fckstyles.xml. Copy this file inside your theme directory (!theme) and adjust it to your needs. If you modify the original file, changes will be applied to all themes, however it may get overwritten if you upgrade FCKeditor.', array('!fckstyles.xml' => drupal_get_path('module', 'fckeditor').'/fckeditor/fckstyles.xml', '!theme' => path_to_theme() . '/fckstyles.xml')) # severity: normalLine 1299: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms if (!empty($value) && preg_match('/^'.str_replace('*','.*',addslashes($value)).'$/i', $search)) { # severity: normalLine 1299: missing space after comma if (!empty($value) && preg_match('/^'.str_replace('*','.*',addslashes($value)).'$/i', $search)) { # severity: normalLine 1317: string concatenation should be formatted without a space separating the operators (dot .) and a quote $fckeditor_main_file = drupal_get_path('module', 'fckeditor') . '/fckeditor/fckeditor.php'; # severity: normalLine 1321: do not use mixed case (camelCase), use lower case and _ return FCKeditor_IsCompatibleBrowser(); # severity: normalLine 1324: do not use mixed case (camelCase), use lower case and _ $fck = new FCKeditor("fake"); # severity: normalLine 1325: do not use mixed case (camelCase), use lower case and _ return $fck->IsCompatible(); # severity: normalLine 1332: use a space between the closing parenthesis and the open bracket function fckeditor_user_get_setting($user, $profile, $setting){ # severity: normalLine 1347: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $status = isset($user->{"fckeditor_".$setting}) ? $user->{"fckeditor_".$setting} : (isset($settings[$setting]) ? $settings[$setting] : $default[$setting]); # severity: normalLine 1358: use a space between the closing parenthesis and the open bracket if ($profile_name){ start_drupal.inc * severity: normalLine 15: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $_SERVER['PHP_SELF'] = dirname($_SERVER['PHP_SELF']) .(dirname($_SERVER['PHP_SELF']) == "/" ? "" : "/") ."index.php"; * severity: normalLine 19: the final ?> should be omitted from all code files ================================================== TinyMCE coder.module test: FAILS tinymce.module * severity: normalLine 34: string concatenation should be formatted without a space separating the operators (dot .) and a quote return t('

$Revision: 1.92 $ $Date: 2007/07/31 14:40:36 $

' . * severity: normalLine 49: string concatenation should be formatted without a space separating the operators (dot .) and a quote if (is_dir($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/plugins/imagemanager/')) { * severity: normalLine 52: string concatenation should be formatted without a space separating the operators (dot .) and a quote if (is_dir($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/plugins/filemanager/')) { * severity: normalLine 110: string concatenation should be formatted without a space separating the operators (dot .) and a quote $v = '"'. $v. '"'; * severity: normalLine 110: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $v = '"'. $v. '"'; * severity: normalLine 112: string concatenation should be formatted without a space separating the operators (dot .) and a quote $settings[] = $k. ' : '. $v; * severity: normalLine 112: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $settings[] = $k. ' : '. $v; * severity: normalLine 197: string concatenation should be formatted without a space separating the operators (dot .) and a quote if (is_dir($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/plugins/imagemanager/') && user_access('access tinymce imagemanager') ) { * severity: normalLine 199: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/plugins/imagemanager/jscripts/mcimagemanager.js'); * severity: normalLine 202: string concatenation should be formatted without a space separating the operators (dot .) and a quote if (is_dir($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/plugins/filemanager/') && user_access('access tinymce filemanager') ) { * severity: normalLine 204: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/plugins/filemanager/jscripts/mcfilemanager.js'); * severity: normalLine 208: string concatenation should be formatted without a space separating the operators (dot .) and a quote if (file_exists($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/tiny_mce_gzip.js')) { * severity: normalLine 209: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/tiny_mce_gzip.js'); * severity: normalLine 213: string concatenation should be formatted without a space separating the operators (dot .) and a quote elseif (file_exists($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/tiny_mce_gzip.php')) { * severity: normalLine 214: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/tiny_mce_gzip.php'); * severity: normalLine 218: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/tiny_mce.js'); * severity: normalLine 387: string concatenation should be formatted without a space separating the operators (dot .) and a quote include_once(drupal_get_path('module', 'tinymce'). '/plugin_reg.php'); * severity: normalLine 387: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms include_once(drupal_get_path('module', 'tinymce'). '/plugin_reg.php'); * severity: normalLine 392: string concatenation should be formatted without a space separating the operators (dot .) and a quote $file = drupal_get_path('module', 'tinymce'). '/tinymce/jscripts/tiny_mce/plugins/'. $name .'/editor_plugin_src.js'; * severity: normalLine 392: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $file = drupal_get_path('module', 'tinymce'). '/tinymce/jscripts/tiny_mce/plugins/'. $name .'/editor_plugin_src.js'; * severity: normalLine 493: string concatenation should be formatted without a space separating the operators (dot .) and a quote $themepath = path_to_theme() . '/'; * severity: normalLine 520: string concatenation should be formatted without a space separating the operators (dot .) and a quote if (is_dir($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/plugins/imagemanager/') && user_access('access tinymce imagemanager')) { * severity: normalLine 524: string concatenation should be formatted without a space separating the operators (dot .) and a quote if (is_dir($tinymce_mod_path . '/tinymce/jscripts/tiny_mce/plugins/filemanager/') && user_access('access tinymce filemanager')) { * severity: normalLine 547: string concatenation should be formatted without a space separating the operators (dot .) and a quote if ($settings['buttons'][$rname . '-' . $v]) { * severity: normalLine 620: string concatenation should be formatted without a space separating the operators (dot .) and a quote $css = $themepath . 'style.css'; * severity: normalLine 653: use a space between the closing parenthesis and the open bracket if (!in_array($data->rid, array_keys((array) $edit->rids)) && !form_get_errors()){ * severity: normalLine 801: Control statements should have one space between the control keyword and opening parenthesis foreach($metadata as $name => $meta) { * severity: normalLine 805: string concatenation should be formatted without a space separating the operators (dot .) and a quote $img_src = drupal_get_path('module', 'tinymce'). "/tinymce/jscripts/tiny_mce/plugins/$name/images/$name.gif"; * severity: normalLine 805: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $img_src = drupal_get_path('module', 'tinymce'). "/tinymce/jscripts/tiny_mce/plugins/$name/images/$name.gif"; * severity: normalLine 809: string concatenation should be formatted without a space separating the operators (dot .) and a quote $img_src = drupal_get_path('module', 'tinymce'). "/tinymce/jscripts/tiny_mce/plugins/$name/images/$button.gif"; * severity: normalLine 809: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $img_src = drupal_get_path('module', 'tinymce'). "/tinymce/jscripts/tiny_mce/plugins/$name/images/$button.gif"; * severity: normalLine 813: string concatenation should be formatted without a space separating the operators (dot .) and a quote $img_src = drupal_get_path('module', 'tinymce'). "/tinymce/jscripts/tiny_mce/themes/advanced/images/$button.gif"; * severity: normalLine 813: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $img_src = drupal_get_path('module', 'tinymce'). "/tinymce/jscripts/tiny_mce/themes/advanced/images/$button.gif"; * severity: normalLine 826: string concatenation should be formatted without a space separating the operators (dot .) and a quote $title = $b . ' – '. $title; * severity: normalLine 828: string concatenation should be formatted without a space separating the operators (dot .) and a quote $form_value = $edit->settings['buttons'][$name . '-' . $button]; * severity: normalLine 829: string concatenation should be formatted without a space separating the operators (dot .) and a quote $form['buttons'][$name . '-' . $button] = array('#type' => 'checkbox', '#title' => $title, '#default_value' => $form_value); * severity: normalLine 1051: string concatenation should be formatted without a space separating the operators (dot .) and a quote $rows[] = array(array('data' => $p->name, 'valign' => 'top'), array('data' => implode("
\n", $p->rids)), array('data' => l(t('edit'), 'admin/settings/tinymce/edit/'. urlencode($p->name)) . ' '. l(t('delete'), 'admin/settings/tinymce/delete/'. urlencode($p->name)), 'valign' => 'top')); * severity: normalLine 1145: use a space between the closing parenthesis and the open bracket if ($profile_name){ * severity: normalLine 1153: use a space between the closing parenthesis and the open bracket function tinymce_user_get_status($user, $profile){ ====================================================== Whizzywig coder.module test: Fails # Line 39: string concatenation should be formatted without a space separating the operators (dot .) and a quote $output = "

". t('Note') . ": "; # severity: normalLine 527: Control statements should have one space between the control keyword and opening parenthesis if(module_exists('content')) { # severity: normalLine 531: Control statements should have one space between the control keyword and opening parenthesis if($field['text_processing'] == 0) { ================================================================== widgEditor coder.module test: Fails widgeditor.module * severity: normalLine 62: string concatenation should be formatted without a space separating the operators (dot .) and a quote $query .= " textareas[$i] = \"" . preg_replace($pattern, $replacement, $ta) . "\";\n"; * severity: normalLine 65: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_js(drupal_get_path('module', 'widgeditor') . '/' . 'scripts/widgEditor.js'); * severity: normalLine 66: string concatenation should be formatted without a space separating the operators (dot .) and a quote drupal_add_css(drupal_get_path('module', 'widgeditor') . '/' . 'scripts/css/widgEditor.css'); * severity: normalLine 72: string concatenation should be formatted without a space separating the operators (dot .) and a quote ' . $query . ' * severity: normalLine 84: string concatenation should be formatted without a space separating the operators (dot .) and a quote ' . $query . ' ================================================================= WYMEditor coder.module test: Fails * Line 13: Control statements should have one space between the control keyword and opening parenthesis if(user_access(t('access WYMeditor'))) { * severity: normalLine 14: Use an indent of 2 spaces, with no tabs $body_found = FALSE; * severity: normalLine 15: Use an indent of 2 spaces, with no tabs foreach (element_children($form) as $e) { * severity: normalLine 17: Use an indent of 2 spaces, with no tabs if(isset($form[$e]['body']) && $form[$e]['body']['#type'] == 'textarea') { * severity: normalLine 17: Control statements should have one space between the control keyword and opening parenthesis if(isset($form[$e]['body']) && $form[$e]['body']['#type'] == 'textarea') { * severity: normalLine 22: Use an indent of 2 spaces, with no tabs if($body_found) { * severity: normalLine 22: Control statements should have one space between the control keyword and opening parenthesis if($body_found) { * severity: normalLine 28: Control statements should have one space between the control keyword and opening parenthesis if(module_exists('imce')) { * severity: normalLine 31: else statements should begin on a new line } else { * severity: normalLine 37: Use an indent of 2 spaces, with no tabs $wym_containers = _wymeditor_get_containers(); * severity: normalLine 38: Use an indent of 2 spaces, with no tabs $wym_classes = _wymeditor_get_classes(); * severity: normalLine 41: Use an indent of 2 spaces, with no tabs $module_path = drupal_get_path('module','wymeditor'); * severity: normalLine 41: missing space after comma $module_path = drupal_get_path('module','wymeditor'); * severity: normalLine 42: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_css($module_path.'/wymeditor/skins/editor-skin.css'); * severity: normalLine 43: Use an indent of 2 spaces, with no tabs drupal_add_js( $module_path.'/wymeditor.js'); * severity: normalLine 43: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js( $module_path.'/wymeditor.js'); * severity: normalLine 44: Use an indent of 2 spaces, with no tabs drupal_add_js( $module_path.'/wymeditor/browser.js'); * severity: normalLine 44: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js( $module_path.'/wymeditor/browser.js'); * severity: normalLine 45: Use an indent of 2 spaces, with no tabs drupal_add_js( $module_path.'/wymeditor/util.js'); * severity: normalLine 45: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js( $module_path.'/wymeditor/util.js'); * severity: normalLine 46: Use an indent of 2 spaces, with no tabs drupal_add_js( $module_path.'/wymeditor/config.js'); * severity: normalLine 46: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js( $module_path.'/wymeditor/config.js'); * severity: normalLine 47: Use an indent of 2 spaces, with no tabs drupal_add_js( $module_path.'/wymeditor/wym.js'); * severity: normalLine 47: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js( $module_path.'/wymeditor/wym.js'); * severity: normalLine 49: Use an indent of 2 spaces, with no tabs $module_path = base_path() . $module_path; * severity: normalLine 52: Use an indent of 2 spaces, with no tabs $form[$e]['body']['#attributes'] = array( * severity: normalLine 63: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms dialogs["base"]="'.$module_path.'/wymeditor/dialogs/"; * severity: normalLine 64: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms dialogs["image"]="'.$image_dialog.'"; * severity: normalLine 65: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms dialogs["link"]="'.$link_dialog.'"; * severity: normalLine 66: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms '.($settings['default_state'] == 'enabled' ? '' : 'wymToggleDisplay();').' * severity: normalLine 69: Use an indent of 2 spaces, with no tabs $editor = ' * severity: normalLine 126: Use an indent of 2 spaces, with no tabs foreach($wym_containers as $c) { * severity: normalLine 126: Control statements should have one space between the control keyword and opening parenthesis foreach($wym_containers as $c) { * severity: normalLine 127: Use an indent of 2 spaces, with no tabs $editor .= ''. $c['description'] .''; * severity: normalLine 130: Use an indent of 2 spaces, with no tabs $editor .= ' * severity: normalLine 138: Use an indent of 2 spaces, with no tabs foreach($wym_classes as $c) { * severity: normalLine 138: Control statements should have one space between the control keyword and opening parenthesis foreach($wym_classes as $c) { * severity: normalLine 139: Use an indent of 2 spaces, with no tabs $editor .= '' .$c['description'].''; * severity: normalLine 139: string concatenation should be formatted without a space separating the operators (dot .) and a quote $editor .= '' .$c['description'].''; * severity: normalLine 139: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $editor .= '' .$c['description'].''; * severity: normalLine 141: Use an indent of 2 spaces, with no tabs $editor .= ' * severity: normalLine 166: Use an indent of 2 spaces, with no tabs $editor .= ' * severity: normalLine 167: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms * severity: normalLine 172: Use an indent of 2 spaces, with no tabs $editor .= $settings['display_link'] == 'enabled' ? ''.t('Display/Hide WYMeditor').'' : ''; * severity: normalLine 172: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $editor .= $settings['display_link'] == 'enabled' ? ''.t('Display/Hide WYMeditor').'' : ''; * severity: normalLine 175: Use an indent of 2 spaces, with no tabs $form[$e]['body']['#suffix'] = $editor; * severity: normalLine 178: Use an indent of 2 spaces, with no tabs } * severity: normalLine 179: Use an indent of 2 spaces, with no tabs } * severity: normalLine 256: missing space after comma $output = drupal_get_form('wymeditor_delete_confirm','profile', $arg); * severity: normalLine 264: missing space after comma $output = drupal_get_form('wymeditor_profiles_form',$arg); * severity: normalLine 284: missing space after comma $output = drupal_get_form('wymeditor_delete_confirm','container', $arg); * severity: normalLine 292: missing space after comma $output = drupal_get_form('wymeditor_containers_form',$arg); * severity: normalLine 312: missing space after comma $output = drupal_get_form('wymeditor_delete_confirm','class', $arg); * severity: normalLine 338: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output = '

'.t('Here is the list of the profiles :').'

'; * severity: normalLine 339: Control statements should have one space between the control keyword and opening parenthesis if(isset($profiles)) { * severity: normalLine 342: Functions should be called with no spaces between the function name array ('data' => t('Operations'), 'colspan' => 2), * severity: normalLine 344: Control statements should have one space between the control keyword and opening parenthesis foreach($profiles as $p) { * severity: normalLine 345: Use an indent of 2 spaces, with no tabs $rows[] = array( * severity: normalLine 351: else statements should begin on a new line } else { * severity: normalLine 352: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output .= '

'.t('No profile defined yet, please add a new one.').'

'; * severity: normalLine 367: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output = '

'.t('Here is the list of the available classes :').'

'; * severity: normalLine 370: Use an indent of 2 spaces, with no tabs t('Description'), * severity: normalLine 371: Use an indent of 2 spaces, with no tabs t('Allowed containers'), * severity: normalLine 372: Use an indent of 2 spaces, with no tabs t('Incompatible classes'), * severity: normalLine 373: Use an indent of 2 spaces, with no tabs t('Compatible classes'), * severity: normalLine 374: Functions should be called with no spaces between the function name array ('data' => t('Operations'), 'colspan' => 2), * severity: normalLine 376: Control statements should have one space between the control keyword and opening parenthesis foreach($classes as $c) { * severity: normalLine 377: Use an indent of 2 spaces, with no tabs $rows[] = array( * severity: normalLine 378: missing space after comma $c['name'],$c['description'], $c['allowed'],$c['incompat'],$c['compat'], * severity: normalLine 394: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms $output = '

'.t('Here is the list of the available containers :').'

'; * severity: normalLine 398: Functions should be called with no spaces between the function name array ('data' => t('Operations'), 'colspan' => 2), * severity: normalLine 401: Control statements should have one space between the control keyword and opening parenthesis foreach($containers as $c) { * severity: normalLine 402: Use an indent of 2 spaces, with no tabs $rows[] = array( * severity: normalLine 419: Control statements should have one space between the control keyword and opening parenthesis if(!isset($id)) { * severity: normalLine 426: Control statements should have one space between the control keyword and opening parenthesis if(isset($data)) { * severity: normalLine 432: Control statements should have one space between the control keyword and opening parenthesis if(isset($data)) { * severity: normalLine 438: Control statements should have one space between the control keyword and opening parenthesis if(isset($data)) { * severity: normalLine 445: Control statements should have one space between the control keyword and opening parenthesis if(isset($name)) { * severity: normalLine 448: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms return confirm_form($form, t('Are you sure you want to delete the %type %name?', array('%type' => $type, '%name' => $name )), 'admin/settings/wymeditor/'.$type, '

'.t('This action cannot be undone.').'

', t('Delete'), t('Cancel')); * severity: normalLine 456: use a space between the closing parenthesis and the open bracket function wymeditor_delete_confirm_submit($form_id, $form){ * severity: normalLine 457: Control statements should have one space between the control keyword and opening parenthesis if(isset($form['id']) && is_numeric($form['id'])) { * severity: normalLine 471: Functions should be called with no spaces between the function name drupal_set_message(t('The %type has been successfully deleted.', array ('%type' => $form['type']))); * severity: normalLine 483: Control statements should have one space between the control keyword and opening parenthesis if(isset($pid)) { * severity: normalLine 556: Control statements should have one space between the control keyword and opening parenthesis if(isset($cid)) { * severity: normalLine 601: Control statements should have one space between the control keyword and opening parenthesis if(isset($cid)) { * severity: normalLine 669: use a space between the closing parenthesis and the open bracket function wymeditor_profiles_form_submit($form_id, $form){ * severity: normalLine 672: Control statements should have one space between the control keyword and opening parenthesis if(isset($form['pid'])) { * severity: normalLine 691: use a space between the closing parenthesis and the open bracket function wymeditor_containers_form_submit($form_id, $form){ * severity: normalLine 693: Control statements should have one space between the control keyword and opening parenthesis if(isset($form['cid'])) { * severity: normalLine 712: use a space between the closing parenthesis and the open bracket function wymeditor_classes_form_submit($form_id, $form){ * severity: normalLine 714: Control statements should have one space between the control keyword and opening parenthesis if(isset($form['cid'])) { * severity: normalLine 746: use a space between the closing parenthesis and the open bracket function _wymeditor_get_profiles($pid = null){ * severity: normalLine 747: Control statements should have one space between the control keyword and opening parenthesis if(isset($pid)) { * severity: normalLine 756: Use an indent of 2 spaces, with no tabs 'name' => $p->name, * severity: normalLine 757: Use an indent of 2 spaces, with no tabs 'settings' => $p->settings, * severity: normalLine 758: Use an indent of 2 spaces, with no tabs ); * severity: normalLine 768: use a space between the closing parenthesis and the open bracket function _wymeditor_get_containers($cid = null){ * severity: normalLine 769: Control statements should have one space between the control keyword and opening parenthesis if(isset($cid)) { * severity: normalLine 778: Use an indent of 2 spaces, with no tabs 'description' => $c->description, // description which appears in wymeditor * severity: normalLine 779: Use an indent of 2 spaces, with no tabs 'tagname' => $c->tagname, // actual tag name * severity: normalLine 781: Use an indent of 2 spaces, with no tabs ); * severity: normalLine 791: use a space between the closing parenthesis and the open bracket function _wymeditor_get_classes($cid = null){ * severity: normalLine 792: Control statements should have one space between the control keyword and opening parenthesis if(isset($cid)) { * severity: normalLine 801: Use an indent of 2 spaces, with no tabs 'name' => $c->name, * severity: normalLine 802: Use an indent of 2 spaces, with no tabs 'description' => $c->description, * severity: normalLine 803: Use an indent of 2 spaces, with no tabs 'allowed' => $c->allowed, // allowed containers * severity: normalLine 804: Use an indent of 2 spaces, with no tabs 'incompat' => $c->incompatible, // incompatible classes * severity: normalLine 804: missing space after comma 'incompat' => $c->incompatible, // incompatible classes * severity: normalLine 805: Use an indent of 2 spaces, with no tabs 'compat' => $c->compatible, // compatible classes * severity: normalLine 805: missing space after comma 'compat' => $c->compatible, // compatible classes * severity: normalLine 807: Use an indent of 2 spaces, with no tabs ); modules/wymeditor/wymeditor.install wymeditor.install * severity: normalLine 60: the final ?> should be omitted from all code files ================================================================= XStandard coder.module test: fails xstandard.module * severity: normalLine 715: global variables should start with a single underscore followed by the module and another underscore global $HTTP_USER_AGENT; * severity: normalLine 727: Use an indent of 2 spaces, with no tabs if($ver = (float)substr($ua, strpos($ua, 'MSIE') + 5, 3) >= 5) { * severity: normalLine 727: Control statements should have one space between the control keyword and opening parenthesis if($ver = (float)substr($ua, strpos($ua, 'MSIE') + 5, 3) >= 5) { * severity: normalLine 728: Use an indent of 2 spaces, with no tabs return(TRUE); * severity: normalLine 728: Control statements should have one space between the control keyword and opening parenthesis return(TRUE); * severity: normalLine 729: Use an indent of 2 spaces, with no tabs } * severity: normalLine 733: Use an indent of 2 spaces, with no tabs if ($ver = (int)substr($ua, strpos($ua, 'Gecko/') + 6, 8) >= 20041107) { * severity: normalLine 734: Use an indent of 2 spaces, with no tabs return(TRUE); * severity: normalLine 734: Control statements should have one space between the control keyword and opening parenthesis return(TRUE); * severity: normalLine 735: Use an indent of 2 spaces, with no tabs }; * severity: normalLine 739: Control statements should have one space between the control keyword and opening parenthesis if($ver = (float)substr($ua, strpos($ua, 'Opera/') + 6, 4) >=9) { * severity: normalLine 740: Control statements should have one space between the control keyword and opening parenthesis return(TRUE); * severity: normalLine 745: Control statements should have one space between the control keyword and opening parenthesis if($ver = (float)substr($ua, strpos($ua, 'Safari/') + 7, 5) >=312) { * severity: normalLine 746: Control statements should have one space between the control keyword and opening parenthesis return(TRUE); * severity: normalLine 749: Control statements should have one space between the control keyword and opening parenthesis return(FALSE); /* Not compatible */ ==================================================================== YUI Editor coder.module test: Fails yui_editor.module * severity: normalInclude the CVS keyword $Id$ in each file * severity: normalLine 33: Control statements should have one space between the control keyword and opening parenthesis if(preg_match($regexp, $path) or empty($yui_include)) { * severity: normalLine 97: missing space after comma $yui_source = variable_get('yui_source','http://yui.yahooapis.com/2.3.0'); * severity: normalLine 99: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms * severity: normalLine 100: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms * severity: normalLine 101: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms * severity: normalLine 102: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms * severity: normalLine 103: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms * severity: normalLine 104: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms * severity: normalLine 106: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js(drupal_get_path("module", "yui_editor")."/yui_editor.js"); * severity: normalLine 124: string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms drupal_add_js("render_editor('".$id."', ".variable_get('yui_editor_height', '300').", ".variable_get('yui_editor_width', '500').");", "inline", "footer");