Index: includes/coder_sql.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/coder/includes/Attic/coder_sql.inc,v
retrieving revision 1.1.4.11
diff -u -p -r1.1.4.11 coder_sql.inc
--- includes/coder_sql.inc 17 Sep 2008 13:12:06 -0000 1.1.4.11
+++ includes/coder_sql.inc 22 Sep 2008 12:08:52 -0000
@@ -55,6 +55,13 @@ function coder_sql_reviews() {
       '#value' => 'db_query\s*\(\s*[\'"](UPDATE|INSERT|DELETE)\s+',
       '#warning_callback' => '_coder_sql_db_query_in_install',
     ),
+    array(
+      '#type' => 'regex',
+      '#value' => '.*[\'"]SELECT\s+.*\s+FROM\s+\{node\}',
+      '#never' => 'db_rewrite_sql\s*\(',
+      '#source' => 'allphp',
+      '#warning_callback' => '_coder_sql_db_rewrite_sql',
+    )
   );
   $review = array(
     '#title' => t('Drupal SQL Standards'),
@@ -90,3 +97,13 @@ function _coder_sql_db_query_in_install(
     ),
   );
 }
+
+function _coder_sql_db_rewrite_sql() {
+  return array(
+    '#warning' => t('"SELECT FROM {node}" statements should probably be wrapped in !db_rewrite_sql',
+      array(
+        '!db_rewrite_sql' => theme('drupalapi', 'db_rewrite_sql'),
+      )
+    ),
+  );
+}
Index: tests/coder_sql.test
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/coder/tests/Attic/coder_sql.test,v
retrieving revision 1.1.2.1
diff -u -p -r1.1.2.1 coder_sql.test
--- tests/coder_sql.test 21 Sep 2008 15:03:30 -0000 1.1.2.1
+++ tests/coder_sql.test 22 Sep 2008 12:08:52 -0000
@@ -56,6 +56,9 @@ class CoderSQLTest extends CoderTestCase
       '  $sql = "INSERT INTO {foo} (%d)";' => CODER_OK,
       '  $sql = "INSERT INTO {foo} (1,%d)";' => CODER_OK,
       '  $sql = "INSERT INTO {foo} (1, %d)";' => CODER_OK,
+      // Check for missing db_rewrite_sql
+      '  $results = db_query("SELECT * FROM {node}");' => CODER_NOT_OK,
+      '  $results = db_query(db_rewrite_sql("SELECT * FROM {node}"));' => CODER_OK,
     );
     $this->runCoderTests($snippets);
   }