Index: modules/block/block.module =================================================================== RCS file: /cvs/drupal/drupal/modules/block/block.module,v retrieving revision 1.359 diff -u -p -r1.359 block.module --- modules/block/block.module 15 Aug 2009 06:50:29 -0000 1.359 +++ modules/block/block.module 20 Aug 2009 02:29:17 -0000 @@ -220,7 +220,7 @@ function block_block_save($delta = 0, $e */ function block_block_view($delta = 0, $edit = array()) { $block = db_query('SELECT body, format FROM {box} WHERE bid = :bid', array(':bid' => $delta))->fetchObject(); - $data['content'] = check_markup($block->body, $block->format, '', FALSE); + $data['content'] = check_markup($block->body, $block->format); return $data; } Index: modules/comment/comment.module =================================================================== RCS file: /cvs/drupal/drupal/modules/comment/comment.module,v retrieving revision 1.753 diff -u -p -r1.753 comment.module --- modules/comment/comment.module 17 Aug 2009 13:10:45 -0000 1.753 +++ modules/comment/comment.module 20 Aug 2009 02:30:23 -0000 @@ -816,7 +816,7 @@ function comment_build_content($comment, // Build comment body. $comment->content['comment_body'] = array( - '#markup' => check_markup($comment->comment, $comment->format, '', FALSE), + '#markup' => check_markup($comment->comment, $comment->format), ); $comment->content += field_attach_view('comment', $comment, $build_mode); @@ -1126,7 +1126,7 @@ function comment_node_update_index($node ':status' => COMMENT_PUBLISHED )); foreach ($comments as $comment) { - $text .= '

' . check_plain($comment->subject) . '

' . check_markup($comment->comment, $comment->format, '', FALSE); + $text .= '

' . check_plain($comment->subject) . '

' . check_markup($comment->comment, $comment->format); } } return $text; @@ -2018,7 +2018,6 @@ function comment_submit($comment) { // 1) Filter it into HTML // 2) Strip out all HTML tags // 3) Convert entities back to plain-text. - // Note: format is checked by check_markup(). $comment['subject'] = truncate_utf8(trim(decode_entities(strip_tags(check_markup($comment['comment'], $comment['comment_format'])))), 29, TRUE); // Edge cases where the comment body is populated only by HTML tags will // require a default subject. Index: modules/field/field.api.php =================================================================== RCS file: /cvs/drupal/drupal/modules/field/field.api.php,v retrieving revision 1.27 diff -u -p -r1.27 field.api.php --- modules/field/field.api.php 19 Aug 2009 13:31:12 -0000 1.27 +++ modules/field/field.api.php 20 Aug 2009 02:31:38 -0000 @@ -370,9 +370,9 @@ function hook_field_load($obj_type, $obj $format = $item['format']; if (filter_format_allowcache($format)) { $lang = isset($object->language) ? $object->language : $language->language; - $items[$id][$delta]['safe'] = isset($item['value']) ? check_markup($item['value'], $format, $lang, FALSE, FALSE) : ''; + $items[$id][$delta]['safe'] = isset($item['value']) ? check_markup($item['value'], $format, $lang, FALSE) : ''; if ($field['type'] == 'text_with_summary') { - $items[$id][$delta]['safe_summary'] = isset($item['summary']) ? check_markup($item['summary'], $format, $lang, FALSE, FALSE) : ''; + $items[$id][$delta]['safe_summary'] = isset($item['summary']) ? check_markup($item['summary'], $format, $lang, FALSE) : ''; } } } @@ -414,9 +414,9 @@ function hook_field_sanitize($obj_type, if (!empty($instance['settings']['text_processing'])) { $format = $item['format']; $lang = isset($object->language) ? $object->language : $language->language; - $items[$delta]['safe'] = isset($item['value']) ? check_markup($item['value'], $format, $lang, FALSE) : ''; + $items[$delta]['safe'] = isset($item['value']) ? check_markup($item['value'], $format, $lang) : ''; if ($field['type'] == 'text_with_summary') { - $items[$delta]['safe_summary'] = isset($item['summary']) ? check_markup($item['summary'], $format, $lang, FALSE) : ''; + $items[$delta]['safe_summary'] = isset($item['summary']) ? check_markup($item['summary'], $format, $lang) : ''; } } else { Index: modules/field/modules/text/text.module =================================================================== RCS file: /cvs/drupal/drupal/modules/field/modules/text/text.module,v retrieving revision 1.18 diff -u -p -r1.18 text.module --- modules/field/modules/text/text.module 19 Aug 2009 13:31:13 -0000 1.18 +++ modules/field/modules/text/text.module 20 Aug 2009 02:32:08 -0000 @@ -222,9 +222,9 @@ function text_field_load($obj_type, $obj $format = $item['format']; if (filter_format_allowcache($format)) { $lang = isset($object->language) ? $object->language : $language->language; - $items[$id][$delta]['safe'] = isset($item['value']) ? check_markup($item['value'], $format, $lang, FALSE, FALSE) : ''; + $items[$id][$delta]['safe'] = isset($item['value']) ? check_markup($item['value'], $format, $lang, FALSE) : ''; if ($field['type'] == 'text_with_summary') { - $items[$id][$delta]['safe_summary'] = isset($item['summary']) ? check_markup($item['summary'], $format, $lang, FALSE, FALSE) : ''; + $items[$id][$delta]['safe_summary'] = isset($item['summary']) ? check_markup($item['summary'], $format, $lang, FALSE) : ''; } } } @@ -253,9 +253,9 @@ function text_field_sanitize($obj_type, if (!empty($instance['settings']['text_processing'])) { $format = $item['format']; $lang = isset($object->language) ? $object->language : $language->language; - $items[$delta]['safe'] = isset($item['value']) ? check_markup($item['value'], $format, $lang, FALSE) : ''; + $items[$delta]['safe'] = isset($item['value']) ? check_markup($item['value'], $format, $lang) : ''; if ($field['type'] == 'text_with_summary') { - $items[$delta]['safe_summary'] = isset($item['summary']) ? check_markup($item['summary'], $format, $lang, FALSE) : ''; + $items[$delta]['safe_summary'] = isset($item['summary']) ? check_markup($item['summary'], $format, $lang) : ''; } } else { Index: modules/filter/filter.module =================================================================== RCS file: /cvs/drupal/drupal/modules/filter/filter.module,v retrieving revision 1.269 diff -u -p -r1.269 filter.module --- modules/filter/filter.module 15 Aug 2009 06:45:31 -0000 1.269 +++ modules/filter/filter.module 20 Aug 2009 02:27:37 -0000 @@ -421,20 +421,13 @@ function filter_list_format($format) { * Optional: the language code of the text to be filtered, e.g. 'en' for * English. This allows filters to be language aware so language specific * text replacement can be implemented. - * @param $check - * Whether to check the $format with filter_access() first. Defaults to TRUE. - * Note that this will check the permissions of the current user, so you - * should specify $check = FALSE when viewing other people's content. When - * showing content that is not (yet) stored in the database (eg. upon preview), - * set to TRUE so the user's permissions are checked. * @param $cache * Boolean whether to cache the filtered output in the {cache_filter} table. * The caller may set this to FALSE when the output is already cached * elsewhere to avoid duplicate cache lookups and storage. */ -function check_markup($text, $format = FILTER_FORMAT_DEFAULT, $langcode = '', $check = TRUE, $cache = TRUE) { - // When $check = TRUE, do an access check on $format. - if (isset($text) && (!$check || filter_access($format))) { +function check_markup($text, $format = FILTER_FORMAT_DEFAULT, $langcode = '', $cache = TRUE) { + if (isset($text)) { $format = filter_resolve_format($format); // Check for a cached version of this piece of text. Index: modules/node/node.api.php =================================================================== RCS file: /cvs/drupal/drupal/modules/node/node.api.php,v retrieving revision 1.34 diff -u -p -r1.34 node.api.php --- modules/node/node.api.php 17 Aug 2009 19:14:40 -0000 1.34 +++ modules/node/node.api.php 20 Aug 2009 02:32:43 -0000 @@ -425,7 +425,7 @@ function hook_node_update_index($node) { $text = ''; $comments = db_query('SELECT subject, comment, format FROM {comment} WHERE nid = :nid AND status = :status', array(':nid' => $node->nid, ':status' => COMMENT_PUBLISHED)); foreach ($comments as $comment) { - $text .= '

' . check_plain($comment->subject) . '

' . check_markup($comment->comment, $comment->format, '', FALSE); + $text .= '

' . check_plain($comment->subject) . '

' . check_markup($comment->comment, $comment->format); } return $text; }