Index: modules/filter/filter.test
===================================================================
RCS file: /cvs/drupal/drupal/modules/filter/filter.test,v
retrieving revision 1.12
diff -u -p -r1.12 filter.test
--- modules/filter/filter.test	28 Dec 2008 19:30:36 -0000	1.12
+++ modules/filter/filter.test	12 Jan 2009 23:10:24 -0000
@@ -197,24 +197,398 @@ class FilterTestCase extends DrupalWebTe
   }
 
   /**
-   * Test the line break filter
+   * Test filter settings, defaults, access restrictions and similar.
+   *
+   * TODO: This is for functions like filter_filter and check_markup, whose 
+   * functionality is not completely focused on filtering. Some ideas:
+   * restricting formats according to user permissions, proper cache 
+   * handling, defaults -- allowed tags/attributes/protocols.
+   *
+   * TODO: It is possible to add script, iframe etc. to allowed tags, but 
+   * this makes HTML filter completely ineffective.
+   *
+   * TODO: Class, id, name and xmlns should be added to disallowed attributes, 
+   * or better a whitelist approach should be used for that too.
    */
-  function testLineBreakFilter() {
-    $f = _filter_autop('<p><div>  </div></p>');
-    $this->assertEqual(substr_count($f, '<p>'), substr_count($f, '</p>'), t('Make sure line breaking produces matching paragraph tags.'));
+  function testFilter() {
+    // Does access restriction really work.
+
+    // HTML filter is not able to secure some tags, these should never be allowed.
+    $filtered = filter_filter('process', 0, 'no_such_format', '<script />');
+    $this->assertNoNormalized($filtered, 'script', t('HTML filter should always remove script tags.'));
+
+    $filtered = filter_filter('process', 0, 'no_such_format', '<iframe />');
+    $this->assertNoNormalized($filtered, 'iframe', t('HTML filter should always remove iframe tags.'));
+
+    $filtered = filter_filter('process', 0, 'no_such_format', '<object />');
+    $this->assertNoNormalized($filtered, 'object', t('HTML filter should always remove object tags.'));
+
+    $filtered = filter_filter('process', 0, 'no_such_format', '<style />');
+    $this->assertNoNormalized($filtered, 'style', t('HTML filter should always remove style tags.'));
+
+    // Some tags make CSRF attacks easier, let the user take the risk herself.
+    $filtered = filter_filter('process', 0, 'no_such_format', '<img />');
+    $this->assertNoNormalized($filtered, 'img', t('HTML filter should remove img tags on default.'));
+ 
+    $filtered = filter_filter('process', 0, 'no_such_format', '<input />');
+    $this->assertNoNormalized($filtered, 'img', t('HTML filter should remove input tags on default.'));
+
+    // Filtering content of some attributes is infeasible, these shouldn't be allowed too.
+    $filtered = filter_filter('process', 0, 'no_such_format', '<p style="display: none;" />');
+    $this->assertNoNormalized($filtered, 'style', t('HTML filter should remove style attribute on default.'));
+ 
+    $filtered = filter_filter('process', 0, 'no_such_format', '<p onerror="alert(0);" />');
+    $this->assertNoNormalized($filtered, 'onerror', t('HTML filter should remove on* attributes on default.'));
+ }
+
+  /**
+   * Test limiting allowed tags, XSS prevention and adding 'nofollow' to links.
+   * XSS tests assume that script is dissallowed on default and src is allowed on default, but on* and style are dissallowed.
+   *
+   * Script injection vectors mostly adopted from http://ha.ckers.org/xss.html.
+   *
+   * Relevant CVEs: 
+   *     CVE-2002-1806, ~CVE-2005-0682, ~CVE-2005-2106, CVE-2005-3973, 
+   *     CVE-2006-1226 (= rev. 1.112?), CVE-2008-0273, CVE-2008-3740.
+   *
+   */
+  function testHtmlFilter() {
+
+    // Tag stripping, different ways to work around removal of HTML tags.
+    $filtered = filter_xss('<script>alert(0)</script>');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping -- simple script without special characters.'));
+
+    $filtered = filter_xss('<script src="http://www.example.com" />');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping -- empty script with source.'));
+
+    $filtered = filter_xss('<ScRipt sRc=http://www.example.com/>');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- varying case.'));
+
+    $filtered = filter_xss("<script\nsrc\n=\nhttp://www.example.com/\n>");
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- multiline tag.'));
+
+    $filtered = filter_xss('<script/a src=http://www.example.com/a.js></script>');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- non whitespace character after tag name.'));
+
+    $filtered = filter_xss('<script/src=http://www.example.com/a.js></script>');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- no space between tag and attribute.'));
+
+    $filtered = filter_xss("<\0scr\0ipt>alert(0)</script>"); // Null between < and tag name works at least with IE6.
+    $this->assertNoNormalized($filtered, 'ipt', t('HTML tag stripping evasion -- breaking HTML with nulls.'));
+
+    $filtered = filter_xss("<scrscriptipt src=http://www.example.com/a.js>");
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- filter just removing "script".'));
+
+    $filtered = filter_xss('<<script>alert(0);//<</script>');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- double opening brackets.'));
+
+    $filtered = filter_xss('<script src=http://www.example.com/a.js?<b>');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- no closing tag.'));
+
+    $filtered = filter_xss('<script>>'); // DRUPAL-SA-2008-047 (rev. 1.219) This doesn't seem exploitable, but the filter should work consistently.
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- double closing tag.'));
+   
+    $filtered = filter_xss('<script src=//www.example.com/.a>');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- no scheme or ending slash.'));
+
+    $filtered = filter_xss('<script src=http://www.example.com/.a');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- no closing bracket.'));
+
+    $filtered = filter_xss('<script src=http://www.example.com/ <');
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- opening instead of closing bracket.'));
+
+    $filtered = filter_xss('<nosuchtag attribute="newScriptInjectionVector">');
+    $this->assertNoNormalized($filtered, 'nosuchtag', t('HTML tag stripping evasion -- unknown tag.'));
+
+    $filtered = filter_xss('<?xml:namespace ns="urn:schemas-microsoft-com:time">');
+    $this->assertTrue(stripos($filtered, '<?xml') === FALSE, t('HTML tag stripping evasion -- starting with a question sign (processing instructions).'));
+
+    $filtered = filter_xss('<t:set attributeName="innerHTML" to="&lt;script defer&gt;alert(0)&lt;/script&gt;">');
+    $this->assertNoNormalized($filtered, 't:set', t('HTML tag stripping evasion -- colon in the tag name (namespaces\' tricks).'));
+
+    $filtered = filter_xss('<img """><script>alert(0)</script>', array('img'));
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- a malformed image tag.'));
+
+    $filtered = filter_xss('<blockquote><script>alert(0)</script></blockquote>', array('blockquote'));
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- script in a blockqoute.'));
+
+    $filtered = filter_xss("<!--[if true]><script>alert(0)</script><![endif]-->");
+    $this->assertNoNormalized($filtered, 'script', t('HTML tag stripping evasion -- script within a comment.'));
+
+    // Dangerous attributes removal.
+    $filtered = filter_xss('<p onmouseover="http://www.example.com/">', array('p'));
+    $this->assertNoNormalized($filtered, 'onmouseover', t('HTML filter attributes removal -- events, no evasion.'));
+
+    $filtered = filter_xss('<li style="list-style-image: url(javascript:alert(0))">', array('li'));
+    $this->assertNoNormalized($filtered, 'style', t('HTML filter attributes removal -- style, no evasion.'));
+
+    $filtered = filter_xss('<img onerror   =alert(0)>', array('img')); 
+    $this->assertNoNormalized($filtered, 'onerror', t('HTML filter attributes removal evasion -- spaces before equals sign.'));
+
+    $filtered = filter_xss('<img onabort!#$%&()*~+-_.,:;?@[/|\]^`=alert(0)>', array('img'));
+    $this->assertNoNormalized($filtered, 'onabort', t('HTML filter attributes removal evasion -- non alphanumeric characters before equals sign.'));
+
+    $filtered = filter_xss('<img oNmediAError=alert(0)>', array('img')); 
+    $this->assertNoNormalized($filtered, 'onmediaerror', t('HTML filter attributes removal evasion -- varying case.'));
+
+    $filtered = filter_xss("<img o\0nfocus\0=alert(0)>", array('img')); // Works at least with IE6.
+    $this->assertNoNormalized($filtered, 'focus', t('HTML filter attributes removal evasion -- breaking with nulls.'));
+
+    // Only whitelisted scheme names in allowed attributes.
+    $filtered = filter_xss('<img src="javascript:alert(0)">', array('img'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing -- no evasion.'));
+
+    $filtered = filter_xss('<img src=javascript:alert(0)>', array('img'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing evasion -- no quotes.'));
+
+    $filtered = filter_xss('<img src="javascript:confirm(0)">', array('img')); // A bit like CVE-2006-0070.
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing evasion -- no alert ;)'));
+
+    $filtered = filter_xss('<img src=`javascript:alert(0)`>', array('img'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing evasion -- grave accents.'));
     
-    $f = _filter_autop('<div><p>  </p></div>');
-    $this->assertEqual(substr_count($f, '<p>'), substr_count($f, '</p>'), t('Make sure line breaking produces matching paragraph tags.'));
+    $filtered = filter_xss('<img dynsrc="javascript:alert(0)">', array('img'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing -- rare attribute.'));
+
+    $filtered = filter_xss('<table background="javascript:alert(0)">', array('table'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing -- another tag.'));
+
+    $filtered = filter_xss('<base href="javascript:alert(0);//">', array('base'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing -- one more attribute and tag.'));
+
+    $filtered = filter_xss('<img src="jaVaSCriPt:alert(0)">', array('img'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing evasion -- varying case.'));
+
+    $filtered = filter_xss('<img src=&#106;&#97;&#118;&#97;&#115;&#99;&#114;&#105;&#112;&#116;&#58;&#97;&#108;&#101;&#114;&#116;&#40;&#48;&#41;>', array('img'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing evasion -- UTF-8 decimal encoding.'));
+
+    $filtered = filter_xss('<img src=&#00000106&#0000097&#00000118&#0000097&#00000115&#0000099&#00000114&#00000105&#00000112&#00000116&#0000058&#0000097&#00000108&#00000101&#00000114&#00000116&#0000040&#0000048&#0000041>', array('img'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing evasion -- long UTF-8 encoding.'));
+
+    $filtered = filter_xss('<img src=&#x6A&#x61&#x76&#x61&#x73&#x63&#x72&#x69&#x70&#x74&#x3A&#x61&#x6C&#x65&#x72&#x74&#x28&#x30&#x29>', array('img'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing evasion -- UTF-8 hex encoding.'));
+
+    $filtered = filter_xss("<img src=\"jav\tascript:alert(0)\">", array('img'));
+    $this->assertNoNormalized($filtered, 'script', t('HTML scheme clearing evasion -- an embedded tab.'));
+
+    $filtered = filter_xss('<img src="jav&#x09;ascript:alert(0)">', array('img'));
+    $this->assertNoNormalized($filtered, 'script', t('HTML scheme clearing evasion -- an encoded, embedded tab.'));
+
+    $filtered = filter_xss('<img src="jav&#x000000A;ascript:alert(0)">', array('img'));
+    $this->assertNoNormalized($filtered, 'script', t('HTML scheme clearing evasion -- an encoded, embedded newline.'));
 
-    $f = _filter_autop('<blockquote><pre>aaa</pre></blockquote>');
-    $this->assertEqual(substr_count($f, '<p>'), substr_count($f, '</p>'), t('Make sure line breaking produces matching paragraph tags.'));
+    $filtered = filter_xss('<img src="jav&#x0D;ascript:alert(0)">', array('img')); // With &#xD; this test would fail, but the entity gets turned into &amp;#xD;, so it's OK.
+    $this->assertNoNormalized($filtered, 'script', t('HTML scheme clearing evasion -- an encoded, embedded carriage return.'));
+
+    $filtered = filter_xss("<img src=\"\n\n\nj\na\nva\ns\ncript:alert(0)\">", array('img'));
+    $this->assertNoNormalized($filtered, 'cript', t('HTML scheme clearing evasion -- broken into many lines.'));
+
+    $filtered = filter_xss("<img src=\"jav\0a\0\0cript:alert(0)\">", array('img'));
+    $this->assertNoNormalized($filtered, 'cript', t('HTML scheme clearing evasion -- embedded nulls.'));
+
+    $filtered = filter_xss('<img src=" &#14;  javascript:alert(0)">', array('img'));
+    $this->assertNoNormalized($filtered, 'javascript', t('HTML scheme clearing evasion -- spaces and metacharacters before scheme.'));
+
+    $filtered = filter_xss('<img src="vbscript:msgbox(0)">', array('img'));
+    $this->assertNoNormalized($filtered, 'vbscript', t('HTML scheme clearing evasion -- another scheme.'));
+
+    $filtered = filter_xss('<img src="nosuchscheme:notice(0)">', array('img'));
+    $this->assertNoNormalized($filtered, 'nosuchscheme', t('HTML scheme clearing evasion -- unknown scheme.'));
+
+    // Netscape 4.x javascript entities.
+    $filtered = filter_xss('<br size="&{alert(0)}">', array('br'));
+    $this->assertNoNormalized($filtered, 'alert', t('Netscape 4.x javascript entities.'));
+
+    // Invalid UTF-8, these only work as reflected XSS with Internet Explorer 6.
+    $filtered = filter_xss("<p arg=\"\xe0\">\" style=\"background-image: url(javascript:alert(0));\"\xe0<p>", array('p')); // DRUPAL-SA-2008-006
+    $this->assertNoNormalized($filtered, 'style', t('HTML filter -- invalid UTF-8.'));
+
+    $filtered = filter_xss("\xc0aaa");
+    $this->assertEqual($filtered, '', t('HTML filter -- overlong UTF-8 sequences.'));
   }
 
   /**
-   * Test the HTML filter
+   * Test the spam deterrent.
    */
-  function testHtmlFilter() {
+  function testNoFollowFilter() {
+    variable_set('filter_html_nofollow_f', TRUE);
+
+    // Test if the rel="nofollow" attribute is added, even if we try to prevent it.
+    $filtered = _filter_html('<a href="http://www.example.com/">text</a>', 'f');
+    $this->assertNormalized($filtered, 'rel="nofollow"', t('Spam deterrent -- no evasion.'));
+
+    $filtered = _filter_html('<A href="http://www.example.com/">text</a>', 'f');
+    $this->assertNormalized($filtered, 'rel="nofollow"', t('Spam deterrent evasion -- capital A.'));
+
+    $filtered = _filter_html("<a/href=\"http://www.example.com/\">text</a>", 'f');
+    $this->assertNormalized($filtered, 'rel="nofollow"', t('Spam deterrent evasion -- non whitespace character after tag name.'));
 
+    $filtered = _filter_html("<\0a\0 href=\"http://www.example.com/\">text</a>", 'f');
+    $this->assertNormalized($filtered, 'rel="nofollow"', t('Spam deterrent evasion -- some nulls.'));
+
+    $filtered = _filter_html('<!--[if true]><a href="http://www.example.com/">text</a><![endif]-->', 'f');
+    $this->assertNormalized($filtered, 'rel="nofollow"', t('Spam deterrent evasion -- link within a comment.'));
+  }
+
+  /**
+   * Test the loose, admin HTML filter.
+   */
+  function testAdminHtmlFilter() {
+
+    $filtered = filter_xss_admin('<object />'); // DRUPAL-SA-2008-044
+    $this->assertNoNormalized($filtered, 'object', t('Admin HTML filter -- should not allow object tag.'));
+
+    $filtered = filter_xss_admin('<script />');
+    $this->assertNoNormalized($filtered, 'script', t('Admin HTML filter -- should not allow script tag.'));
+
+    $filtered = filter_xss_admin('<style /><iframe /><frame /><frameset /><meta /><link /><embed /><applet /><param /><layer />');
+    $this->assertEqual($filtered, '', t('Admin HTML filter -- should not allow some tags.'));
+  }
+
+  /**
+   * Test the HTML escaping filter. Here we test only whether check_plain does what it should.
+   */
+  function testNoHtmlFilter() {
+
+    // Test that characters that have special meaning in XML are changed into entities.
+    $filtered = check_plain('<>&"');
+    $this->assertEqual($filtered, '&lt;&gt;&amp;&quot;', t('No HTML filter basic test.'));
+
+    // A single quote can also be used for evil things in some contexts.
+    $filtered = check_plain('\'');
+    $this->assertEqual($filtered, '&#039;', t('No HTML filter -- single quote.'));
+
+    // Test that the filter is not fooled by different evasion techniques.
+    $filtered = check_plain("\xc2\"");
+    $this->assertEqual($filtered, '', t('No HTML filter -- invalid UTF-8.'));
+  }
+
+  /**
+   * Test the line breaking filter.
+   */
+  function testLineBreakingFilter() {
+
+    // Single line breaks should be changed to <br /> tags, while paragraphs 
+    // separated with double line breaks should be enclosed with <p></p> tags.
+    $filtered = _filter_autop("aaa\nbbb\n\nccc");
+    $this->assertEqual(str_replace("\n", '', $filtered), "<p>aaa<br />bbb</p><p>ccc</p>", t('Line breaking basic case.'));
+
+    // Text within some contexts should not be processed.
+    $filtered = _filter_autop("<script>aaa\nbbb\n\nccc</script>");
+    $this->assertEqual($filtered, "<script>aaa\nbbb\n\nccc</script>", t('Line breaking -- do not break scripts.'));
+
+    // Some special cases that used not to work (issue #212236).
+    $filtered = _filter_autop('<p><div>  </div></p>');
+    $this->assertEqual(substr_count($filtered, '<p>'), substr_count($filtered, '</p>'), t('Make sure line breaking produces matching paragraph tags.'));
+    
+    $filtered = _filter_autop('<div><p>  </p></div>');
+    $this->assertEqual(substr_count($filtered, '<p>'), substr_count($filtered, '</p>'), t('Make sure line breaking produces matching paragraph tags.'));
+
+    $filtered = _filter_autop('<blockquote><pre>aaa</pre></blockquote>');
+    $this->assertEqual(substr_count($filtered, '<p>'), substr_count($filtered, '</p>'), t('Make sure line breaking produces matching paragraph tags.'));
+  }
+
+  /**
+   * Test the URL filter.
+   */
+  function testUrlFilter() {
+    variable_set('filter_url_length_f', 496);
+
+    // Converting URLs.
+    $filtered = _filter_url('http://www.example.com/', 'f');
+    $this->assertEqual($filtered, '<a href="http://www.example.com/" title="http://www.example.com/">http://www.example.com/</a>', t('Converting URLs.'));
+
+    $filtered = _filter_url('http://www.example.com/?a=1&b=2', 'f');
+    $this->assertEqual($filtered, '<a href="http://www.example.com/?a=1&amp;b=2" title="http://www.example.com/?a=1&amp;b=2">http://www.example.com/?a=1&amp;b=2</a>', t('Converting URLs -- ampersands.'));
+
+    $filtered = _filter_url('ftp://user:pass@ftp.example.com/dir1/dir2', 'f');
+    $this->assertEqual($filtered, '<a href="ftp://user:pass@ftp.example.com/dir1/dir2" title="ftp://user:pass@ftp.example.com/dir1/dir2">ftp://user:pass@ftp.example.com/dir1/dir2</a>', t('Converting URLs -- FTP scheme.'));
+
+    // Converting domain names.
+    $filtered = _filter_url('www.example.com', 'f');
+    $this->assertEqual($filtered, '<a href="http://www.example.com" title="www.example.com">www.example.com</a>', t('Converting domain names.'));
+
+    $filtered = _filter_url('<li>www.example.com</li>', 'f');
+    $this->assertEqual($filtered, '<li><a href="http://www.example.com" title="www.example.com">www.example.com</a></li>', t('Converting domain names -- domain in a list.'));
+
+    $filtered = _filter_url('(www.example.com/dir?a=1&b=2#a)', 'f');
+    $this->assertEqual($filtered, '(<a href="http://www.example.com/dir?a=1&amp;b=2#a" title="www.example.com/dir?a=1&amp;b=2#a">www.example.com/dir?a=1&amp;b=2#a</a>)', t('Converting domain names --  domain with in parentheses.'));
+
+    // Converting e-mail addresses.
+    $filtered = _filter_url('johndoe@example.com', 'f');
+    $this->assertEqual($filtered, '<a href="mailto:johndoe@example.com">johndoe@example.com</a>', t('Converting e-mail addresses.'));
+
+    $filtered = _filter_url('aaa@sub.tv', 'f');
+    $this->assertEqual($filtered, '<a href="mailto:aaa@sub.tv">aaa@sub.tv</a>', t('Converting e-mail addresses -- a short e-mail from Tuvalu.'));
+
+    // URL trimming.
+    variable_set('filter_url_length_f', 28);
+
+    $filtered = _filter_url('http://www.example.com/d/ff.ext?a=1&b=2#a1', 'f');
+    $this->assertNormalized($filtered, 'http://www.example.com/d/ff....', t('URL trimming.'));
+
+    // Not breaking existing links.
+    $filtered = _filter_url('<a href="http://www.example.com">www.example.com</a>', 'f');
+    $this->assertEqual($filtered, '<a href="http://www.example.com">www.example.com</a>', t('Converting URLs -- do not break existing links.'));
+
+    $filtered = _filter_url('<a href="foo">http://www.example.com</a>', 'f');
+    $this->assertEqual($filtered, '<a href="foo">http://www.example.com</a>', t('Converting URLs -- do not break existing, relative links.'));
+
+    // Addresses within some tags such as code or script should not be converted.
+    $filtered = _filter_url('<code>http://www.example.com</code>', 'f');
+    $this->assertEqual($filtered, '<code>http://www.example.com</code>', t('Converting URLs -- skip code contents.'));
+
+    $filtered = _filter_url('<code><em>http://www.example.com</em></code>', 'f');
+    $this->assertEqual($filtered, '<code><em>http://www.example.com</em></code>', t('Converting URLs -- really skip code contents.'));
+
+    $filtered = _filter_url('<script>http://www.example.com</script>', 'f');
+    $this->assertEqual($filtered, '<script>http://www.example.com</script>', t('Converting URLs -- do not process scripts.'));
+
+    // Addresses in attributes should not be converted.
+    $filtered = _filter_url('<p xmlns="http://www.example.com" />', 'f');
+    $this->assertEqual($filtered, '<p xmlns="http://www.example.com" />', t('Converting URLs -- do not convert addresses in attributes.'));
+
+    $filtered = _filter_url('<a title="Go to www.example.com" href="http://www.example.com">text</a>', 'f');
+    $this->assertEqual($filtered, '<a title="Go to www.example.com" href="http://www.example.com">text</a>', t('Converting URLs -- do not break existing links with custom title attribute.'));
+
+    // Dot at the end of an address (issue #161217).
+    // Dot at the end of a domain name can mean that it's a fully qualified name. It can also be used at the end of a filename or a query string (and is not encoded; see: http://en.wikipedia.org./wiki/FQDN and http://en.wikipedia.org/wiki/Query_string).
+    // However, such usage is rare compared to simply using a link at the and of a sentence, so we shouldn't include the dot in the link. Does everybody expect that??
+    $filtered = _filter_url('www.example.com.', 'f');
+    $this->assertEqual($filtered, '<a href="http://www.example.com" title="www.example.com">www.example.com</a>.', t('Converting URLs -- do not recognize a dot at the end of a domain name (FQDNs).'));
+
+    $filtered = _filter_url('http://www.example.com.', 'f');
+    $this->assertEqual($filtered, '<a href="http://www.example.com" title="http://www.example.com">http://www.example.com</a>.', t('Converting URLs -- do not recognize a dot at the end of an URL (FQDNs).'));
+
+    $filtered = _filter_url('www.example.com/index.php?a=.', 'f');
+    $this->assertEqual($filtered, '<a href="http://www.example.com/index.php?a=" title="www.example.com/index.php?a=">www.example.com/index.php?a=</a>.', t('Converting URLs -- do forget about a dot at the end of a query string.'));
+
+
+  }
+
+  /**
+   * Test the HTML corrector.
+   *
+   * TODO: This test could really use some validity checking function.
+   */
+  function testHtmlCorrector() {
+
+    // Tag closing.
+    $filtered = _filter_htmlcorrector('<p>text');
+    $this->assertEqual($filtered, '<p>text</p>', t('HTML corrector -- tag closing at the end of input.'));
+    
+    $filtered = _filter_htmlcorrector('<p>text<p><p>text');
+    $this->assertEqual($filtered, '<p>text</p><p></p><p>text</p>', t('HTML corrector -- tag closing.'));
+
+    $filtered = _filter_htmlcorrector("<ul><li>e1<li>e2");
+    $this->assertEqual($filtered, "<ul><li>e1</li><li>e2</li></ul>", t('HTML corrector -- unclosed list tags.'));
+
+    $filtered = _filter_htmlcorrector('<div id="d">content');
+    $this->assertEqual($filtered, '<div id="d">content</div>', t('HTML corrector -- unclosed tag with attribute.'));
+
+    // XHTML slash for empty elements.
+    $filtered = _filter_htmlcorrector('<hr><br>');
+    $this->assertEqual($filtered, '<hr /><br />', t('HTML corrector -- XHTML closing slash.'));
   }
 
   function createFormat($filter) {
@@ -233,4 +607,43 @@ class FilterTestCase extends DrupalWebTe
       $this->drupalPost('admin/settings/filters/delete/' . $format->format, array(), t('Delete'));
     }
   }
+ 
+  /**
+   * Asserts that a text transformed to lowercase with HTML entities decoded does contains a given string.
+   * Otherwise fails the test with a given message, similar to all the SimpleTest assert* functions.
+   * Note that this does not remove nulls, newlines and other that could be used to obscure a tag or an attribute name.
+   * @param $haystack
+   *   Text to look in.
+   * @param $needle
+   *   Lowercase, plain text to look for.
+   * @param $message
+   *   Message to display if failed.
+   * @param $group
+   *   The group this message belongs to, defaults to 'Other'.
+   * @return
+   *   TRUE on pass, FALSE on fail.
+   */
+  function assertNormalized($haystack, $needle, $message = '', $group = 'Other') {
+    return $this->assertTrue(strpos(strtolower(decode_entities($haystack)), $needle) !== FALSE, $message, $group);
+  }
+
+  /**
+   * Asserts that a text transformed to lowercase with HTML entities decoded does not contain a given string.
+   * Otherwise fails the test with a given message, similar to all the SimpleTest assert* functions.
+   * Note that this does not remove nulls, newlines and other that could be used to obscure a tag or an attribute name.
+   * @param $haystack
+   *   Text to look in.
+   * @param $needle
+   *   Lowercase, plain text to look for.
+   * @param $message
+   *   Message to display if failed.
+   * @param $group
+   *   The group this message belongs to, defaults to 'Other'.
+   * @return
+   *   TRUE on pass, FALSE on fail.
+   */
+  function assertNoNormalized($haystack, $needle, $message = '', $group = 'Other') {
+    return $this->assertTrue(strpos(strtolower(decode_entities($haystack)), $needle) === FALSE, $message, $group);
+  }
+
 }