=== modified file 'misc/form.js' --- misc/form.js 2008-12-06 09:01:58 +0000 +++ misc/form.js 2009-01-25 13:53:11 +0000 @@ -10,3 +10,20 @@ Drupal.behaviors.multiselectSelector = { }); } }; + + +Drupal.behaviors.filterGuildelines = { + attach: function (context) { + // Automatically displays the guidelines of the selected input format. + $('.filter-guidelines:not(.filterGuidelines-processed)', context) + .addClass('filterGuidelines-processed') + .find('label').hide() + .parents('.filter-wrapper').find('select.filter-list') + .bind('change', function() { + $(this).parents('.filter-wrapper') + .find('.filter-guidelines-item').hide() + .siblings('#filter-guidelines-' + this.value).show(); + }) + .change(); + } +}; === modified file 'modules/filter/filter.module' --- modules/filter/filter.module 2009-01-21 17:00:08 +0000 +++ modules/filter/filter.module 2009-01-25 13:57:24 +0000 @@ -60,6 +60,9 @@ function filter_theme() { 'filter_tips_more_info' => array( 'arguments' => array(), ), + 'filter_guidelines' => array( + 'arguments' => array('format' => NULL), + ), ); } @@ -481,58 +484,45 @@ function check_markup($text, $format = F function filter_form($value = FILTER_FORMAT_DEFAULT, $weight = NULL, $parents = array('format')) { $value = filter_resolve_format($value); $formats = filter_formats(); - - $extra = theme('filter_tips_more_info'); - + + $form = array( + '#type' => 'fieldset', + '#weight' => $weight, + '#attributes' => array('class' => 'filter-wrapper'), + ); + + $element_id = form_clean_id('edit-' . implode('-', $parents)); + if (count($formats) > 1) { - $form = array( - '#type' => 'fieldset', - '#title' => t('Text format'), - '#collapsible' => TRUE, - '#collapsed' => TRUE, - '#weight' => $weight, - '#element_validate' => array('filter_form_validate'), - ); - // Multiple formats available: display radio buttons with tips. foreach ($formats as $format) { - // Generate the parents as the autogenerator does, so we will have a - // unique id for each radio button. - $parents_for_id = array_merge($parents, array($format->format)); - $form[$format->format] = array( - '#type' => 'radio', - '#title' => $format->name, - '#default_value' => $value, - '#return_value' => $format->format, - '#parents' => $parents, - '#description' => theme('filter_tips', _filter_tips($format->format, FALSE)), - '#id' => form_clean_id('edit-' . implode('-', $parents_for_id)), - ); + $options[$format->format] = $format->name; + $guidelines[$format->format] = array('#markup' => theme('filter_guidelines', $format)); } + drupal_add_js('misc/form.js'); + $form['format'] = array( + '#type' => 'select', + '#title' => t('Formatting'), + '#options' => $options, + '#default_value' => $value, + '#parents' => $parents, + '#id' => $element_id, + '#attributes' => array('class' => 'filter-list'), + ); } else { - // Only one format available: use a hidden form item and only show tips. + // Only one format available: use a form value and only show label. $format = array_shift($formats); + $guidelines = array('#markup' => theme('filter_guidelines', $format)); $form[$format->format] = array('#type' => 'value', '#value' => $format->format, '#parents' => $parents); - $tips = _filter_tips(variable_get('filter_default_format', 1), FALSE); - $form['format']['guidelines'] = array( - '#title' => t('Formatting guidelines'), - '#markup' => theme('filter_tips', $tips, FALSE), + $form['format_label'] = array( + '#markup' => 'Formatting: ' . "\n", ); } - $form[] = array('#markup' => $extra); + $form['format_guidelines'] = array_merge($guidelines, array('#prefix' => '
', '#suffix' => '
')); + $form['format_help'] = array('#markup' => '
' . theme('filter_tips_more_info') . '
'); return $form; } -function filter_form_validate($form) { - foreach (element_children($form) as $key) { - if ($form[$key]['#value'] == $form[$key]['#return_value']) { - return; - } - } - form_error($form, t('An illegal choice has been detected. Please contact the site administrator.')); - watchdog('form', 'Illegal choice %choice in %name element.', array('%choice' => $form[$key]['#value'], '%name' => empty($form['#title']) ? $form['#parents'][0] : $form['#title']), WATCHDOG_ERROR); -} - /** * Returns TRUE if the user is allowed to access this format. */ @@ -590,6 +580,15 @@ function theme_filter_tips_more_info() { } /** + * Format guidelines for an input format. + * + * @ingroup themeable + */ +function theme_filter_guidelines($format) { + return '
' . theme('filter_tips', _filter_tips($format->format, FALSE)) . '
'; +} + +/** * @name Standard filters * @{ * Filters implemented by the filter.module. === modified file 'modules/filter/filter.test' --- modules/filter/filter.test 2009-01-21 17:00:08 +0000 +++ modules/filter/filter.test 2009-01-25 13:53:11 +0000 @@ -101,7 +101,7 @@ class FilterAdminTestCase extends Drupal $this->drupalLogin($web_user); $this->drupalGet('node/add/page'); - $this->assertFieldByName('body_format', $full, t('Full HTML filter accessible.')); + $this->assertRaw('', t('Full HTML filter accessible.')); // Use filtered HTML and see if it removes tags that arn't allowed. $body = $this->randomName(); === modified file 'modules/node/node.css' --- modules/node/node.css 2008-12-06 09:01:58 +0000 +++ modules/node/node.css 2009-01-25 13:53:11 +0000 @@ -42,3 +42,6 @@ td.revision-current { .terms-inline { display: inline; } +.filter-label { + font-weight: bold; +}