Index: install.php
===================================================================
RCS file: /cvs/drupal/drupal/install.php,v
retrieving revision 1.176
diff --context -r1.176 install.php
*** install.php	2 Jun 2009 06:58:15 -0000	1.176
--- install.php	4 Jun 2009 02:37:02 -0000
***************
*** 267,273 ****
        '#size' => 45,
      );
  
!     // Database username
      $form['basic_options']['password'] = array(
        '#type' => 'password',
        '#title' => st('Database password'),
--- 267,273 ----
        '#size' => 45,
      );
  
!     // Database password
      $form['basic_options']['password'] = array(
        '#type' => 'password',
        '#title' => st('Database password'),
Index: includes/install.inc
===================================================================
RCS file: /cvs/drupal/drupal/includes/install.inc,v
retrieving revision 1.91
diff --context -r1.91 install.inc
*** includes/install.inc	24 May 2009 17:39:30 -0000	1.91
--- includes/install.inc	4 Jun 2009 02:37:04 -0000
***************
*** 287,293 ****
        return FALSE;
      }
      foreach ($this->tests as $test) {
!       $return = $this->runTestQuery($test['query'], $test['success'], $test['message'], !empty($tests['fatal']));
        if ($return === FALSE) {
          return FALSE;
        }
--- 287,293 ----
        return FALSE;
      }
      foreach ($this->tests as $test) {
!       $return = $this->runTestQuery($test['query'], $test['success'], $test['message'], !empty($test['fatal']));
        if ($return === FALSE) {
          return FALSE;
        }
***************
*** 303,313 ****
     */
    protected function testConnect() {
      try {
        db_set_active();
        $this->success[] = 'CONNECT';
      }
      catch (Exception $e) {
!       drupal_set_message(st('Failed to connect to your %name database server. %name reports the following message: %error.<ul><li>Are you sure you have the correct username and password?</li><li>Are you sure that you have typed the correct database hostname?</li><li>Are you sure that the database server is running?</li></ul>For more help, see the <a href="http://drupal.org/node/258">Installation and upgrading handbook</a>. If you are unsure what these terms mean you should probably contact your hosting provider.', array('%error' => $e->getMessage(), 'name' => $this->name())), 'error');
        return FALSE;
      }
    }
--- 303,316 ----
     */
    protected function testConnect() {
      try {
+       //this doesn't actually test the connection so....
        db_set_active();
+       //actually do a check
+       Database::getConnection();
        $this->success[] = 'CONNECT';
      }
      catch (Exception $e) {
!       drupal_set_message(st('Failed to connect to your %name database server. %name reports the following message: <b>%error.</b><ul><li>Are you sure that you have typed the correct database hostname?</li><li>Are you sure that the database server is running?</li><li>Are you sure you have the correct database name?</li><li>Are you sure you have the correct username and password?</li></ul>For more help, see the <a href="http://drupal.org/node/258">Installation and upgrading handbook</a>. If you are unsure what these terms mean you should probably contact your hosting provider.', array('%error' => $e->getMessage(), '%name' => $this->name())), 'error');
        return FALSE;
      }
    }