Index: modules/archive.module =================================================================== RCS file: /cvs/drupal/drupal/modules/archive.module,v retrieving revision 1.80 diff -u -F^f -r1.80 archive.module --- modules/archive.module 24 Apr 2005 16:34:32 -0000 1.80 +++ modules/archive.module 1 Jul 2005 17:06:28 -0000 @@ -246,7 +246,7 @@ function archive_page($year = 0, $month $result = db_query_range($sql, $date, $date_end, 0, 20); while ($nid = db_fetch_object($result)) { - $output .= node_view(node_load(array('nid' => $nid->nid)), 1); + $output .= node_view(node_load($nid->nid), 1); } } return $output; Index: modules/blogapi.module =================================================================== RCS file: /cvs/drupal/drupal/modules/blogapi.module,v retrieving revision 1.44 diff -u -F^f -r1.44 blogapi.module --- modules/blogapi.module 6 Jun 2005 18:59:37 -0000 1.44 +++ modules/blogapi.module 1 Jul 2005 17:06:29 -0000 @@ -177,7 +177,7 @@ function blogapi_edit_post($req_params) return blogapi_error($user); } - $node = node_load(array('nid' => $params[0])); + $node = node_load($params[0]); if (!$node) { return blogapi_error(message_na()); } @@ -234,7 +234,7 @@ function blogapi_get_post($req_params) { return blogapi_error($user); } - $node = node_load(array('nid' => $params[0])); + $node = node_load($params[0]); $blog = _blogapi_get_post($node, true); @@ -433,7 +433,7 @@ function blogapi_publish_post($req_param $params = blogapi_convert($req_params); $user = blogapi_validate_user($params[1], $params[2]); - $node = node_load(array('nid' => $params[0])); + $node = node_load($params[0]); if (!$node) { return blogapi_error(t('Invalid post.')); } Index: modules/blog.module =================================================================== RCS file: /cvs/drupal/drupal/modules/blog.module,v retrieving revision 1.217 diff -u -F^f -r1.217 blog.module --- modules/blog.module 31 May 2005 21:14:26 -0000 1.217 +++ modules/blog.module 1 Jul 2005 17:06:29 -0000 @@ -143,7 +143,7 @@ function blog_page_user($uid) { $result = pager_query(db_rewrite_sql("SELECT n.nid, n.sticky, n.created FROM {node} n WHERE type = 'blog' AND n.uid = %d AND n.status = 1 ORDER BY n.sticky DESC, n.created DESC"), variable_get('default_nodes_main', 10), 0, NULL, $account->uid); while ($node = db_fetch_object($result)) { - $output .= node_view(node_load(array('nid' => $node->nid)), 1); + $output .= node_view(node_load($node->nid), 1); } $output .= theme('pager', NULL, variable_get('default_nodes_main', 10)); $output .= theme('xml_icon', url("blog/$account->uid/feed")); @@ -170,7 +170,7 @@ function blog_page_last() { $result = pager_query(db_rewrite_sql("SELECT n.nid, n.created FROM {node} n WHERE n.type = 'blog' AND n.status = 1 ORDER BY n.created DESC"), variable_get('default_nodes_main', 10)); while ($node = db_fetch_object($result)) { - $output .= node_view(node_load(array('nid' => $node->nid)), 1); + $output .= node_view(node_load($node->nid), 1); } $output .= theme('pager', NULL, variable_get('default_nodes_main', 10)); $output .= theme('xml_icon', url('blog/feed')); @@ -195,7 +195,7 @@ function blog_form(&$node) { ** database and quote it in the blog: */ - if ($nid && $blog = node_load(array('nid' => $nid))) { + if ($nid && $blog = node_load($nid)) { $node->body = ''. $blog->body .' ['. l($blog->name, "node/$nid") .']'; } Index: modules/comment.module =================================================================== RCS file: /cvs/drupal/drupal/modules/comment.module,v retrieving revision 1.356 diff -u -F^f -r1.356 comment.module --- modules/comment.module 29 Jun 2005 19:53:14 -0000 1.356 +++ modules/comment.module 1 Jul 2005 17:06:30 -0000 @@ -136,7 +136,7 @@ function comment_menu($may_cache) { } else { if (arg(0) == 'comment' && arg(1) == 'reply' && is_numeric(arg(2))) { - $node = node_load(array('nid' => arg(2))); + $node = node_load(arg(2)); if ($node->nid) { $items[] = array('path' => 'comment/reply', 'title' => t('reply to comment'), 'callback' => 'comment_reply', 'access' => node_access('view', $node), 'type' => MENU_CALLBACK); @@ -376,7 +377,7 @@ function comment_edit($cid) { function comment_reply($nid, $pid = NULL) { // set the breadcrumb trail - $node = node_load(array('nid' => $nid)); + $node = node_load($nid); menu_set_location(array(array('path' => "node/$nid", 'title' => $node->title), array('path' => "comment/reply/$nid"))); $output = ''; @@ -514,7 +515,7 @@ function comment_preview($edit) { $output .= theme('comment_view', $comment); } else { - $output .= node_view(node_load(array('nid' => $edit['nid']))); + $output .= node_view(node_load($edit['nid'])); $edit['pid'] = 0; } @@ -1260,7 +1280,7 @@ function comment_moderate() { $votes[$mod->mid] = $mod->value; } - $node = node_load(array('nid' => db_result(db_query('SELECT nid FROM {comments} WHERE cid = %d', key($moderation))))); + $node = node_load(db_result(db_query('SELECT nid FROM {comments} WHERE cid = %d', key($moderation)))); if (user_access('administer comments') || comment_user_can_moderate($node)) { foreach ($moderation as $cid => $vote) { @@ -1668,7 +1692,7 @@ function _comment_update_node_statistics // comments exist if ($count > 0) { - $node = node_load(array('nid' => $nid)); + $node = node_load($nid); $last_reply = db_fetch_object(db_query_range('SELECT cid, name, timestamp, uid FROM {comments} WHERE nid = %d AND status = %d ORDER BY cid DESC', $nid, COMMENT_PUBLISHED, 0, 1)); db_query("UPDATE {node_comment_statistics} SET comment_count = %d, last_comment_timestamp = %d, last_comment_name = '%s', last_comment_uid = %d WHERE nid = %d", $count, $last_reply->timestamp, $last_reply->uid ? NULL : $last_reply->name, $last_reply->uid, $nid); } Index: modules/node.module =================================================================== RCS file: /cvs/drupal/drupal/modules/node.module,v retrieving revision 1.501 diff -u -F^f -r1.501 node.module --- modules/node.module 29 Jun 2005 19:53:14 -0000 1.501 +++ modules/node.module 1 Jul 2005 17:06:32 -0000 @@ -329,9 +329,10 @@ function node_invoke_nodeapi(&$node, $op /** * Load a node object from the database. * + * @param $nid + * ID of the node to load. * @param $conditions - * An array of conditions to match against in the database query. Most calls - * will simply use array('nid' => 52). + * An additional array of conditions to match against in the database query. * @param $revision * Which numbered revision to load. Defaults to the current version. * @param $reset @@ -340,19 +341,25 @@ function node_invoke_nodeapi(&$node, $op * @return * A fully-populated node object. */ -function node_load($conditions, $revision = NULL, $reset = NULL) { +function node_load($nid = 0, $conditions = array(), $revision = NULL, $reset = NULL) { static $nodes = array(); if ($reset) { $nodes = array(); } - $cachable = (count($conditions) == 1 && isset($conditions['nid']) && $revision == NULL); - - if ($cachable && isset($nodes[$conditions['nid']])) { - return $nodes[$conditions['nid']]; + if ($nid) { + $conditions['nid'] = $nid; + $cachable = $revision == NULL; + if ($cachable && $nodes[$nid]) { + return $nodes[$nid]; + } } + if (empty($conditions)) { + return FALSE; + } + // Turn the conditions into a query. foreach ($conditions as $key => $value) { $cond[] = 'n.'. db_escape_string($key) ." = '". db_escape_string($value) ."'"; @@ -387,7 +394,7 @@ function node_load($conditions, $revisio } if ($cachable) { - $nodes[$conditions['nid']] = $node; + $nodes[$nid] = $node; } return $node; @@ -566,7 +573,7 @@ function node_search($op = 'search', $ke $find = do_search($keys, 'node', 'INNER JOIN {node} n ON n.nid = i.sid '. $join .' INNER JOIN {users} u ON n.uid = u.uid', 'n.status = 1'. (empty($where) ? '' : ' AND '. $where)); $results = array(); foreach ($find as $item) { - $node = node_load(array('nid' => $item)); + $node = node_load($item); $extra = node_invoke_nodeapi($node, 'search result'); $results[] = array('link' => url('node/'. $item), 'type' => node_invoke($node, 'node_name'), @@ -668,7 +675,7 @@ function node_menu($may_cache) { } else { if (arg(0) == 'node' && is_numeric(arg(1))) { - $node = node_load(array('nid' => arg(1))); + $node = node_load(arg(1)); if ($node->nid) { $items[] = array('path' => 'node/'. arg(1), 'title' => t('view'), 'callback' => 'node_page', @@ -969,7 +976,7 @@ function node_types_configure($type = NU */ function node_revision_overview($nid) { if (user_access('administer nodes')) { - $node = node_load(array('nid' => $nid)); + $node = node_load($nid); drupal_set_title(check_plain($node->title)); @@ -1003,7 +1010,7 @@ function node_revision_create($node) { // "Revision" is the name of the field used to indicate that we have to // create a new revision of a node. if ($node->nid && $node->revision) { - $prev = node_load(array('nid' => $node->nid)); + $prev = node_load($node->nid); $node->revisions = $prev->revisions; unset($prev->revisions); $node->revisions[] = array('uid' => $user->uid, 'timestamp' => time(), 'node' => $prev, 'history' => $node->history); @@ -1019,7 +1026,7 @@ function node_revision_rollback($nid, $r global $user; if (user_access('administer nodes')) { - $node = node_load(array('nid' => $nid)); + $node = node_load($nid); // Extract the specified revision: $rev = $node->revisions[$revision]['node']; @@ -1050,7 +1057,7 @@ function node_revision_rollback($nid, $r */ function node_revision_delete($nid, $revision) { if (user_access('administer nodes')) { - $node = node_load(array('nid' => $nid)); + $node = node_load($nid); unset($node->revisions[$revision]); @@ -1130,7 +1137,7 @@ function node_feed($nodes = 0, $channel while ($node = db_fetch_object($nodes)) { // Load the specified node: - $item = node_load(array('nid' => $node->nid)); + $item = node_load($node->nid); $link = url("node/$node->nid", NULL, NULL, 1); // Filter and prepare node teaser @@ -1431,7 +1438,7 @@ function node_add($type) { function node_edit($id) { global $user; - $node = node_load(array('nid' => $id)); + $node = node_load($id); drupal_set_title(check_plain($node->title)); @@ -1563,7 +1570,7 @@ function node_submit(&$node) { * Ask for confirmation, and delete the node. */ function node_delete($edit) { - $node = node_load(array('nid' => $edit['nid'])); + $node = node_load($edit['nid']); if (node_access('delete', $node)) { @@ -1614,7 +1621,7 @@ function node_page_default() { $output = ''; while ($node = db_fetch_object($result)) { - $output .= node_view(node_load(array('nid' => $node->nid)), 1); + $output .= node_view(node_load($node->nid), 1); } $output .= theme('pager', NULL, variable_get('default_nodes_main', 10)); } @@ -1664,7 +1671,7 @@ function node_page() { break; case 'edit': if (is_numeric(arg(1))) { - $node = node_load(array('nid' => arg(1))); + $node = node_load(arg(1)); if ($node->nid) { drupal_set_title($node->title); return node_edit(arg(1)); @@ -1676,7 +1683,7 @@ function node_page() { break; case 'view': if (is_numeric(arg(1))) { - $node = node_load(array('nid' => arg(1)), $_GET['revision']); + $node = node_load(arg(1), $_GET['revision']); if ($node->nid) { drupal_set_title(check_plain($node->title)); return node_show($node, arg(2)); @@ -1737,7 +1744,7 @@ function node_update_index() { while ($node = db_fetch_object($result)) { $last_comment = $node->last_comment_timestamp; - $node = node_load(array('nid' => $node->nid)); + $node = node_load($node->nid); // We update this variable per node in case cron times out, or if the node // cannot be indexed (PHP nodes which call drupal_goto, for example). Index: modules/poll.module =================================================================== RCS file: /cvs/drupal/drupal/modules/poll.module,v retrieving revision 1.165 diff -u -F^f -r1.165 poll.module --- modules/poll.module 27 Jun 2005 18:33:32 -0000 1.165 +++ modules/poll.module 1 Jul 2005 17:06:32 -0000 @@ -54,7 +54,7 @@ function poll_block($op = 'list', $delta $sql = db_rewrite_sql("SELECT MAX(n.created) FROM {node} n INNER JOIN {poll} p ON p.nid = n.nid WHERE n.status = 1 AND p.active = 1 AND n.moderate = 0"); $timestamp = db_result(db_query($sql)); if ($timestamp) { - $poll = node_load(array('type' => 'poll', 'created' => $timestamp, 'moderate' => 0, 'status' => 1)); + $poll = node_load(NULL, array('type' => 'poll', 'created' => $timestamp, 'moderate' => 0, 'status' => 1)); if ($poll->nid) { // poll_view() dumps the output into $poll->body. @@ -203,7 +203,7 @@ function poll_menu($may_cache) { } else { if (arg(0) == 'node' && is_numeric(arg(1))) { - $node = node_load(array('nid' => arg(1))); + $node = node_load(arg(1)); if ($node->type == 'poll' && $node->allowvotes) { $items[] = array('path' => 'node/'. arg(1) .'/results', @@ -360,7 +360,7 @@ function poll_view_results(&$node, $teas * Callback for the 'results' tab for polls you can vote on */ function poll_results() { - if ($node = node_load(array('nid' => arg(1)))) { + if ($node = node_load(arg(1))) { drupal_set_title(check_plain($node->title)); return node_show($node, 0); } @@ -374,7 +374,7 @@ function poll_results() { */ function poll_vote(&$node) { $nid = arg(2); - if ($node = node_load(array('nid' => $nid))) { + if ($node = node_load($nid)) { $edit = $_POST['edit']; $choice = $edit['choice']; $vote = $_POST['vote']; Index: modules/statistics.module =================================================================== RCS file: /cvs/drupal/drupal/modules/statistics.module,v retrieving revision 1.196 diff -u -F^f -r1.196 statistics.module --- modules/statistics.module 7 Jun 2005 18:54:37 -0000 1.196 +++ modules/statistics.module 1 Jul 2005 17:06:33 -0000 @@ -160,7 +160,7 @@ function statistics_access_log($aid) { } function statistics_node_tracker() { - if ($node = node_load(array('nid' => arg(1)))) { + if ($node = node_load(arg(1))) { $header = array( array('data' => t('Time'), 'field' => 'a.timestamp', 'sort' => 'desc'), Index: modules/taxonomy.module =================================================================== RCS file: /cvs/drupal/drupal/modules/taxonomy.module,v retrieving revision 1.209 diff -u -F^f -r1.209 taxonomy.module --- modules/taxonomy.module 27 Jun 2005 18:33:33 -0000 1.209 +++ modules/taxonomy.module 1 Jul 2005 17:06:34 -0000 @@ -1005,7 +1005,7 @@ function taxonomy_select_nodes($tids = a function taxonomy_render_nodes($result) { if (db_num_rows($result) > 0) { while ($node = db_fetch_object($result)) { - $output .= node_view(node_load(array('nid' => $node->nid)), 1); + $output .= node_view(node_load($node->nid), 1); } $output .= theme('pager', NULL, variable_get('default_nodes_main', 10), 0); }