? files ? register_globals_check-D5.patch ? sites/default/themes Index: modules/system/system.install =================================================================== RCS file: /cvs/drupal/drupal/modules/system/system.install,v retrieving revision 1.69.2.9 diff -u -p -r1.69.2.9 system.install --- modules/system/system.install 10 Jan 2008 22:14:24 -0000 1.69.2.9 +++ modules/system/system.install 15 Jan 2008 15:43:24 -0000 @@ -39,9 +39,20 @@ function system_requirements($phase) { $requirements['php']['description'] = $t('Your PHP installation is too old. Drupal requires at least PHP %version.', array('%version' => DRUPAL_MINIMUM_PHP)); $requirements['php']['severity'] = REQUIREMENT_ERROR; } - if (ini_get('register_globals')) { - $requirements['php']['description'] = $t('register_globals is enabled. Drupal requires this configuration directive to be disabled. Your site may not be secure when register_globals is enabled. The PHP manual has instructions for how to change configuration settings.'); - $requirements['php']['severity'] = REQUIREMENT_ERROR; + + // Test PHP register_globals setting. + $requirements['php_register_globals'] = array( + 'title' => $t('PHP register globals'), + ); + $register_globals = ini_get('register_globals'); + // Register globals is on if the value is 'on' or it's a number != 0. + if (strtolower($register_globals) == 'on' || (!empty($register_globals) && is_numeric($register_globals))) { + $requirements['php_register_globals']['description'] = $t('register_globals is enabled. Drupal requires this configuration directive to be disabled. Your site may not be secure when register_globals is enabled. The PHP manual has instructions for how to change configuration settings.'); + $requirements['php_register_globals']['severity'] = REQUIREMENT_ERROR; + $requirements['php_register_globals']['value'] = $t('Enabled'); + } + else { + $requirements['php_register_globals']['value'] = $t('Disabled'); } // Test DB version