? rename_drupal_to_js.patch
? search-api.patch
Index: coder_review/includes/coder_review_7x.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/coder/coder_review/includes/coder_review_7x.inc,v
retrieving revision 1.46
diff -u -p -r1.46 coder_review_7x.inc
--- coder_review/includes/coder_review_7x.inc	18 Oct 2009 23:50:44 -0000	1.46
+++ coder_review/includes/coder_review_7x.inc	24 Oct 2009 15:51:08 -0000
@@ -148,6 +148,18 @@ function coder_review_7x_reviews() {
       ),
       // http://drupal.org/node/224333#archive-tar
       // http://drupal.org/node/224333#search-api
+      array(
+        '#type' => 'regex',
+        '#value' => 'function\s+[a-z0-9_]+_(search)\s*\(',
+        '#warning_callback' => '_coder_review_7x_hook_search_warning',
+      ),
+
+      array(
+        '#type' => 'regex',
+        '#value' => '[\s\(]do_search\s*\(',
+        '#warning_callback' => '_coder_review_7x_do_search_warning',
+      ),
+
       // http://drupal.org/node/224333#user-1
 
 
@@ -1881,6 +1893,35 @@ function _coder_review_7x_time_limit_war
   );
 }
 
+function _coder_review_7x_hook_search_warning() {
+  return array(
+    '#warning' => t('!hook_search() has been removed and separated into respective $op functions: !hook_search_info(), !hook_search_admin(), !hook_search_execute(), !hook_search_reset(), !hook_search_status(). Also !hook_search_access has been introduced to control access permissions.',
+    array(
+      '!hook_search()' => theme('drupalapi', array('function' => 'hook_search', 'version' => 6)),
+      '!hook_search_info()' => theme('drupalapi', array('function' => 'hook_search_info', 'version' => 7)),
+      '!hook_search_admin()' => theme('drupalapi', array('function' => 'hook_search_admin', 'version' => 7)),
+      '!hook_search_execute()' => theme('drupalapi', array('function' => 'hook_search_execute', 'version' => 7)),
+      '!hook_search_reset()' => theme('drupalapi', array('function' => 'hook_search_reset', 'version' => 7)),
+      '!hook_search_status()' => theme('drupalapi', array('function' => 'hook_search_status', 'version' => 7)),
+      '!hook_search_access()' => theme('drupalapi', array('function' => 'hook_search_access', 'version' => 7)),
+      )
+    ),
+    '#link' => 'http://drupal.org/node/224333#search-api',
+  );
+}
+
+function _coder_review_7x_do_search_warning() {
+  return array(
+    '#warning' => t('!do_search() has been removed. Modules should use the search query directly using the "SearchQuery extension. Example: !node_search_execute().',
+    array(
+      '!do_search()' => theme('drupalapi', array('function' => 'do_search', 'version' => 6)),
+      '!node_search_execute()' => theme('drupalapi', array('function' => 'node_search_execute', 'version' => 7)),
+      )
+    ),
+    '#link' => 'http://drupal.org/node/224333#search-api',
+  );
+}
+
 function _coder_review_7x_user_authenticate_warning() {
   return array(
     '#warning' => t('Parameters to !user_authenticate() have changed.',
Index: coder_review/tests/coder_review_7x.test
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/coder/coder_review/tests/coder_review_7x.test,v
retrieving revision 1.40
diff -u -p -r1.40 coder_review_7x.test
--- coder_review/tests/coder_review_7x.test	18 Oct 2009 23:50:44 -0000	1.40
+++ coder_review/tests/coder_review_7x.test	24 Oct 2009 15:51:08 -0000
@@ -124,6 +124,8 @@ class CoderReviewUpgrade7xTest extends C
 
     // http://drupal.org/node/224333#archive-tar
     // http://drupal.org/node/224333#search-api
+    $this->assertCoderReviewFail("  function mymodule_search() {\n}");
+    $this->assertCoderReviewFail('  do_search($keywords, $type);');
     // http://drupal.org/node/224333#user-1
 
   }