diff -ur ./database/database.mysql /root/drupal-4.5.1/database/database.mysql --- ./database/database.mysql Mon Dec 13 19:21:05 2004 +++ /root/drupal-4.5.1/database/database.mysql Mon Oct 18 13:35:19 2004 @@ -534,23 +534,11 @@ CREATE TABLE search_index ( word varchar(50) NOT NULL default '', - sid int(10) unsigned NOT NULL default '0', + lno int(10) unsigned NOT NULL default '0', type varchar(16) default NULL, - fromsid int(10) unsigned NOT NULL default '0', - fromtype varchar(16) default NULL, - score int(10) unsigned default NULL, - KEY sid (sid), - KEY word (word) -) TYPE=MyISAM; - --- --- Table structure for table 'search_total' --- - -CREATE TABLE search_total ( - word varchar(50) NOT NULL default '', count int(10) unsigned default NULL, - PRIMARY KEY word (word) + KEY lno (lno), + KEY word (word) ) TYPE=MyISAM; -- diff -ur ./database/updates.inc /root/drupal-4.5.1/database/updates.inc --- ./database/updates.inc Mon Dec 13 19:34:59 2004 +++ /root/drupal-4.5.1/database/updates.inc Tue Oct 19 13:00:25 2004 @@ -85,8 +85,7 @@ "2004-09-15" => "update_106", "2004-09-17" => "update_107", "2004-10-16" => "update_108", - "2004-10-18" => "update_109", - "2004-10-28: first update since Drupal 4.5.0 release" => "update_110" + "2004-10-18" => "update_109" ); function update_32() { @@ -1922,35 +1921,6 @@ return $ret; } -function update_110() { - $ret = array(); - - // TODO: needs PGSQL version - if ($GLOBALS['db_type'] == 'mysql') { - $ret[] = update_sql('DROP TABLE {search_index}'); - $ret[] = update_sql("CREATE TABLE {search_index} ( - word varchar(50) NOT NULL default '', - sid int(10) unsigned NOT NULL default '0', - type varchar(16) default NULL, - fromsid int(10) unsigned NOT NULL default '0', - fromtype varchar(16) default NULL, - score int(10) unsigned default NULL, - KEY sid (sid), - KEY fromsid(fromsid), - KEY word (word) - ) TYPE=MyISAM"); - - $ret[] = update_sql("CREATE TABLE {search_total} ( - word varchar(50) NOT NULL default '', - count int(10) unsigned default NULL, - PRIMARY KEY word (word) - ) TYPE=MyISAM"); - - $ret[] = update_sql("DELETE FROM {variable} WHERE name = 'node_cron_last'"); - } - - return $ret; -} function update_sql($sql) { $edit = $_POST["edit"]; diff -ur ./includes/common.inc /root/drupal-4.5.1/includes/common.inc --- ./includes/common.inc Sun Dec 12 11:15:41 2004 +++ /root/drupal-4.5.1/includes/common.inc Mon Nov 29 11:59:50 2004 @@ -606,6 +606,134 @@ * @} End of "defgroup validation". */ +/** + * @defgroup search Search interface + * @{ + * The Drupal search interface manages a global search mechanism. + * + * Modules may plug into this system to provide searches of different types of + * data. Most of the system is handled by search.module, so this must be enabled + * for all of the search features to work. + */ + +/** + * Format a single result entry of a search query. + * + * Modules may implement hook_search_item() in order to override this default + * function to display search results. + * + * @param $item + * A single search result as returned by hook_search(). The result should be + * an array with keys "count", "link", "title", "user", "date", and "keywords". + * @param $type + * The type of item found, such as "user" or "comment". + */ +function search_item($item, $type) { + if (module_hook($type, 'search_item')) { + $output = module_invoke($type, 'search_item', $item); + } + else { + $output = '
'. $item['title'] .'
'; + $output .= '
' . t($type) . ($item['user'] ? ' - '. $item['user'] : '') .''. ($item['date'] ? ' - '. format_date($item['date'], 'small') : '') .'
'; + } + + return $output; +} + +/** + * Render a generic search form. + * + * This form must be usable not only within "http://example.com/search", but also + * as a simple search box (without "Restrict search to", help text, etc.), in the + * theme's header, and so forth. This means we must provide options to + * conditionally render certain parts of this form. + * + * @param $action + * Form action. Defaults to "search". + * @param $keys + * The search string entered by the user, containing keywords for the search. + * @param $options + * Whether to render the optional form fields and text ("Restrict search + * to", help text, etc.). + * @return + * An HTML string containing the search form. + */ +function search_form($action = '', $keys = '', $options = FALSE) { + $edit = $_POST['edit']; + + if (!$action) { + $action = url('search'); + } + + $output = '

'; + $output .= ' \n"; + + if ($options) { + $output .= '
'; + $output .= t('Restrict search to') .': '; + + foreach (module_list() as $name) { + if (module_hook($name, 'search')) { + $output .= ' '. t($name); + } + } + } + $output .= '
'; + + return form($output, 'post', $action); +} + +/** + * Perform a global search on the given keys, and return the formatted results. + */ +function search_data($keys = NULL) { + $edit = $_POST['edit']; + $output = ''; + + if (isset($keys)) { + foreach (module_list() as $name) { + if (module_hook($name, 'search') && (!$edit['type'] || $edit['type'][$name])) { + list($title, $results) = module_invoke($name, 'search', $keys); + if ($results) { + $output .= '

'. $title .'

'; + $output .= '
'; + foreach ($results as $entry) { + $output .= search_item($entry, $name); + } + $output .= '
'; + } + } + } + } + + return $output; +} + +/** + * Display a search form for a particular type of data. + * + * @param $type + * The type of content to search within. + * @param $action + * Form action. Defaults to "search". + * @param $keys + * The search string entered by the user, containing keywords for the search. + * @param $options + * Whether to render the optional form fields and text ("Restrict search + * to", help text, etc.). + * @return + * An HTML string containing the search form and results. + */ +function search_type($type, $action = '', $keys = '', $options = FALSE) { + $_POST['edit']['type'][$type] = 'on'; + + return search_form($action, $keys, $options) . '
'. search_data($keys); +} + +/** + * @} End of "defgroup search". + */ + function check_form($text) { return drupal_specialchars($text, ENT_QUOTES); } @@ -1650,7 +1778,7 @@ /** * Encodes MIME/HTTP header values that contain non US-ASCII characters. * - * For example, mime_header_encode('tést.txt') returns "=?UTF-8?B?dMOpc3QudHh0?=". + * For example, mime_header_encode('tést.txt') returns "=?UTF-8?B?dMOpc3QudHh0?=". * * See http://www.rfc-editor.org/rfc/rfc2047.txt for more information. * @@ -1670,59 +1798,6 @@ $string = trim(preg_replace('/^(.*)$/m', " =?$charset?B?\\1?=", $string)); } return $string; -} - -/** - * Decode all HTML entities (including numerical ones) to regular UTF-8 bytes. - */ -function decode_entities($text) { - static $table; - // We store named entities in a table for quick processing. - if (!isset($table)) { - // Get all named HTML entities. - $table = array_flip(get_html_translation_table(HTML_ENTITIES, $special)); - // PHP gives us Windows-1252/ISO-8859-1 data, we need UTF-8. - $table = array_map('utf8_encode', $table); - } - $text = strtr($text, $table); - - // Any remaining entities are numerical. Use a regexp to replace them. - return preg_replace('/&#(x?)([A-Za-z0-9]+);/e', '_decode_entities("$1", "$2")', $text); -} - -/** - * Helper function for decode_entities - */ -function _decode_entities($hex, $codepoint) { - if ($hex != '') { - $codepoint = base_convert($codepoint, 16, 10); - } - if ($codepoint < 0x80) { - return chr($codepoint); - } - else if ($codepoint < 0x800) { - return chr(0xC0 | ($codepoint >> 6)) - . chr(0x80 | ($codepoint & 0x3F)); - } - else if ($codepoint < 0x10000) { - return chr(0xE0 | ( $codepoint >> 12)) - . chr(0x80 | (($codepoint >> 6) & 0x3F)) - . chr(0x80 | ( $codepoint & 0x3F)); - } - else if ($codepoint < 0x200000) { - return chr(0xF0 | ( $codepoint >> 18)) - . chr(0x80 | (($codepoint >> 12) & 0x3F)) - . chr(0x80 | (($codepoint >> 6) & 0x3F)) - . chr(0x80 | ( $codepoint & 0x3F)); - } -} - -/** - * Count the amount of characters in a UTF-8 string. This is less than or - * equal to the byte count. - */ -function string_length(&$text) { - return strlen(preg_replace("/[\x80-\xBF]/", '', $text)); } /** diff -ur ./includes/conf.php /root/drupal-4.5.1/includes/conf.php --- ./includes/conf.php Mon Dec 13 19:12:35 2004 +++ /root/drupal-4.5.1/includes/conf.php Tue Oct 19 13:00:26 2004 @@ -24,7 +24,7 @@ # $db_url = "mysql://user:password@hostname/database"; # $db_url = "pgsql://user:password@hostname/database"; -$db_url = "mysql://drupal:shaft000@localhost/drupal"; +$db_url = "mysql://drupal:drupal@localhost/drupal"; # If $db_prefix is specified all database table names will be # prepended with this string. Be sure to use valid database @@ -38,7 +38,7 @@ # The URL of your website's main page. It is not allowed to have # a trailing slash; Drupal will add it for you. # -$base_url = "http://ninjapanda.org"; +$base_url = "http://localhost"; # # PHP settings: diff -ur ./misc/drupal.css /root/drupal-4.5.1/misc/drupal.css --- ./misc/drupal.css Sun Dec 12 11:15:41 2004 +++ /root/drupal-4.5.1/misc/drupal.css Mon Sep 20 20:35:40 2004 @@ -383,31 +383,6 @@ display: block; margin: 2px; } -.search-form { - margin-bottom: 1em; -} -.search-form p { - margin-top: 0; - margin-bottom: 0.2em; - padding-top: 0; - padding-bottom: 0; -} -.search-form input { - margin-top: 0; - margin-bottom: 0; -} -.search-results p { - margin-top: 0; -} -.search-results dt { - font-size: 1.1em; -} -.search-results dd { - margin-bottom: 1em; -} -.search-results .search-info { - font-size: 0.85em; -} #tracker td.replies { text-align: center; } diff -ur ./modules/comment.module /root/drupal-4.5.1/modules/comment.module --- ./modules/comment.module Sun Dec 12 11:15:41 2004 +++ /root/drupal-4.5.1/modules/comment.module Mon Nov 29 11:59:50 2004 @@ -74,6 +74,8 @@ return t("Use these forms to setup the name and minimum \"cut off\" score to help your users hide comments they don't want to see. These thresholds appear in the user's comment control panel. Click \"edit threshold\" to modify the values of an already existing configuration. To delete a setting, \"edit\" it first, and then choose \"delete threshold\"."); case 'admin/comment/configure/votes': return t("Create and control the possible comment moderation votes here. \"Weight\" lets you set the order of the drop down menu. Click \"edit\" to edit a current vote weight. To delete a name/weight combination go to the \"edit\" area. To delete a setting, \"edit\" it first, and then choose \"delete vote\"."); + case 'admin/comment/search': + return t("Enter a simple pattern ('*' may be used as a wildcard match) to search for a comment. For example, one may search for 'br' and Drupal might return 'bread brakers', 'our daily bread' and 'brenda'."); case 'admin/modules#description': return t('Enables user to comment on published content.'); } @@ -99,6 +101,10 @@ 'type' => MENU_DEFAULT_LOCAL_TASK, 'weight' => -10); $items[] = array('path' => 'admin/comment/configure', 'title' => t('configure'), 'callback' => 'comment_configure', 'access' => $access, 'type' => MENU_LOCAL_TASK); + if (module_exist('search')) { + $items[] = array('path' => 'admin/comment/search', 'title' => t('search'), + 'callback' => 'comment_search', 'access' => $access, 'type' => MENU_LOCAL_TASK); + } // Subtabs: $items[] = array('path' => 'admin/comment/list/new', 'title' => t('new comments'), @@ -262,6 +268,37 @@ } /** + * Implementation of hook_search(). + * + * This search function uses search.module's built-in content index by + * calling do_search(). The "nid" identifier in the select is used to + * present search results in the context of their associated node. + * + * This function doubles as a menu callback for the administrative comment search. + */ +function comment_search($keys = NULL) { + if (!$keys) { + // if there are no keys, we've been called from our menu callback, + // so we hook into the search.module to pass the $keys back to us. + print theme('page', search_type('comment', url('admin/comment/search'), $_POST['keys'])); + } + else if ($keys) { + $find = do_search(array('keys' => $keys, 'type' => 'comment', 'select' => 'SELECT s.lno AS lno, c.nid AS nid, c.subject AS title, c.timestamp AS created, u.uid AS uid, u.name AS name, s.count AS count FROM {search_index} s, {comments} c INNER JOIN {users} u ON c.uid = u.uid '. node_access_join_sql('c') .' WHERE '. node_access_where_sql() ." AND s.lno = c.cid AND s.type = 'comment' AND c.status = 0 AND s.word like '%'")); + return array(t('Matching comments ranked in order of relevance'), $find); + } +} + +/** + * Implementation of hook_update_index(). + * + * The SQL statement returned checks for the last time the index was updated + * so as not to cause redundant work for the indexer. + */ +function comment_update_index() { + return array('last_update' => 'comment_cron_last', 'node_type' => 'comment', 'select' => 'SELECT c.cid as lno, c.subject as text1, c.comment as text2 FROM {comments} c WHERE c.status = 0 AND timestamp > '. variable_get('comment_cron_last', 1)); +} + +/** * Implementation of hook_user(). * * Provides signature customization for the user's comments. @@ -1213,7 +1250,7 @@ } /** -*** misc functions: helpers, privates, history +*** misc functions: helpers, privates, history, search **/ diff -ur ./modules/node.module /root/drupal-4.5.1/modules/node.module --- ./modules/node.module Mon Dec 13 19:41:16 2004 +++ /root/drupal-4.5.1/modules/node.module Mon Nov 29 06:48:11 2004 @@ -553,30 +553,29 @@ /** * Implementation of hook_search(). + * + * Return the results of performing a search using the indexed search + * for this particular type of node. + * + * Pass an array to the 'do_search' function which dictates what it + * will search through, and what it will search for + * + * "keys"'s value is the keywords entered by the user + * + * "type"'s value is used to identify the node type in the search + * index. + * + * "select"'s value is used to relate the data from the specific nodes + * table to the data that the search_index table has in it, and the the + * do_search function will rank it. + * + * The select must always provide the following fields: lno, title, + * created, uid, name, and count. */ -function node_search($op = 'search', $keys = null) { - switch ($op) { - case 'name': - return t('content'); - case 'reset': - variable_del('node_cron_last'); - return; - case 'search': - $find = do_search($keys, 'node', 'INNER JOIN {node} n ON n.nid = i.sid '. node_access_join_sql() .' INNER JOIN {users} u ON n.uid = u.uid', 'n.status = 1 AND '. node_access_where_sql()); - $results = array(); - foreach ($find as $item) { - $node = node_load(array('nid' => $item)); - $comments = db_result(db_query('SELECT comment_count FROM {node_comment_statistics} WHERE nid = %d', $item)); - $results[] = array('link' => url('node/'. $item), - 'type' => node_invoke($node, 'node_name'), - 'title' => $node->title, - 'user' => format_name($node), - 'date' => $node->changed, - 'extra' => format_plural($comments, '1 comment', '%count comments'), - 'snippet' => search_excerpt($keys, check_output($node->body, $node->format))); - } - return $results; - } +function node_search($keys) { + $find = do_search(array('keys' => $keys, 'type' => 'node', 'select' => "SELECT DISTINCT s.lno as lno, n.title as title, n.created as created, u.uid as uid, u.name as name, s.count as count FROM {search_index} s, {node} n ". node_access_join_sql() ." INNER JOIN {users} u ON n.uid = u.uid WHERE s.lno = n.nid AND s.type = 'node' AND s.word like '%' AND n.status = 1 AND ". node_access_where_sql())); + + return array(t('Matching nodes ranked in order of relevance'), $find); } /** @@ -948,8 +947,7 @@ // Compile a list of the administrative links: switch ($op) { case 'search': - case t('Search'): - $output = search_form(url('admin/node/search'), $_POST['edit']['keys'], 'node') . search_data($_POST['edit']['keys'], 'node'); + $output = search_type('node', url('admin/node/search'), $_POST['keys']); break; case 'delete': $output = node_delete(array('nid' => arg(3))); @@ -1415,9 +1413,6 @@ // Clear the cache so an anonymous poster can see the node being deleted. cache_clear_all(); - // Remove this node from the search index - search_wipe($node->nid, 'node'); - watchdog('special', t('%type: deleted %title.', array('%type' => ''. t($node->type) .'', '%title' => "$node->title"))); $output = t('The node has been deleted.'); } @@ -1519,45 +1514,24 @@ /** * Implementation of hook_update_index(). + * + * Returns an array of values to dictate how to update the search index + * for this particular type of node. + * + * "last_update"'s value is used with variable_set to set the + * last time this node type had an index update run. + * + * "node_type"'s value is used to identify the node type in the search + * index. + * + * "select"'s value is used to select the node id and text fields from + * the table we are indexing. In this case, we also check against the + * last run date for the nodes update. */ function node_update_index() { - $last = variable_get('node_cron_last', 0); - $limit = (int)variable_get('search_cron_limit', 100); - - $result = db_query_range('SELECT n.nid, c.last_comment_timestamp FROM {node} n LEFT JOIN {node_comment_statistics} c ON n.nid = c.nid WHERE n.status = 1 AND n.moderate = 0 AND (n.created > %d OR n.changed > %d OR c.last_comment_timestamp > %d) ORDER BY GREATEST(n.created, n.changed, c.last_comment_timestamp) ASC', $last, $last, $last, 0, $limit); - while ($node = db_fetch_object($result)) { - $last_comment = $node->last_comment_timestamp; - $node = node_load(array('nid' => $node->nid)); - - // We update this variable per node in case cron times out, or if the node - // cannot be indexed (PHP nodes which call drupal_goto, for example). - // In rare cases this can mean a node is only partially indexed, but the - // chances of this happening are very small. - variable_set('node_cron_last', max($last_comment, $node->changed, $node->created)); - - // Get node output (filtered and with module-specific fields). - if (node_hook($node, 'view')) { - node_invoke($node, 'view', false, false); - } - else { - $node = node_prepare($node, false); - } - // Allow modules to change $node->body before viewing. - node_invoke_nodeapi($node, 'view', false, false); - - $text = '

'. drupal_specialchars($node->title) .'

'. $node->body; - - // Fetch comments - if (module_exist('comment')) { - $comments = db_query('SELECT subject, comment, format FROM {comments} WHERE nid = %d AND status = 0', $node->nid); - while ($comment = db_fetch_object($comments)) { - $text .= '

'. $comment->subject .'

'. check_output($comment->comment, $comment->format); - } - } - - // Update index - search_index($node->nid, 'node', $text); - } + return array('last_update' => 'node_cron_last', + 'node_type' => 'node', + 'select' => "SELECT n.nid as lno, n.title as text1, n.body as text2 FROM {node} n WHERE n.status = 1 AND moderate = 0 and (created > " . variable_get('node_cron_last', 1) . " or changed > " . variable_get('node_cron_last', 1) . ")"); } /** diff -ur ./modules/search.module /root/drupal-4.5.1/modules/search.module --- ./modules/search.module Mon Dec 13 19:41:48 2004 +++ /root/drupal-4.5.1/modules/search.module Thu Oct 28 19:09:41 2004 @@ -7,54 +7,20 @@ */ /** - * Unicode character classes to include in the index. - * See: http://www.unicode.org/Public/UNIDATA/UCD.html#General_Category_Values - * - * Lu Letter, Uppercase - * Ll Letter, Lowercase - * Lt Letter, Titlecase - * Lm Letter, Modifier - * Lo Letter, Other - * Mn Mark, Nonspacing - * Mc Mark, Spacing Combining - * Nd Number, Decimal Digit - * Nl Number, Letter - * No Number, Other - * Sm Symbol, Math - * Sc Symbol, Currency - * Sk Symbol, Modifier - * So Symbol, Other - * - * Matches all character classes not in the list above (enclosing marks, punctuation and control codes, spacers). - * 'Me', 'Pc', 'Pd', 'Ps', 'Pe', 'Pi', 'Pf', 'Po', 'Zs', 'Zl', 'Zp', 'Cc', 'Cf', 'Cs', 'Co' - */ -define('PREG_CLASS_SEARCH_EXCLUDE', '\x{0}-\x{23}\x{25}-\x{2a}\x{2c}-\x{2f}\x{3a}\x{3b}\x{3f}\x{40}\x{5b}-\x{5d}\x{5f}\x{7b}\x{7d}\x{7f}-\x{a1}\x{ab}\x{ad}\x{b7}\x{bb}\x{bf}\x{37e}\x{387}\x{488}\x{489}\x{55a}-\x{55f}\x{589}\x{58a}\x{5be}\x{5c0}\x{5c3}\x{5f3}\x{5f4}\x{600}-\x{603}\x{60c}\x{60d}\x{61b}\x{61f}\x{66a}-\x{66d}\x{6d4}\x{6dd}\x{6de}\x{700}-\x{70d}\x{70f}\x{964}\x{965}\x{970}\x{df4}\x{e4f}\x{e5a}\x{e5b}\x{f04}-\x{f12}\x{f3a}-\x{f3d}\x{f85}\x{104a}-\x{104f}\x{10fb}\x{1361}-\x{1368}\x{166d}\x{166e}\x{1680}\x{169b}\x{169c}\x{16eb}-\x{16ed}\x{1735}\x{1736}\x{17b4}\x{17b5}\x{17d4}-\x{17d6}\x{17d8}-\x{17da}\x{1800}-\x{180a}\x{180e}\x{1944}\x{1945}\x{2000}-\x{2043}\x{2045}-\x{2051}\x{2053}\x{2054}\x{2057}\x{205f}-\x{2063}\x{206a}-\x{206f}\x{207d}\x{207e}\x{208d}\x{208e}\x{20dd}-\x{20e0}\x{20e2}-\x{20e4}\x{2329}\x{232a}\x{23b4}-\x{23b6}\x{2768}-\x{2775}\x{27e6}-\x{27eb}\x{2983}-\x{2998}\x{29d8}-\x{29db}\x{29fc}\x{29fd}\x{3000}-\x{3003}\x{3008}-\x{3011}\x{3014}-\x{301f}\x{3030}\x{303d}\x{30a0}\x{30fb}\x{d800}\x{db7f}\x{db80}\x{dbff}\x{dc00}\x{dfff}\x{e000}\x{f8ff}\x{fd3e}\x{fd3f}\x{fe30}-\x{fe52}\x{fe54}-\x{fe61}\x{fe63}\x{fe68}\x{fe6a}\x{fe6b}\x{feff}\x{ff01}-\x{ff03}\x{ff05}-\x{ff0a}\x{ff0c}-\x{ff0f}\x{ff1a}\x{ff1b}\x{ff1f}\x{ff20}\x{ff3b}-\x{ff3d}\x{ff3f}\x{ff5b}\x{ff5d}\x{ff5f}-\x{ff65}\x{fff9}-\x{fffb}\x{10100}\x{10101}\x{1039f}\x{1d173}-\x{1d17a}\x{e0001}\x{e0020}-\x{e007f}\x{f0000}\x{ffffd}\x{100000}'); - -/** - * Matches all 'N' character classes (numbers) - */ -define('PREG_CLASS_NUMBERS', '\x{30}-\x{39}\x{b2}\x{b3}\x{b9}\x{bc}-\x{be}\x{660}-\x{669}\x{6f0}-\x{6f9}\x{966}-\x{96f}\x{9e6}-\x{9ef}\x{9f4}-\x{9f9}\x{a66}-\x{a6f}\x{ae6}-\x{aef}\x{b66}-\x{b6f}\x{be7}-\x{bf2}\x{c66}-\x{c6f}\x{ce6}-\x{cef}\x{d66}-\x{d6f}\x{e50}-\x{e59}\x{ed0}-\x{ed9}\x{f20}-\x{f33}\x{1040}-\x{1049}\x{1369}-\x{137c}\x{16ee}-\x{16f0}\x{17e0}-\x{17e9}\x{17f0}-\x{17f9}\x{1810}-\x{1819}\x{1946}-\x{194f}\x{2070}\x{2074}-\x{2079}\x{2080}-\x{2089}\x{2153}-\x{2183}\x{2460}-\x{249b}\x{24ea}-\x{24ff}\x{2776}-\x{2793}\x{3007}\x{3021}-\x{3029}\x{3038}-\x{303a}\x{3192}-\x{3195}\x{3220}-\x{3229}\x{3251}-\x{325f}\x{3280}-\x{3289}\x{32b1}-\x{32bf}\x{ff10}-\x{ff19}\x{10107}-\x{10133}\x{10320}-\x{10323}\x{1034a}\x{104a0}-\x{104a9}\x{1d7ce}-\x{1d7ff}'); - -/** - * Matches all 'P' character classes (punctuation) - */ -define('PREG_CLASS_PUNCTUATION', '\x{21}-\x{23}\x{25}-\x{2a}\x{2c}-\x{2f}\x{3a}\x{3b}\x{3f}\x{40}\x{5b}-\x{5d}\x{5f}\x{7b}\x{7d}\x{a1}\x{ab}\x{b7}\x{bb}\x{bf}\x{37e}\x{387}\x{55a}-\x{55f}\x{589}\x{58a}\x{5be}\x{5c0}\x{5c3}\x{5f3}\x{5f4}\x{60c}\x{60d}\x{61b}\x{61f}\x{66a}-\x{66d}\x{6d4}\x{700}-\x{70d}\x{964}\x{965}\x{970}\x{df4}\x{e4f}\x{e5a}\x{e5b}\x{f04}-\x{f12}\x{f3a}-\x{f3d}\x{f85}\x{104a}-\x{104f}\x{10fb}\x{1361}-\x{1368}\x{166d}\x{166e}\x{169b}\x{169c}\x{16eb}-\x{16ed}\x{1735}\x{1736}\x{17d4}-\x{17d6}\x{17d8}-\x{17da}\x{1800}-\x{180a}\x{1944}\x{1945}\x{2010}-\x{2027}\x{2030}-\x{2043}\x{2045}-\x{2051}\x{2053}\x{2054}\x{2057}\x{207d}\x{207e}\x{208d}\x{208e}\x{2329}\x{232a}\x{23b4}-\x{23b6}\x{2768}-\x{2775}\x{27e6}-\x{27eb}\x{2983}-\x{2998}\x{29d8}-\x{29db}\x{29fc}\x{29fd}\x{3001}-\x{3003}\x{3008}-\x{3011}\x{3014}-\x{301f}\x{3030}\x{303d}\x{30a0}\x{30fb}\x{fd3e}\x{fd3f}\x{fe30}-\x{fe52}\x{fe54}-\x{fe61}\x{fe63}\x{fe68}\x{fe6a}\x{fe6b}\x{ff01}-\x{ff03}\x{ff05}-\x{ff0a}\x{ff0c}-\x{ff0f}\x{ff1a}\x{ff1b}\x{ff1f}\x{ff20}\x{ff3b}-\x{ff3d}\x{ff3f}\x{ff5b}\x{ff5d}\x{ff5f}-\x{ff65}\x{10100}\x{10101}\x{1039f}'); - -/** * Implementation of hook_help(). */ function search_help($section = 'admin/help#search') { switch ($section) { + case 'admin/help#search': + return t(" + Search guidelines +

The search page allows you to search the web site's content. You can specify multiple words, and they will all be searched for. You can also use wildcards, so 'walk*' will match 'walk', 'walking', 'walker', 'walkable' and so on. Furthermore, searches are not case sensitive so searching for 'walk', 'Walk' or 'WALK' will yield exactly the same results.

+ Words excluded from the search +

Words that frequently occur, typically called 'noise words', are ignored. Example words are 'a', 'at', 'and', 'are', 'as', 'how', 'where', etc. Words shorter than %number letters are also ignored.

", array('%number' => variable_get('minimum_word_size', 2))); case 'admin/modules#description': return t('Enables site-wide keyword searching.'); - case 'admin/search': - return t('

The search engine works by maintaining an index of words in your site\'s content. You can adjust the settings below to tweak the indexing behaviour. Note that indexing requires cron to be set up correctly.

Changes to these settings will only apply to content that is indexed after the change. If you want them to apply to everything, you need to wipe the index with the button below.

'); - case 'search#noresults': - return t('

', array('%number' => variable_get('minimum_word_size', 3))); + case 'admin/settings/search': + return t('The search engine works by keeping an index of "interesting" words. To make sure we only get "interesting" words you need to set the following.'); } } @@ -92,12 +58,7 @@ $items[] = array('path' => 'search/help', 'title' => t('search help'), 'callback' => 'search_help_page', 'access' => user_access('search content'), - 'type' => MENU_NORMAL_ITEM); - } - if ($_POST['op'] == t('Wipe index')) { - search_wipe(); - drupal_set_message(t('The search index has been wiped.')); - drupal_goto('admin/settings/search'); + 'type' => MENU_SUGGESTED_ITEM); } return $items; @@ -109,657 +70,332 @@ function search_settings() { // Indexing settings: - $group = form_textfield(t('Minimum word length to index'), 'minimum_word_size', variable_get('minimum_word_size', 3), 3, 3, t('The number of characters a word has to be to be indexed. Words shorter than this will not be searchable.')); - $group .= form_textfield(t('Minimum word length to search for'), 'remove_short', variable_get('remove_short', 3), 3, 3, t('The number of characters a word has to be to be searched for, including wildcard characters.')); - $items = drupal_map_assoc(array(10, 20, 50, 100, 200, 500)); - $group .= form_select(t('Items to index per cron run'), 'search_cron_limit', variable_get('search_cron_limit', 100), $items, t('The maximum amount of items that will be indexed in one cron run. Set this number lower if your cron is timing out or if PHP is running out of memory.')); + $group = form_textfield(t('Minimum word length to index'), 'minimum_word_size', variable_get('minimum_word_size', 2), 10, 10, t('The number of characters a word has to be to be indexed. Words shorter than this will not be searchable.')); + $group .= form_textfield(t('Minimum word length to search for'), 'remove_short', variable_get('remove_short', 0), 10, 10, t('The number of characters a word has to be to be searched for.')); + $group .= form_textarea(t('Noise words'), 'noisewords', variable_get('noisewords', ''), 70, 10, t('These words will not be indexed. Enter a comma separated list; linebreaks and whitespace do not matter. Example: and, or, not, a, to, I, it, ...')); $output = form_group(t('Indexing settings'), $group); // Visual settings: - // Collect some stats - $estimate = variable_get('search_indexed', 0); - $nodes = max(1, db_result(db_query('SELECT COUNT(*) FROM {node}'))); - $percentage = ((int)min(100, 100 * $estimate / $nodes)) . '%'; - - $status = '

'. t('Approximately %percentage of the site has been indexed.', array('%percentage' => $percentage)) .'

'; - $status .= '

'. form_button(t('Wipe index')) . '

'; - - $output .= form_group('Indexing status', $status); + $group = form_radios(t('Help text position'), 'help_pos', variable_get('help_pos', 1), array('1' => t('Above search output'), '2' => t('Below search output'), '3' => t('Link from above search output'), '4' => t('Link from below search output')), t('Where to show the help text for users on the search page.')); $output .= form_group(t('Viewing options'), $group); return $output; -} -/** - * Wipes a part of or the entire search index. - * - * @param $sid - * (optional) The SID of the item to wipe. If specified, $type must be passed - * too. - * @param $type - * (optional) The type of item to wipe. - * - */ -function search_wipe($sid = NULL, $type = NULL) { - if ($type == NULL && $sid == NULL) { - db_query('DELETE FROM {search_index}'); - db_query('DELETE FROM {search_total}'); - module_invoke_all('search', 'reset'); - } - else { - db_query("DELETE FROM {search_index} WHERE sid = %d AND type = '%s'", $sid, $type); - db_query("DELETE FROM {search_index} WHERE fromsid = %d AND fromtype = '%s'", $sid, $type); - } -} - - -/** - * Marks a word as dirty (or retrieves the list of dirty words). This is used - * during indexing (cron). Words which are dirty have outdated total counts in - * the search_total table, and need to be recounted. - */ -function search_dirty($word = null) { - static $dirty = array(); - if ($word !== null) { - $dirty[$word] = true; - } - else { - return $dirty; - } } /** * Implementation of hook_cron(). * - * Fires hook_update_index() in all modules and cleans up dirty words (see - * search_dirty). + * Fires hook_update_index() in all modules and uses the results to make + * the search index current. */ function search_cron() { - // Update word index foreach (module_list() as $module) { - module_invoke($module, 'update_index'); - } - // Update word counts for new/changed words - foreach (search_dirty() as $word => $dummy) { - $total = db_result(db_query("SELECT SUM(score) FROM {search_index} WHERE word = '%s'", $word)); - db_query("UPDATE {search_total} SET count = %d WHERE word = '%s'", $total, $word); - if (!db_affected_rows()) { - db_query("INSERT INTO {search_total} (word, count) VALUES ('%s', %d)", $word, $total); + $module_array = module_invoke($module, 'update_index'); + if ($module_array) { + update_index($module_array); } + $module_array = null; } - // Find words that were deleted from search_index, but are still in - // search_total. We use a LEFT JOIN between the two tables and keep only the - // rows which fail to join. - $result = db_query("SELECT t.word AS realword, i.word FROM {search_total} t LEFT JOIN {search_index} i ON t.word = i.word WHERE i.word IS NULL"); - while ($word = db_fetch_object($result)) { - db_query("DELETE FROM {search_total} WHERE word = '%s'", $word->realword); - } - - // Count indexed items (for administration screen) - $indexed = db_result(db_query('SELECT COUNT(DISTINCT sid) FROM {search_index}')); - variable_set('search_indexed', $indexed); -} - - /** - * Splits a string into component words according to indexing rules. - */ -function search_keywords_split($text) { - static $last = null; - static $lastsplit = null; - - if ($last == $text) { - return $lastsplit; - } - - // Decode entities to UTF-8 - $text = decode_entities($text); - - // Call an external processor for word handling. - search_preprocess($text); - - // To improve searching for numerical data such as dates, IP addresses - // or version numbers, we consider a group of numerical characters - // separated only by punctuation characters to be one piece. - // This also means that searching for e.g. '20/03/1984' also returns - // results with '20-03-1984' in them. - // Readable regexp: ([number]+)[punctuation]+(?=[number]) - $text = preg_replace('/(['. PREG_CLASS_NUMBERS .']+)['. PREG_CLASS_PUNCTUATION .']+(?=['. PREG_CLASS_NUMBERS .'])/u', '\1', $text); - - // The dot, underscore and dash are simply removed. This allows meaningful - // search behaviour with acronyms and URLs. - $text = preg_replace('/[._-]+/', '', $text); - - // With the exception of the rules above, we consider all punctuation, - // marks, spacers, etc, to be a word boundary. - $text = preg_replace('/['. PREG_CLASS_SEARCH_EXCLUDE . ']+/u', ' ', $text); - - // Process words - $words = explode(' ', $text); - - // Save last keyword result - $last = $text; - $lastsplit = $words; - - return $words; + return; } /** - * Invokes hook_search_preprocess() in modules. - */ -function search_preprocess(&$text) { - static $modules = null; - // Cache list of modules which implement this hook. This function gets called - // a lot during reindexing. - if (!is_array($modules)) { - $modules = array(); - foreach (module_list() as $module) { - if (module_hook($module, 'search_preprocess')) { - $modules[] = $module; - } - } - } - // Process $text - if (count($modules) > 0) { - foreach ($modules as $module) { - $text = module_invoke($module, 'search_preprocess', $text); - } - } - } - - - /** - * Update the search index for a particular item. - * - * @param $sid - * A number identifying this particular item (e.g. node id). - * - * @param $type - * A string defining this type of item (e.g. 'node') - * - * @param $text - * The content of this item. Must be a piece of HTML text. - */ -function search_index($sid, $type, $text) { - $minimum_word_size = variable_get('minimum_word_size', 3); - - global $base_url; - $node_regexp = '!href=[\'"]?(?:'. preg_quote($base_url) .'/)?(?:\?q=)?([^\'">]+)[\'">]!i'; - - // Multipliers for scores of words inside certain HTML tags. - // Note: 'a' must be included for link ranking to work. - $tags = array('h1' => 21, - 'h2' => 18, - 'h3' => 15, - 'h4' => 12, - 'h5' => 9, - 'h6' => 6, - 'u' => 5, - 'b' => 5, - 'strong' => 5, - 'em' => 5, - 'a' => 10); - - // Strip off all ignored tags to speed up processing, but insert space before/after - // them to keep word boundaries. - $text = str_replace(array('<', '>'), array(' <', '> '), $text); - $text = strip_tags($text, '<'. implode('><', array_keys($tags)) .'>'); - - // Split HTML tags from plain text. - $split = preg_split('/\s*<([^>]+?)>\s*/', $text, -1, PREG_SPLIT_DELIM_CAPTURE); - // Note: PHP ensures the array consists of alternating delimiters and literals - // and begins and ends with a literal (inserting $null as required). - - $tag = false; // Odd/even counter. Tag or no tag. - $link = false; // State variable for link analyser - $score = 1; // Starting score per word - - $results = array(0 => array()); - - foreach ($split as $value) { - if ($tag) { - // Increase or decrease score per word based on tag - list($tagname) = explode(' ', $value, 2); - $tagname = strtolower($tagname); - if ($tagname{0} == '/') { - $score -= $tags[substr($tagname, 1)]; - if ($score < 1) { // possible due to bad HTML - $score = 1; - } - if ($tagname == '/a') { - $link = false; - } - } - else { - if ($tagname == 'a') { - // Check if link points to a node on this site - if (preg_match($node_regexp, $value, $match)) { - $path = drupal_get_normal_path($match[1]); - if (preg_match('!(node|book)/(?:view/)?([0-9]+)!i', $path, $match)) { - $linknid = $match[1]; - if ($linknid > 0) { - $link = true; - } - } - } - } - $score += $tags[$tagname]; - } - } - else { - // Note: use of PREG_SPLIT_DELIM_CAPTURE above will introduce empty values - if ($value != '') { - $words = search_keywords_split($value); - foreach ($words as $word) { - // Check wordlength - if (string_length($word) >= $minimum_word_size) { - $word = strtolower($word); - if ($link) { - if (!isset($results[$linknid])) { - $results[$linknid] = array(); - } - $results[$linknid][$word] += $score; - } - else { - $results[0][$word] += $score; - } - } - } - } - } - $tag = !$tag; - } - - db_query("DELETE FROM {search_index} WHERE sid = %d AND type = '%s'", $sid, $type); - search_wipe($sid, $type); - - // Insert results into search index - foreach ($results[0] as $word => $score) { - db_query("INSERT INTO {search_index} (word, sid, type, score) VALUES ('%s', %d, '%s', %d)", $word, $sid, $type, $score); - search_dirty($word); - } - unset($results[0]); - - // Now insert links to nodes - foreach ($results as $nid => $words) { - foreach ($words as $word => $score) { - db_query("INSERT INTO {search_index} (word, sid, type, fromsid, fromtype, score) VALUES ('%s', %d, '%s', %d, '%s', %d)", $word, $nid, 'node', $sid, $type, $score); - search_dirty($word); - } - } - } - - /** * Perform a search on a word or words. * - * This function is called by each module that supports the indexed search. + * This function is called by each node that supports the indexed search. * - * The end result is an SQL select on the search_index table. As a guide for - * writing the optional extra SQL fragments (see below), use this query: - * - * SELECT i.type, i.sid, i.word, SUM(i.score/t.count) AS score - * FROM {search_index} i - * $join INNER JOIN {search_total} t ON i.word = t.word - * WHERE $where AND (i.word = '...' OR ...) - * GROUP BY i.type, i.sid - * ORDER BY score DESC"; - * - * @param $keys - * A search string as entered by the user. - * - * @param $type - * A string identifying the calling module. - * - * @param $join - * (optional) A string to be inserted into the JOIN part of the SQL query. - * For example "INNER JOIN {node} n ON n.nid = i.sid". - * - * @param $where - * (optional) A string to be inserted into the WHERE part of the SQL query. - * For example "(n.status > 0)". + * @param $search_array + * An array as returned from hook_search(). The format of this array is + * array('keys' => ..., 'type' => ..., 'select' => ...). See the hook_search() + * documentation for an explanation of the array values. * * @return - * An array of SIDs for the search results. - */ -function do_search($keys, $type, $join = '', $where = '1') { - // Note, we replace the wildcards with U+FFFD (Replacement character) to pass - // through the keyword extractor. - $keys = str_replace('*', '�', $keys); - - // Split into words - $keys = search_keywords_split($keys); - // Lowercase - foreach ($keys as $k => $v) { - $keys[$k] = strtolower($v); - } - - $words = array(); - $arguments = array(); - // Build WHERE clause - foreach ($keys as $word) { - if (string_length($word) < variable_get('remove_short', 3)) { - continue; - } - if (strpos($word, '�') !== false) { - $words[] = "i.word LIKE '%s'"; - $arguments[] = str_replace('�', '%', $word); - } - else { - $words[] = "i.word = '%s'"; - $arguments[] = $word; - } - } - if (count($words) == 0) { - return array(); - } - $where .= ' AND ('. implode(' OR ', $words) .')'; + * An array of search results, of which each element is an array with the + * keys "count", "title", "link", "user" (name), "date", and "keywords". + */ +function do_search($search_array) { - // Get result count (for pager) - $count = db_result(db_query("SELECT COUNT(DISTINCT i.sid, i.type) FROM {search_index} i $join WHERE $where", $arguments)); - if ($count == 0) { - return array(); - } - $count_query = "SELECT $count"; + $keys = strtolower($search_array['keys']); + $type = $search_array['type']; + $select = $search_array['select']; - // Do pager query - $query = "SELECT i.type, i.sid, i.word, SUM(i.score/t.count) AS score FROM {search_index} i $join INNER JOIN {search_total} t ON i.word = t.word WHERE $where GROUP BY i.type, i.sid ORDER BY score DESC"; - $arguments = array_merge(array($query, 15, 0, $count_query), $arguments); - $result = call_user_func_array('pager_query', $arguments); - - $results = array(); - while ($item = db_fetch_object($result)) { - $results[] = $item->sid; - } + // Remove punctuation/special characters (same rule as update_index()). + $keys = preg_replace("'(!|%|,|:|;|\(|\)|\&|\"|\'|\.|-|\/|\?|\\\)'", '', $keys); - return $results; -} + // Replace wildcards with MySQL wildcards. + $keys = str_replace('*', '%', $keys); -/** - * Menu callback; presents the search form and/or search results. - */ -function search_view() { - $keys = isset($_GET['keys']) ? $_GET['keys'] : $_POST['edit']['keys']; - $type = isset($_GET['type']) ? $_GET['type'] : ($_POST['edit']['type'] ? $_POST['edit']['type'] : 'node'); + // Split the words entered into an array. + $words = explode(' ', $keys); - if (user_access('search content')) { + foreach ($words as $word) { - // Only perform search if there is non-whitespace search term: - if (trim($keys)) { - // Log the search keys: - watchdog('search', - t('Search: %keys (%type).', array('%keys' => "$keys", '%type' => module_invoke($type, 'search', 'name'))), - l(t('results'), 'search', NULL, 'keys='. urlencode($keys) . '&type='. urlencode($type)) - ); + // If the word is too short, and we've got it set to skip them, loop. + if (strlen($word) < variable_get('remove_short', 0)) { + continue; + } - // Collect the search results: - $results = search_data($keys, $type); + // Put the next search word into the query and do the query. + $query = str_replace("'%'", "'". check_query($word) ."'", $select); + $result = db_query($query); + + if (db_num_rows($result) != 0) { + // At least one matching record was found. + $found = 1; + + // Create an in memory array of the results. + while ($row = db_fetch_array($result)) { + $lno = $row['lno']; + $nid = $row['nid']; + $title = $row['title']; + $created = $row['created']; + $uid = $row['uid']; + $name = $row['name']; + $count = $row['count']; + + // Build reduction variable. + $reduction[$lno][$word] = true; + + // Check whether the just-fetched row is already in the table. + if ($results[$lno]['lno'] != $lno) { + $results[$lno]['count'] = $count; + + $results[$lno]['lno'] = $lno; + $results[$lno]['nid'] = $nid; + $results[$lno]['title'] = $title; + $results[$lno]['created'] = $created; + $results[$lno]['uid'] = $uid; + $results[$lno]['name'] = $name; + } + else { + // Different word, but existing "lno". Increase the count of + // matches against this "lno" by the number of times this + // word appears in the text. + $results[$lno]['count'] = $results[$lno]['count'] + $count; + } + } + } + } - if ($results) { - $results = theme('box', t('Search results'), $results); + if ($found) { + foreach ($results as $lno => $values) { + $pass = true; + foreach ($words as $word) { + if (!$reduction[$lno][$word]) { + $pass = false; + } } - else { - $results = theme('box', t('Your search yielded no results'), search_help('search#noresults')); + if ($pass) { + $fullresults[$lno] = $values; } } - else if (isset($_POST['edit'])) { - form_set_error('keys', t('Please enter some keywords.')); + $results = $fullresults; + if (!is_array($results)) { + $found = 0; + } + } + if ($found) { + // Black magic here to sort the results. + array_multisort($results, SORT_DESC); + + // Now, output the results. + foreach ($results as $key => $value) { + $lno = $value['lno']; + $nid = $value['nid']; + $title = $value['title']; + $created = $value['created']; + $uid = $value['uid']; + $name = $value['name']; + $count = $value['count']; + switch ($type) { + case 'node': + $find[$i++] = array('count' => $count, 'title' => $title, 'link' => url("node/$lno"), 'user' => $name, 'date' => $created, 'keywords' => implode('|', $words)); + break; + case 'comment': + $find[$i++] = array('count' => $count, 'title' => $title, 'link' => (strstr(request_uri(), 'admin') ? url("admin/comment/edit/$lno") : url("node/$nid", NULL, "comment-$lno")), 'user' => $name, 'date' => $created, 'keywords' => implode('|', $words)); + break; + break; + } } - - // Construct the search form. - // Note, we do this last because of the form_set_error() above. - $output = search_form(NULL, $keys, $type, TRUE); - - $output .= $results; - - print theme('page', $output, t('Search')); - } - else { - drupal_access_denied(); } + return $find; } /** - * Menu callback; prints the search engine help page. - */ -function search_help_page() { - print theme('page', search_help()); -} - -/** - * @defgroup search Search interface - * @{ - * The Drupal search interface manages a global search mechanism. + * Update the search_index table. * - * Modules may plug into this system to provide searches of different types of - * data. Most of the system is handled by search.module, so this must be enabled - * for all of the search features to work. + * @param $search_array + * An array as returned from hook_update_index(). */ +function update_index($search_array) { + $last_update = variable_get($search_array['last_update'], 1); + $node_type = $search_array['node_type']; + $select = $search_array['select']; + $minimum_word_size = variable_get('minimum_word_size', 2); -/** - * Render a search form. - * - * This form must be usable not only within "http://example.com/search", but also - * as a simple search box (without "Restrict search to", help text, etc.), in the - * theme's header, and so forth. This means we must provide options to - * conditionally render certain parts of this form. - * - * @param $action - * Form action. Defaults to "search". - * @param $keys - * The search string entered by the user, containing keywords for the search. - * @param $options - * Whether to render the optional form fields and text ("Restrict search - * to", help text, etc.). - * @return - * An HTML string containing the search form. - */ -function search_form($action = '', $keys = '', $type = null, $options = FALSE) { - $edit = $_POST['edit']; + //watchdog('user', "$last_update
$node_type
$select"); - if (!$action) { - $action = url('search'); - } + $result = db_query($select); - $output = '
'; - $box = '
'; - $box .= form_textfield('', 'keys', $keys, 40, 255); - $box .= form_submit(t('Search'));; - $box .= '
'; - $output .= form_item(t('Enter your keywords'), $box); + if (db_num_rows($result)) { + // Results were found. Look through the nodes we just selected. + while ($node = db_fetch_array ($result)) { - if ($options) { - $output .= '
'. t('Search for') .': '; + // Trash any existing entries in the search index for this node, + // in case it is a modified node. + db_query("DELETE from {search_index} WHERE lno = '". $node['lno'] ."' AND type = '". $node_type ."'"); - if (!isset($edit['type'])) { - $edit['type'] = $type; - } + // Build the word list (teaser not included, as it would give a + // false count of the number of hits). + $wordlist = $node['text1'] .' '. $node['text2']; - foreach (module_list() as $name) { - if (module_hook($name, 'search')) { - $output .= form_radio(module_invoke($name, 'search', 'name'), 'type', $name, $edit['type'] == $name); - } - } - $output .= '
'; - } - else if ($type) { - $output .= form_hidden('type', $type); - } - $output .= '
'; + // Strip heaps of stuff out of it. + $wordlist = preg_replace("'<[\/\!]*?[^<>]*?>'si", '', $wordlist); - return form($output, 'post', $action); -} + // Remove punctuation/special characters (same rule as do_search()). + $keys = preg_replace("'(!|%|,|:|;|\(|\)|\&|\"|\'|\.|-|\/|\?|\\\)'", '', $keys); -/** - * Perform a search on the given keys, and return the formatted results. - */ -function search_data($keys = NULL, $type = 'node') { - $output = ''; + // Strip out (now mangled) http and tags. + $wordlist = preg_replace("'http\w+'", '', $wordlist); + $wordlist = preg_replace("'www\w+'", '', $wordlist); - if (isset($keys)) { - if (module_hook($type, 'search')) { - $results = module_invoke($type, 'search', 'search', $keys); - if (is_array($results) && count($results)) { - $output .= '
'; - foreach ($results as $entry) { - $output .= theme('search_item', $entry, $type); - } - $output .= '
'; - $output .= theme('pager', NULL, 15, 0, array('keys' => $keys, 'type' => $type)); + // Remove all newlines of any type. + $wordlist = preg_replace("'([\r\n]|[\r]|[\n])'", ' ', $wordlist); + + // Lower case the whole thing. + $wordlist = strtolower($wordlist); + + // Remove "noise words". + $noise = explode(',', variable_get('noisewords', '')); + foreach ($noise as $word) { + $word = trim($word); + $wordlist = trim(preg_replace("' $word '", ' ', ' ' .$wordlist. ' ')); } - } - } - return $output; -} + // Remove whitespace. + $wordlist = preg_replace("'[\s]+'", ' ', $wordlist); -/** - * @} End of "defgroup search". - */ + // Make it an array. + $eachword = explode(' ', $wordlist); -/** - * Returns snippets from a piece of text, with certain keywords highlighted. - * Used for formatting search results. - * - * @param $keys - * A string containing keywords. They are split into words using the same - * rules as search indexing. - * - * @param $text - * The text to extract fragments from. - * - * @return - * A string containing HTML for the excerpt. - */ -function search_excerpt($keys, $text) { - $keys = search_keywords_split($keys); - $text = strip_tags(str_replace(array('<', '>'), array(' <', '> '), $text)); - - // Extract a fragment per keyword for at most 4 keywords. - // First we collect ranges of text around each keyword, starting/ending - // at spaces. - // If the fragment is too short, we look for second occurences. - $ranges = array(); - $included = array(); - $length = 0; - while ($length < 256) { - foreach ($keys as $k => $key) { - if (strlen($key) == 0) { - unset($keys[$k]); - continue; - } - if ($length >= 256) { - break; - } - // Remember occurence of key so we can skip over it if more occurences - // are desired. - if (!isset($included[$key])) { - $included[$key] = 0; - } - // Note: workaround for lack of stripos() in PHP4 - if (($p = strpos($text, stristr(substr($text, $included[$key]), $key), $included[$key])) !== false) { - if (($q = strpos($text, ' ', max(0, $p - 60))) !== false) { - $end = substr($text, $p, 80); - if (($s = strrpos($end, ' ')) !== false) { - $ranges[$q] = $p + $s; - $length += $p + $s - $q; - $included[$key] = $p + 1; + // Walk through the array, giving a "weight" to each word based on + // the number of times it appears in a page. + foreach ($eachword as $word) { + if (strlen($word) >= $minimum_word_size && strlen($word) <= 50) { + if ($newwords[$word]) { + $newwords[$word]++; } else { - unset($keys[$k]); + $newwords[$word] = 1; } } - else { - unset($keys[$k]); - } } - else { - unset($keys[$k]); + + // Walk through the weighted words array, inserting them into + // the search index. + if ($newwords) { + foreach ($newwords as $key => $value) { + db_query("INSERT INTO {search_index} VALUES('%s', %d, '%s', %d)", $key, $node['lno'], $node_type, $value); + } } - } - // If we didn't find anything, return the beginning. - if (count($ranges) == 0 || count($keys) == 0) { - return truncate_utf8($text, 256) . ' ...'; + // Reset the weighted words array, so we don't add multiples. + $newwords = array (); } } - // Sort the text ranges by starting position. - ksort($ranges); + // Update the last time this process was run. + variable_set($search_array['last_update'], time()); - // Now we collapse overlapping text ranges into one. The sorting makes it O(n). - $newranges = array(); - foreach ($ranges as $from2 => $to2) { - if (!isset($from1)) { - $from1 = $from2; - $to1 = $to2; - continue; - } - if ($from2 <= $to1) { - $to1 = max($to1, $to2); - } - else { - $newranges[$from1] = $to1; - $from1 = $from2; - $to1 = $to2; + return true; +} + + +function search_invalidate() { + foreach (module_list() as $module) { + $module_array = module_invoke($module, 'update_index'); + if ($module_array) { + variable_set($module_array['last_update'], 1); } + $module_array = null; } - $newranges[$from1] = $to1; - - // Fetch text - $out = array(); - foreach ($newranges as $from => $to) { - $out[] = substr($text, $from, $to - $from); - } - $text = '... '. implode(' ... ', $out) .' ...'; - - // Highlight keywords. Must be done at once to prevent conflicts ('strong' and ''). - array_walk($keys, '_search_excerpt_replace'); - $text = preg_replace('/('. implode('|', $keys) .')/i', '\0', $text); - return $text; + return; } /** - * Helper function for array_walk in search_except. + * Save the values entered by the administrator for the search module + * + * @param $edit + * An array of fields as set up by calling form_textfield(), + * form_textarea(), etc. */ -function _search_excerpt_replace($text) { - return preg_quote($text); +function search_save($edit) { + variable_set('minimum_word_size', $edit['minimum_word_size']); + + $data = strtr($edit['noisewords'], "\n\r\t", ' '); + $data = str_replace(' ', '', $data); + variable_set('noisewords', $data); + variable_set('help_pos', $edit['help_pos']); + variable_set('remove_short', $edit['remove_short']); } /** - * Format a single result entry of a search query. - * - * Modules may implement hook_search_item() in order to override this default - * function to display search results. - * - * @param $item - * A single search result as returned by hook_search(). The result should be - * an array with keys "count", "link", "title", "user", "date", and "keywords". - * @param $type - * The type of item found, such as "user" or "comment". - */ -function theme_search_item($item, $type) { - if (module_hook($type, 'search_item')) { - $output = module_invoke($type, 'search_item', $item); - } - else { - $output = '
'. $item['title'] .'
'; - $info = array(); - if ($item['type']) { - $info[] = $item['type']; - } - if ($item['user']) { - $info[] = $item['user']; - } - if ($item['date']) { - $info[] = format_date($item['date'], 'small'); + * Menu callback; presents the search form and/or search results. + */ +function search_view() { + global $type; + $keys = isset($_GET['keys']) ? $_GET['keys'] : $_POST['keys']; + + if (user_access('search content')) { + // Construct the search form. + $output = search_form(NULL, $keys, TRUE); + + // Display form and search results. + $help_link = l(t('search help'), 'search/help'); + switch (variable_get('help_pos', 1)) { + case '1': + $output = search_help(). $output .'
'; + break; + case '2': + $output .= search_help() .'
'; + break; + case '3': + $output = $help_link. '
'. $output .'
'; + break; + case '4': + $output .= '
'. $help_link .'
'; } - if (isset($item['extra'])) { - $info[] = $item['extra']; + + // Only perform search if there is non-whitespace search term: + if (trim($keys)) { + // Log the search keys: + watchdog('search', t('Search: %keys.', array('%keys' => "$keys")), l(t('results'), 'search', NULL, 'keys='. urlencode($keys))); + + // Collect the search results: + $results = search_data($keys); + + if ($results) { + $output .= theme('box', t('Search Results'), $results); + } + else { + $output .= theme('box', t('Search Results'), t('Your search yielded no results.')); + } } - $output .= '
'. ($item['snippet'] ? '

'. $item['snippet'] . '

' : '') . '

' . implode(' - ', $info) .'

'; + + print theme('page', $output, t('Search')); + } + else { + drupal_access_denied(); } - return $output; } +/** + * Menu callback; prints the search engine help page. + */ +function search_help_page() { + print theme('page', search_help()); +} ?> diff -ur ./modules/taxonomy.module /root/drupal-4.5.1/modules/taxonomy.module --- ./modules/taxonomy.module Sat Dec 11 14:38:36 2004 +++ /root/drupal-4.5.1/modules/taxonomy.module Mon Nov 29 06:53:46 2004 @@ -106,11 +106,7 @@ $result = db_query("SELECT d.tid, d.name, MAX(n.created) AS updated, COUNT(*) AS count FROM {term_data} d INNER JOIN {term_node} USING (tid) INNER JOIN {node} n USING (nid) WHERE n.status = 1 GROUP BY d.tid, d.name ORDER BY updated DESC, d.name"); $items = array(); while ($category = db_fetch_object($result)) { - if (function_exists('taxonomy_access')) { - if (taxonomy_access('view',$category->tid)) - $items[] = l($category->name .' ('. $category->count .')', 'taxonomy/term/'. $category->tid) .'
'. t('%time ago', array('%time' => format_interval(time() - $category->updated))); - } else // if taxonomy_access isn't installed - $items[] = l($category->name .' ('. $category->count .')', 'taxonomy/term/'. $category->tid) .'
'. t('%time ago', array('%time' => format_interval(time() - $category->updated))); + $items[] = l($category->name .' ('. $category->count .')', 'taxonomy/term/'. $category->tid) .'
'. t('%time ago', array('%time' => format_interval(time() - $category->updated))); } $block['subject'] = t('Categories'); @@ -385,7 +381,7 @@ $blank = '<'. t('none') .'>'; } - return _taxonomy_term_select($vocabulary->name, $name, $value, $vid, $help, intval($vocabulary->multiple), $blank, array(),'create'); + return _taxonomy_term_select($vocabulary->name, $name, $value, $vid, $help, intval($vocabulary->multiple), $blank); } /** @@ -415,11 +411,7 @@ function taxonomy_node_form($type, $node = '', $help = NULL, $name = 'taxonomy') { if (!$node->taxonomy) { if ($node->nid) { - if (function_exists('taxonomy_access')) { - $terms = array_keys(taxonomy_node_get_terms($node->nid,'tid','create')); - } else { - $terms = array_keys(taxonomy_node_get_terms($node->nid)); - } + $terms = array_keys(taxonomy_node_get_terms($node->nid)); } else { $terms = 0; @@ -440,9 +432,6 @@ * Determine whether a node mentions the name of a term. */ function taxonomy_node_has_term($nid, $tid) { - if (function_exists('taxonomy_access')) - if (!taxonomy_access('view',$tid)) - return FALSE; $term_name = db_result(db_query('SELECT name FROM {term_data} WHERE tid = %d', $tid)); return db_result(db_query("SELECT COUNT(n.nid) FROM {node} n WHERE n.nid = %d AND ((n.title LIKE '%%%s%%') OR (n.body LIKE '%%%s%%'))", $nid, $term_name, $term_name)); @@ -451,14 +440,11 @@ /** * Find all terms associated to the given node, within one vocabulary. */ -function taxonomy_node_get_terms_by_vocabulary($nid, $vid, $key = 'tid', $access = 'view') { +function taxonomy_node_get_terms_by_vocabulary($nid, $vid, $key = 'tid') { $result = db_query('SELECT t.* FROM {term_data} t, {term_node} r WHERE t.tid = r.tid AND t.vid = %d AND r.nid = %d ORDER BY weight', $vid, $nid); $terms = array(); while ($term = db_fetch_object($result)) { - if (function_exists('taxonomy_access')) { - if (taxonomy_access($access,$term->tid)) - $terms[$term->$key] = $term; - } else $terms[$term->$key] = $term; + $terms[$term->$key] = $term; } return $terms; } @@ -466,17 +452,13 @@ /** * Find all terms associated to the given node. */ -function taxonomy_node_get_terms($nid, $key = 'tid', $access = 'view') { +function taxonomy_node_get_terms($nid, $key = 'tid') { static $terms; if (!isset($terms[$nid])) { $result = db_query('SELECT t.* FROM {term_data} t, {term_node} r WHERE r.tid = t.tid AND r.nid = %d ORDER BY weight, name', $nid); $terms[$nid] = array(); while ($term = db_fetch_object($result)) { - if (function_exists('taxonomy_access')) { - if (taxonomy_access($access,$term->tid)) - $terms[$nid][$term->$key] = $term; - } else $terms[$nid][$term->$key] = $term; $terms[$nid][$term->$key] = $term; } } @@ -492,10 +474,7 @@ if ($terms) { foreach ($terms as $term) { if ($term) { - if (function_exists('taxonomy_access')) { - if (taxonomy_access('create',$term)) - db_query('INSERT INTO {term_node} (nid, tid) VALUES (%d, %d)', $nid, $term); - } else db_query('INSERT INTO {term_node} (nid, tid) VALUES (%d, %d)', $nid, $term); + db_query('INSERT INTO {term_node} (nid, tid) VALUES (%d, %d)', $nid, $term); } } } @@ -516,10 +495,7 @@ $result = db_query('SELECT t.*, tid1, tid2 FROM {term_relation}, {term_data} t WHERE (t.tid = tid1 OR t.tid = tid2) AND (tid1 = %d OR tid2 = %d) AND t.tid != %d ORDER BY weight, name', $tid, $tid, $tid); $related = array(); while ($term = db_fetch_object($result)) { - if (function_exists('taxonomy_access')) { - if (taxonomy_access('view',$term->tid)) - $related[$term->$key] = $term; - } else $related[$term->$key] = $term; + $related[$term->$key] = $term; } return $related; } @@ -536,10 +512,7 @@ $result = db_query('SELECT t.* FROM {term_hierarchy} h, {term_data} t WHERE h.parent = t.tid AND h.tid = %d ORDER BY weight, name', $tid); $parents = array(); while ($parent = db_fetch_object($result)) { - if (function_exists('taxonomy_access')) { - if (taxonomy_access('view',$parent->tid)) - $parents[$parent->$key] = $parent; - } else $parents[$parent->$key] = $parent; + $parents[$parent->$key] = $parent; } return $parents; } @@ -576,10 +549,7 @@ } $children = array(); while ($term = db_fetch_object($result)) { - if (function_exists('taxonomy_access')) { - if (taxonomy_access('view',$term->tid)) - $children[$term->$key] = $term; - } else $children[$term->$key] = $term; + $children[$term->$key] = $term; } return $children; } @@ -604,42 +574,24 @@ * An array of all term objects in the tree. Each term object is extended * to have "depth" and "parents" attributes in addition to its normal ones. */ -function taxonomy_get_tree($vid, $parent = 0, $depth = -1, $max_depth = NULL, $access = 'view') { +function taxonomy_get_tree($vid, $parent = 0, $depth = -1, $max_depth = NULL) { static $children, $parents, $terms; $depth++; // We cache trees, so it's not CPU-intensive to call get_tree() on a term // and its children, too. - // pyromanfo: Cache based on user role and access - if (function_exists('taxonomy_access')) { - global $user; - if (isset($uid)) { - $user_object = user_load(array('uid' => $uid)); - } - else { - $user_object = $user; - } - $real_vid = $vid; - if (isset($user) && is_array($user->roles)) { - $vid = $vid.implode("','",array_keys($user_object->roles)).$access; - } else { - $vid = $vid.'1'.$access; - } - } else { - $real_vid = $vid; - } - if (!isset($children[$vid])) { $children[$vid] = array(); - $result = db_query('SELECT t.*, parent FROM {term_data} t, {term_hierarchy} h WHERE t.tid = h.tid AND t.vid = %d ORDER BY weight, name', $real_vid); + $result = db_query('SELECT t.*, parent FROM {term_data} t, {term_hierarchy} h WHERE t.tid = h.tid AND t.vid = %d ORDER BY weight, name', $vid); while ($term = db_fetch_object($result)) { $children[$vid][$term->parent][] = $term->tid; $parents[$vid][$term->tid][] = $term->parent; $terms[$vid][$term->tid] = $term; } } + $max_depth = (is_null($max_depth)) ? count($children[$vid]) : $max_depth; if ($children[$vid][$parent]) { foreach ($children[$vid][$parent] as $child) { @@ -650,22 +602,11 @@ $terms[$vid][$child]->parents = $parents[$vid][$child]; $tree[] = $terms[$vid][$child]; - $tree = array_merge($tree, taxonomy_get_tree($real_vid, $child, $depth, $max_depth, $access)); + $tree = array_merge($tree, taxonomy_get_tree($vid, $child, $depth, $max_depth)); } } } - // strip out entries where the user doesn't have proper access - if (function_exists('taxonomy_access') && is_array($tree)) { - $newtree = array(); - foreach ($tree as $term) { - if (taxonomy_access($access,$term->tid)) { - $newtree[] = $term; - } - } - $tree = $newtree; - } - return $tree ? $tree : array(); } @@ -726,10 +667,7 @@ if (!isset($children)) { $result = db_query('SELECT tid, parent FROM {term_hierarchy}'); while ($term = db_fetch_object($result)) { - if (function_exists('taxonomy_access')) { - if (taxonomy_access('view',$term->tid)) - $children[$term->parent][] = $term->tid; - } else $children[$term->parent][] = $term->tid; + $children[$term->parent][] = $term->tid; } } return $children[$tid] ? $children[$tid] : array(); @@ -773,10 +711,7 @@ $db_result = db_query("SELECT * FROM {term_data} WHERE LOWER('%s') LIKE LOWER(name)", trim($name)); $result = array(); while ($term = db_fetch_object($db_result)) { - if (function_exists('taxonomy_access')) { - if (taxonomy_access('view',$term->tid)) - $result[] = $term; - } else $result[] = $term; + $result[] = $term; } return $result; @@ -793,15 +728,12 @@ * Return the term object matching a term ID. */ function taxonomy_get_term($tid) { - if (function_exists('taxonomy_access')) - if (!taxonomy_access('view',$tid)) - return FALSE; // simple cache using a static var? return db_fetch_object(db_query('SELECT * FROM {term_data} WHERE tid = %d', $tid)); } -function _taxonomy_term_select($title, $name, $value, $vocabulary_id, $description, $multiple, $blank, $exclude = array(), $access = 'view') { - $tree = taxonomy_get_tree($vocabulary_id,0,-1,NULL,$access); +function _taxonomy_term_select($title, $name, $value, $vocabulary_id, $description, $multiple, $blank, $exclude = array()) { + $tree = taxonomy_get_tree($vocabulary_id); if ($blank) { $options[] = array('tid' => 0, 'name' => $blank); } @@ -961,19 +893,6 @@ } else { drupal_not_found(); - } - - if (function_exists('taxonomy_access')) { - $access_tids = array(); - foreach($tids as $tid) - if (taxonomy_access('view',$tid)) - $access_tids[] = $tid; - if ($access_tids) - $tids = $access_tids; - else { - drupal_access_denied(); - return; - } } if ($tids) { diff -ur ./modules/user.module /root/drupal-4.5.1/modules/user.module --- ./modules/user.module Sun Dec 12 11:15:41 2004 +++ /root/drupal-4.5.1/modules/user.module Mon Nov 29 11:59:50 2004 @@ -431,20 +431,17 @@ /** * Implementation of hook_search(). */ -function user_search($op = 'search', $keys = null) { - switch ($op) { - case 'name': - return t('users'); - case 'search': - $find = array(); - // Replace wildcards with MySQL/PostgreSQL wildcards. - $keys = str_replace('*', '%', $keys); - $result = db_query_range("SELECT * FROM {users} WHERE LOWER(name) LIKE '%%%s%%'", strtolower($keys), 0, 20); - while ($account = db_fetch_object($result)) { - $find[] = array('title' => $account->name, 'link' => url("user/$account->uid/view")); - } - return $find; +function user_search($keys) { + $find = array(); + + // Replace wildcards with MySQL/PostgreSQL wildcards. + $keys = str_replace('*', '%', $keys); + + $result = db_query_range("SELECT * FROM {users} WHERE LOWER(name) LIKE '%%%s%%'", strtolower($keys), 0, 20); + while ($account = db_fetch_object($result)) { + $find[] = array('title' => $account->name, 'link' => url("user/$account->uid/view"), 'user' => $account->name); } + return array(t('Matching users'), $find); } /** @@ -1593,8 +1590,7 @@ switch ($op) { case 'search': - case t('Search'): - $output = search_form(url('admin/user/search'), $_POST['edit']['keys'], 'user') . search_data($_POST['edit']['keys'], 'user'); + $output = search_type('user', url('admin/user/search'), $_POST['keys']); break; case t('Create account'): case 'create': diff -ur ./themes/bluemarine/xtemplate.xtmpl /root/drupal-4.5.1/themes/bluemarine/xtemplate.xtmpl --- ./themes/bluemarine/xtemplate.xtmpl Sun Dec 12 11:15:41 2004 +++ /root/drupal-4.5.1/themes/bluemarine/xtemplate.xtmpl Sun Nov 14 13:35:02 2004 @@ -34,7 +34,7 @@
diff -ur ./themes/pushbutton/xtemplate.xtmpl /root/drupal-4.5.1/themes/pushbutton/xtemplate.xtmpl --- ./themes/pushbutton/xtemplate.xtmpl Sun Dec 12 11:15:41 2004 +++ /root/drupal-4.5.1/themes/pushbutton/xtemplate.xtmpl Thu Sep 9 08:36:01 2004 @@ -50,7 +50,7 @@