Bartik comment submit form is a bit janky.

This is pretty much a duplicate of #845728: Improve Bartik's display of forms , which was moved to D8 so it went off the radar...

I think trying to fix these issues for forms in lots of little issues is going to result in lots of special cased CSS without attacking the really big picture - if form elements had robust CSS default's we don't need any special casing such as for one form. That is what #845728: Improve Bartik's display of forms was supposed to be all about. I would very much favour simple killing these individual issues and hammering it all in one big patch (this has worked very well in the past where we had some huge patches for fixing the header, font sizing and other things).

Regarding the patch:

font-size: 85%;

This should be in em's, post font size rewrite patch everything uses em's and proper font scaling.

OK, no argument from me Jen, I think we'll find some more form/field issues so I brought #845728 back to D7 to run like a bit of a meta issue.

I know in past when I have added or removed fields from comments things did not go so well, it would be worth us checking with many added fields/re-ordering the fields and so on.

Tested this on Chromium 10.0.617.0 and Firefox 3.6.13 on Linux. See the attached screenshots.

RTBC from me pending IE testing.

IE6-IE9 all OK

forgot to set status

Needs work, this is a good start but needs more:

1. Vertical alignment of the labels to input / user name (logged in) are not aligned well, this looks terrible.
2. When logged in the user name is still misaligned to the following input field.
3. NO % font sizes, these result in wrongly scaled text, 85% should be 0.857em (12px exact).
4. The "more information about text formats" is misaligned to the icon, it should be centered vertically

If no one picks this up by the end of the day I'll get it done, also we need screen-shots with lots more fields added to comment forms, again this is critical, when I did this previously the forms looks horrific.

Here is what I mean about extra fields not working in this form - there is no accounting for other field types, which is really bad, I think this is exactly how people will use comments in Drupal 7 and they should at least be usable, whereas this is just a mess.

Lets have a crack with this patch, I have added all sorts of fields and make account for them (RTL also) everything looks good in IE6/7/8, however the file field input is borked in IE7 (it was like this before the patch, but I ran out of debug time).

I took a different approach for the text field lengths - setting these in pixels depending on the sidebar configuration, this could run into trouble if someone sticks comments in a block (we could account for that also).

This is not prefect, but its a hell of lot better than the current situation which is pretty woeful.

+++ themes/bartik/css/style.css	4 Jan 2011 03:56:22 -0000
@@ -1144,6 +1147,19 @@
+    font-size: 0.857em;
+    padding: 2px 20px 0;
+}
+.filter-wrapper .form-item label {
+    margin-right: 10px;
+}
+.filter-wrapper .form-item {
+    padding: 0 0 0.5em 0.5em;
+}
+.filter-guidelines {
+    padding: 0 1.5em 0 0.5em;

Wrong number of spaces. Not a big deal, but if it needs a re-roll...

+++ themes/bartik/css/style.css	4 Jan 2011 03:56:22 -0000
@@ -1318,28 +1334,58 @@
+  font-family: Georgia, "Times New Roman", Times, serif;

Would this be worth moving to the only other similar font-family declaration? (body, #site-slogan, .ui-widget)

Otherwise, I'm okay with this patch. I just hope it's not too late!

Powered by Dreditor.

Good spotting Tim, fixed the spaces (dam copy/past from firebug...) and moved the font family.

Yes! Awesome.

Committed to CVS HEAD. Thanks.