Hi there,
Thanks for a great module.
I updated to the latest version of devel today and found a number of warning for your module.

notice: Undefined variable: moderator_types in antispam_menu() (line 453 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>
notice: Undefined variable: moderator_types in antispam_menu() (line 467 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>
notice: Undefined variable: moderator_types in antispam_menu() (line 477 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>
notice: Undefined variable: moderator_types in antispam_menu() (line 487 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>
notice: Undefined variable: moderator_types in antispam_menu() (line 497 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>
notice: Undefined variable: moderator_types in antispam_menu() (line 507 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>
notice: Undefined variable: moderator_types in antispam_menu() (line 517 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>
notice: Undefined variable: moderator_types in antispam_menu() (line 527 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>
notice: Undefined variable: moderator_types in antispam_menu() (line 537 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>
notice: Undefined variable: moderator_types in antispam_menu() (line 547 of /vpfa-dev/hr_drupal6_template/sites/all/modules/antispam/antispam.module). =>

I asked about it in devel issues and found out that

"notice: Undefined variable" used to be ignored, but it's good practice to always give your variables a value before referencing them; these notices often point to bugs, and that's why we're not suppressing them anymore.

ref: http://drupal.org/node/1000490#comment-3837610

Comments

pixture’s picture

pixture commented

Thanks for the information.
I found what's wrong. I will fix this within a few days.
Meanwhile, if you want to avoid these warning messages, add the following line to antispam.module file.

/**
 * Implementation of hook_menu().
 */
function antispam_menu() {
  $items = array();
  $moderator_types = antispam_get_moderator_types(); // <----- add this line!!!
_vid’s picture

_vid commented

That's awesome.

Thanks.

Vid

cfinke’s picture

cfinke commented
Status: Active » Fixed

This appears to have been fixed at some point. Closing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.