Is this an issue? I was noticing that when I'm on PHP 5 the $node returned by node_submit($node) is the same object instance.

$node = node_load(89);
// Do something here
node_validate($node);
dpr((string)$node);
$node = node_submit($node);
dpr((string)$node);
node_save($node);

// Prints the same Object id for both

With this issue (http://drupal.org/node/86842) going in, should we look at the node_submit() case too?

Comments

RobRoy’s picture

RobRoy commented

I'm not suggesting we blindly clone it, I just am not sure if this could result in a problem on PHP5. Wanted some input.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Closed (works as designed)

Why should it clone the node object? It should be modifying the object passed.