With Drupal 7's new method of aggregating Javascript, JS files loaded by modules default to being separated from each other, increasing the number of JS files on the page. The developers recommend setting "every_page" to TRUE for module JS that appears on every page. I have made a small patch to set this correctly for extlink, reducing the total number of JS files on the page.

CommentFileSizeAuthor
#4 extlink_aggregate2.patch1.04 KBquicksketch
#1 extlink_js_everypage.patch486 bytesmamarley

Comments

mamarley’s picture

mamarley commented
StatusFileSize
new extlink_js_everypage.patch486 bytes

Oops!

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Needs review

Thanks, more API changes from D7... I'll review it next time I'm working on External Links.

quicksketch’s picture

quicksketch
he/him
commented
Category: feature » bug
Status: Needs review » Fixed

Thanks, doesn't break anything, gets aggregated like it should. After applying your patch I realized that we should do the same thing for the CSS file (of course), just a few lines down. This patch applies on top of yours and I've committed both to CVS.

quicksketch’s picture

quicksketch
he/him
commented
StatusFileSize
new extlink_aggregate2.patch1.04 KB

The patch mentioned in #3.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.