Menu name change in D7 not ported to Nice Menus [#1002054]

Comment	File	Size	Author
#9	1002054-D7_menu_name_changes.patch	7.21 KB	amateescu

#8	1002054.patch	4.59 KB	alpritt

#7	1002054.patch	4.59 KB	alpritt

	menu_names.patch	1.1 KB	botris

Comment #1

Dutch

Creuse, France

CreditAttribution: botris commented 18 December 2010 at 16:35

You may also want to consider changing the function name from:
theme_nice_menus_primary_links()
to
theme_nice_menus_main_menu()

for consistency.

Log in or register to post comments

Comment #2

vordude CreditAttribution: vordude commented 4 January 2011 at 02:29

Both good calls.

However, looked at a fresh install from HEAD, and found the variable named, menu_main_links_source (Not menu_main_menu_source as suggested in the patch)

Log in or register to post comments

Comment #3

r4f CreditAttribution: r4f commented 6 January 2011 at 23:00

I don't know... I still can't make it work... Installed the newest stable D7, tried all the suggestions here (except changing the functions name since it is irrelevent right now).... still it says:

Notice: Undefined index: content in theme_nice_menus_primary_links() (line 556 of /.../sites/all/modules/nice_menus/nice_menus.module).

Log in or register to post comments

Comment #4

botris

Dutch

Creuse, France

CreditAttribution: botris commented 10 January 2011 at 08:42

@Vordude your right, I found that too in HEAD. But I'm a bit confused, the theme layer uses main_menu according to the documentation:
http://drupal.org/update/theme/6/7#menus

So should it be?
$menu_name = variable_get('menu_main_links_source', 'main-menu');

@R4f , can't tell patch works for me.
Do you use the following in your page.tpl.php:
print theme('nice_menus_primary_links');
You need to use the "old" function name.

Log in or register to post comments

Comment #6

chules CreditAttribution: chules commented 11 February 2011 at 20:43

Where exactly in the page.tpl.php is the call to the menu? I am looking to replace it with print theme('nice_menus_primary_links'); but not sure which line(s) to replace.

thank you chules

Log in or register to post comments

Comment #7

alpritt CreditAttribution: alpritt commented 3 March 2011 at 21:14

File	Size
1002054.patch	4.59 KB

So should it be?
$menu_name = variable_get('menu_main_links_source', 'main-menu');

Yes.

This patch changes the function names and other references to primary and secondary links and fixes the above.

Log in or register to post comments

Comment #8

alpritt CreditAttribution: alpritt commented 3 March 2011 at 21:18

File	Size
1002054.patch	4.59 KB

Last patch missed a reference to 'primary links' in the README.

Log in or register to post comments

Comment #9

amateescu CreditAttribution: amateescu commented 27 June 2011 at 10:25

Version:

7.x-2.0-beta1

» 7.x-2.x-dev

File	Size
1002054-D7_menu_name_changes.patch	7.21 KB

Another re-roll for current HEAD which fixes the following:

- theme_nice_menus_main_menu() and theme_nice_menus_secondary_menu() should not receive a $menu variable because they already know what menu they're supposed to theme.
- removes deprecated D6 theme functions.
- fixes some Doxygen blocks that didn't have an empty line before the $return statement.

With this patch, printing the main menu is as simple as:

<?php
  print theme('nice_menus_main_menu');
?>

Log in or register to post comments

Comment #10

cesar.brod@gmail.com CreditAttribution: cesar.brod@gmail.com commented 9 July 2011 at 02:44

This worked fine for me. I haven't been able to figure out how to style the original rounded corners main menu you can see in Bartik though. Any hints?

Log in or register to post comments

Comment #11

JoelAddison CreditAttribution: JoelAddison commented 20 July 2011 at 02:40

Status:

Needs review

» Reviewed & tested by the community

Tested the patch in #9 against 7.x-2.0-beta3, and everything is working as expected. It would be great if this could be committed, as I am sure I am not the only one needing to patch this everytime a new version is released.