Thanks for this useful module, we've been using it for some time now.

With the 6.x-1.6 version the buttons no longer display text with & instead display & which the patch in #5 fixes but it has not been committed.

With the 7.x-1.0-beta1 version, the field "Text to use for Save & Edit button" does not support & character instead display &

Meanwhile the field "Text to use for default Save button" works fine.

CommentFileSizeAuthor
#13 save_edit-handle-special-characters-1002152-13.patch1.1 KBizmeez
#6 1002152-6-save_edit-special-characters.patch1.63 KBizmeez
#5 save_edit-1002152-5.patch2.04 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Reviewed & tested by the community

It was caused by the changes made here: http://drupal.org/cvs?commit=462646. The defaults were changed from "Save & Edit" to "Save and Edit", but that wouldn't current installations.

check_plain() is intended for user submitted values, not admin defined variables. It converts plain text to HTML, but can't be used on #value, which doesn't expect HTML.

This should be rolled back.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Bump.

mattwmc’s picture

mattwmc commented

I have the same problem.

Thanks.

*edited - just went into the admin settings and changed the '&' to 'and'

No big deal for me.

kahunacohen’s picture

kahunacohen commented

I would be willing to jump in and fix this, but I've never contributed before. Is anyone else working on this?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Version: 6.x-1.6 » 6.x-1.x-dev
StatusFileSize
new save_edit-1002152-5.patch2.04 KB

My reference to CVS in comment #1 now is unclear, here is the proper fix.

izmeez’s picture

izmeez commented
StatusFileSize
new 1002152-6-save_edit-special-characters.patch1.63 KB

tim, thanks for the patch in #5. I had to apply it manually to 6.x-1.6 and it seems to work to fix the problem. I have created a new patch that is attached.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Git now uses patches with prefixes, so to apply it would be patch -p1 < PATCHNAME.patch.

See the git instructions tab for each project on how to roll patches, that way it works with git am and contains patch author info.

izmeez’s picture

izmeez commented

Tim, Thanks for the reminder. I'll have to test that.

izmeez’s picture

izmeez commented

Tim, Yes you are absolutely correct the patch in #5 applies without any problem and works. The patch in #6 is old style and not needed. Thanks.

Izzy

izmeez’s picture

izmeez commented

+bump The patch in #5 works and restores the behavior of the module handling special characters as it did prior to 6.x-1.6 so might it be committed? Thanks.

izmeez’s picture

izmeez commented
Title: save_edit text to use for buttons no longer handles special characters » Text to use for Save & Edit button does not handle special characters
Version: 6.x-1.x-dev » 7.x-1.0-beta1
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Updating the issue to reflect problem on 7.x branch.

The field "Text to use for Save & Edit button" does not support & character, while the field "Text to use for default Save button" works fine.

izmeez’s picture

izmeez commented

Trying to hide patch file in comment #6. It is not needed.
It is hidden in issue summary but still appears in comment #6.

izmeez’s picture

izmeez commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new save_edit-handle-special-characters-1002152-13.patch1.1 KB

Here is a simple patch for 7.x-1.x based on comment #5.

nitinsp’s picture

nitinsp commented
Assigned: Unassigned » nitinsp
Status: Needs review » Reviewed & tested by the community
nitinsp’s picture

nitinsp commented

@izmeez #13 patch is working fine for me. Thanks for providing patch, Nice Work..

  • NitinSP committed 5b49a88 on 7.x-1.x authored by izmeez 
    Issue #1002152 by izmeez, tim.plunkett, NitinSP: Text to use for Save...
nitinsp’s picture

nitinsp commented
Assigned: nitinsp » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.