Closed (fixed)
Project:
Balance Tracker
Version:
6.x-1.10
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Dec 2010 at 01:36 UTC
Updated:
24 Jan 2011 at 15:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
sin commentedJust what I was thinking of :) Going to test it.
Comment #2
sin commentedFound a bug: the module cant be enabled due to recursive dependency in uc_balance_tracker.info file. A fixed one in the attachment.
Comment #3
sin commentedModule works fine, except it charges 1 credit for every $100 in the order even if I put 1 in UC Store Credit conversion rate at /admin/store/settings/payment/edit/methods
I'll debug it later.
I suggest adding more discriptive text + order page hyperlink to Balance Tracker payment message.
Comment #4
brianV commentedThis looks great - thanks for the work larowlan & sin.
I've given it a quick review, and I'll likely put it in dev once the bug mentioned in #3 is corrected.
@sin, I would appreciate it if you could follow up with #3 when you have a chance. I suspect that is more likely to be a bug in uc_store_credit.module than this one, but I don't want to fully release this code until it is corrected one way or the other. I would look at it myself, but my plate is far too full to get to that in a reasonable time frame.
Comment #5
sin commentedNevermind, I configured uc_store_credit.module incorrectly setting up fixed value 1 for product node type. Now all works fine.
Comment #6
larowlanThanks, had caught the recursion issue (it's supposed to be uc_store_credit as a dependency).
Re the 100/1 issue, not sure there, I've got it working properly on a site - it could be down to how uc_store_credit is configured?
Comment #7
sin commentedYes, I reconfigured uc_store_credit and now all is ok.
Comment #8
brianV commentedGood to hear.
I placed this module into D6 dev. thanks for the contribution!