Autosave does not recognise changes made in fields that have fckeditor enabled.

http://drupal.org/files/projects/fckeditor-5.x-1.1.tar.gz

CommentFileSizeAuthor
#10 autosave_fcksupport.diff607 bytesedmund.kwok

Comments

edmund.kwok’s picture

Version: 5.x-1.1 » 5.x-1.x-dev
Status: Active » Needs review

Hi mcm, thanks for reporting the bug. I've looked at the problem and see that FCKEditor completely replaced the textarea, thus the autosave module no longer able to detect changes in the textarea; since there is none! I've tried an initial fix, and it's commited to the development version.

Until the packaging script runs, replace the autosave.js in the autosave module directory with this:
http://cvs.drupal.org/viewcvs/*checkout*/drupal/contributions/modules/au...

If that works, then we'll consider this fixed. :)

mcm’s picture

It's working good from my end. thanks again for your work.

edmund.kwok’s picture

Status: Needs review » Fixed

I'm considering this fixed then :) You're welcome! If there are any other issues, feel free to report them in the queue.

Anonymous’s picture

Status: Fixed » Closed (fixed)
seanberto’s picture

Status: Closed (fixed) » Active

I just installed the most recent version of autosave (Dec 2, 2006) and am having the same conflicts mentioned above with fckeditor. The autosave, but nothing is actually saved.

I'm running fckeditor 5.x-1.x-dev from Jan 31, 2006, on Drupal 5.1. Could be a problem on my end, but I've used this version of th autosave module on another site with fckeditor in early December and remember it working.

Thanks!
-s

HarrisT’s picture

Version: 5.x-1.x-dev » 5.x-1.2

Hi Edmund, thank you for creating and maintaining this module.

On my Drupal 5.1 installation with FCKeditor 5.x-1.1 (module) and FCKeditor core (2.4.1) with autosave 5.x-1.2 creates a revision, however the changes to the editor/textarea are not included.

I see FCKeditor function in autosave.js (v 1.1.2.8 2007/04/17), though I also tried the older version linked in this post from last year.

Please let me know if you need any other details or I can otherwise be of help.

SamRose’s picture

So, what do we need to do make this work? Or, is this bug fixed. As of right now, I cannot get Autosave to work with FCKEditor.

Some claim that it works for them. I have tried patches listed in this bug issue, including http://cvs.drupal.org/viewcvs/*checkout*/drupal/contributions/modules/au... but to no avail. I have also tried the latest dev version of the module, no dice there either.

any advice greatly appreciated

edmund.kwok’s picture

Sorry for my absence; I'll have a look at this bug and will fix it after Dec 14th. Hang in there :)

SamRose’s picture

Cool! Thank you, sir!...

edmund.kwok’s picture

Version: 5.x-1.2 » 5.x-1.x-dev
Assigned: Unassigned » edmund.kwok
Status: Active » Needs review
StatusFileSize
new607 bytes

Ah, it seems that though we are detecting a change in FCKeditor, the textarea of the form is not updated to reflect the changes. Attached patch calls editorInstance.UpdateLinkedField() whenever there is a change in FCKeditor; autosave will then save the updated changes.

Please test this patch and see if works :)

SamRose’s picture

Version: 5.x-1.x-dev » 5.x-1.2
Status: Needs review » Fixed

This patch works! No issues that I could find, while testing patch out...

SamRose’s picture

Status: Fixed » Needs work

One critical issue that I found after applying this patch is that autosave makes Drupal produce the following error:

"This content has been modified by another user, changes cannot be saved."

This pops up over and over, even though the node being edited is only being accessed by one person. This is usually an error that is produced when two people are simultaneously editing the same node, and one person tries to save changes after the other one has already saved a change. Other than that issue, patch is working quite well.

SamRose’s picture

Another glitch is that, since applying above, on some pages it is not possible to input text without first clicking on "source".

Another strange behavior is that while typing, words in a sentence in FCJEditor are displayed on a new line ("hard return") fo the first few seconds. after around 20 seconds or so, the problem ceases. If I disable autosave, these problems go away.