CVS edit link for gdf

I am writing a Drupal API for CCSSI, the Common Core State Standards Initiative. CCSSI is a reworking of US national educational standards and (at last count) 34 states have committed to adopting it. The "ccssi" module will include the first publicly available electronic database of the standards and an API for accessing it.

An alpha version of the module is already in testing.

CommentFileSizeAuthor
#1 ccssi-6.x-0.1.tar_.gz108.82 KBgdf

Comments

gdf’s picture

gdf commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new ccssi-6.x-0.1.tar_.gz108.82 KB

attached is tarball of alpha version of ccssi module

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thank you for applying for a CVS account.

As per requirements, the motivation should include more than 2 sentences of module feature descriptions, and a comparison with the existing solutions.

gdf’s picture

gdf commented
Status: Needs work » Needs review

CCSSI is the Common Core State Standards Initiative, a redesign of US math and reading educational standards developed and supported by most states. The CCSSI standards were published in Summer 2010 and 34 states have already committed to adopting them, in some cases within a year or two. The standards can be viewed at http://www.corestandards.org.

Applications that reference educational standards need a database of the standards and some mechanism to search them according to criteria like grade, subject, and/or topic. The submitted "ccssi" module provides this functionality for Drupal applications.

The "ccssi" module will include a self-contained database of the CCSSI standards, an API for accessing the data, a means whereby additional standards can be created on a state-by-state basis, which the CCSSI guidelines allow for, and one or more tools for exporting all or part of the standards database for external use.

There is no other Drupal module that accomplishes these tasks. In fact, the self-contained electronic database that was created for the module is the first of its kind, and a number of other developers have already requested copies of it for other (non-Drupal) purposes.

gdf’s picture

gdf commented
Component: Miscellaneous » miscellaneous

My CVS application appears to be stuck and I could use some suggestions as to how to get it moving again. I apologize if I am going about the process incorrectly. I've read the documentation about applying for CVS access and I think I'm doing it right, and responded in comments above to the one request for further information.

johnbarclay’s picture

johnbarclay commented
Component: miscellaneous » new project application
Status: Needs review » Reviewed & tested by the community

This would be great to get approved.

bfroehle’s picture

bfroehle commented
Status: Reviewed & tested by the community » Needs review

I don't think this application has been reviewed yet.

Some preliminary comments:

  • There are lots of calls to dpm() in the code, but no dependency on the devel module in ccssi.info. (Really, the dpm() calls should be removed before release).
  • $xml_file = 'c:/inetpub/wwwroot/Drupal/ccssi/drupal6_root/sites/all/modules/ccssi/' . $xml_file; is not portable. Instead use drupal_get_path('module', 'ccssi') . $xml_file
  • Strings sent to drupal_set_message() need to be sanitized. For example, you could replace drupal_set_message("$row[1]: CCR not a valid grade range value", 'error'); with drupal_set_messge(t('%row: CCR not a valid grade range value', array('%row' => $row[1])), 'error');
  • I have not reviewed your database codes, which may be insecure if you are relying on user-submitted data.

As a first pass, you may want to run your code through the Coder module --- it generally provides some useful ideas. Also, read up on the Drupal coding standards if you haven't done so already.

arianek’s picture

arianek commented
Status: Needs review » Postponed

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

  • The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
  • Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
gdf’s picture

gdf commented
Project: Drupal.org CVS applications » Drupal.org security advisory coverage applications
Status: Postponed » Needs review

http://drupal.org/sandbox/gdf/1089488

ethanw’s picture

ethanw commented
Assigned: Unassigned » ethanw

Reviewing

ethanw’s picture

ethanw commented

It looks like this module could be a very useful contribution for those developing for state boards of education, etc.

I’d review the documentation standards here: http://drupal.org/node/1354

Important

  • Documentation
    • Need to document all files, ex. ccssi.module
    • Need to document all functions, ex. ccssi.functions.inc file, see http://drupal.org/node/1354#functions
    • Need to document return values, such as ccssigradelevel in ccssi.module
  • Confirm that CCSSI-Combined.xml is admissible under GPL, linked terms of use seem like they may not be compatible. If not compatible, you may want to provide for download somewhere else or provide as a schema here, if that is permissible according to their terms.
  • ccssi-save.info should be renamed ccssi.info
  • the .info file needs to have $Id in header

Recommendations

  • Rename to CCSSI API (“ccssi_api”) if just an API module.
  • I think that a comprehensive README.txt would be quite helpful here, linking to resources about CCSSI and outlining common use cases for this module (modules that might build off of it, example calls to it’s functions)
sreynen’s picture

sreynen commented
Status: Needs review » Needs work

Changing status, per #10.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Component: new project application » module
Status: Needs work » Closed (won't fix)

Closing, feel free to re-open if this was a mistake.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: ethanw » Unassigned
Issue summary: View changes
Issue tags: -Module review