There are instances where the theme text (.form-item label and ) does not meet the minimum contrast ratio of 4.5 as given by WCAG 2.0.
Some examples
Ratio: 2.46
.collapsed .fieldset-title a {
background:#eee;
color:#999;
}
Ratio: 2.85
.form-item label {
margin:0px;
padding:0px;
color:#999;
font-weight:bold;
font-size:10px;
text-transform:uppercase;
}
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1003820-rubik-5.patch | 292 bytes | ericduran |
| #1 | color-before-1.png | 66.03 KB | fearlsgroove |
| #1 | color-after-1.png | 66.59 KB | fearlsgroove |
| #1 | color-before-2.png | 139.99 KB | fearlsgroove |
| #1 | color-after-2.png | 141.6 KB | fearlsgroove |
Comments
Comment #1
fearlsgroove commentedLove me some rubik, but I've also found the font contrast to be insufficient. The attached patch darkens links, labels, unselected vertical tab items and form element borders somewhat. I've found it much more readible over time. Obviously this is at least somewhat subjective and easy to do with a subtheme, but I think the theme would benefit from the change overall.
To the OP's point: I don't know if these new colors pass the guideline ratio, but if they don't I think it makes sense that they should before being committed.
Comment #2
c4rl commented@fearlsgroove: I usually use http://snook.ca/technical/colour_contrast/colour.html to check contrast.
Comment #3
adnanc commentedLooks good. While the changes are minor, they go a long way in making things easier on the eyes.
The only thing that I would suggest is to re-name the patch to follow the "unofficial patch naming convention" as seen here
Also agree on the point where the theme itself could use definite improvements in terms of contrast. I (and I can speak for the rest of my team) love Rubik, and I'm hoping that patches like these make their way into Rubik.
Comment #4
coffeymachine commentedI like this patch. Reviewed and committed to 7.x-dev. Thanks!
Comment #5
ericduran commentedI've actually been doing #ddd instead of #ccc for the border of the input elements.
I think #ddd is to better especially when compare with the outer border.
I'm actually re-opening this issue with a patch for #ddd hope this is ok. If not feel free to just close it :)
Patch attached.
Comment #6
haydeniv commentedCommitted b72b719
Thanks!