Over at http://drupal.org/node/995854#comment-3854990, merlinofchaos said:

"Ok, I propose we modify the patch to change mousedown to click, and test http://drupal.org/node/216059#comment-721125 to see if it is relevant. jquery's event handling has been completely overhauled since that issue and this may not be something we have to worry about anymore, but we won't know until we test."

So this issue is to test that. :)

(posted by webchick on behalf of sun, who is caught in the middle of a bitter networking dispute between Oregon and Germany.)

CommentFileSizeAuthor
1846.patch801 byteswebchick

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1846.patch, failed testing.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs work » Closed (duplicate)

Thought this was going to be done in #634616: Various problems due to AJAX binding to mousedown instead of click (see #995854-80: #ajax doesn't work at all if a file element (or enctype => "multipart/form-data") is included in the form)

effulgentsia’s picture

effulgentsia commented
Status: Closed (duplicate) » Needs review 
+++ includes/ajax.inc	(working copy)
@@ -572,10 +572,7 @@ function ajax_pre_render_element($elemen
         $element['#ajax']['keypress'] = TRUE;

If we're binding to click instead of mousedown, do we still need to bind to keypress too?

effulgentsia’s picture

effulgentsia commented
Status: Needs review » Closed (won't fix)

x-post. my vote is to do it in that issue.

effulgentsia’s picture

effulgentsia commented
Status: Closed (won't fix) » Closed (duplicate)

woops.

aspilicious’s picture

aspilicious commented
Status: Closed (duplicate) » Needs review

1) Enable the poll module and create a new poll.
2) Move to the title field and hit the enter button.
3) A new element will be added to the AHAH add more section.

This still gives the same problems, I used this patch.

I also noticed something else (probably not related)
1) Pushing the enter button made the row weights appear + drag and drop icon => drag and drop broken
==> pressing add more fixes the issue

aspilicious’s picture

aspilicious commented
Status: Needs review » Closed (duplicate)
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Sorry, this duplicate issue was my fault; wasn't able to access drupal.org.

The test results in #7 look very unfortunate. Can we move them over to #634616: Various problems due to AJAX binding to mousedown instead of click ?