Can't use custom database driver

Code looks good to me. Regarding the utility function, it could be placed in includes/drush.inc, but since it is only a few lines, I don't think that is necessary.

Please remove that static cache. Those have eaten drupal alive and they aren't welcome here. Caller can do own cacheing if he needs to call this over and over again.

Otherwise, looks good.

I looked at postgres driver and it takes $connection_options in its contstructor. This passes the string 'databaseType' as $connection_options and caches the result. That does not look right.

committed without uneeded static cache.

This patch causes sql-sync to catch fire and crash. Drush isn't bootstrapped, so it can't include the desired files. I didn't have time to try to fix it; I just backed out the last change, and sql-sync worked again. Did not commit; HEAD is still broken.

I've just seen this

Strict warning: call_user_func() expects parameter 1 to be a valid callback, non-static method                     [error]
DatabaseConnection_mysql::databaseType() should not be called statically in drush_valid_db_credentials() (line 1218
of /usr/src/drush-HEAD/includes/environment.inc).

Sorry. Please roll this back. Am offline until sun night

reverted.

The revert removed some existing lines, so currently the SQL commands don't work for me (D6 installation using mysql).

Note that in 1.92 of sql.drush.inc (Diff) removes the following lines:

if (is_null($db_spec)) {
    $db_spec = _drush_sql_get_db_spec();
}

With that, the DB-driver isn't properly retrieved, but is returned as null. This becomes apparent when executing sql-connect:

bherlig@eltanin:/var/www/drupal/sites/g21$ /tmp/drush/drush.php sql-connect
 --database=origo_g21 --host=localhost --user=origo_331 --password=origo

Note that the command is missing.

Patch to fix the revert is attached for your consideration.

applied. thanks bherlig.

Someone who needs this should step up for a code review and verify that it works. Otherwise, it won't get much attention from maintainers.

This issue was marked closed (won't fix) because Drush has moved to Github.

If desired, you may copy this bug to our Github project and then post a link here to the new issue. Please also change the status of this issue to closed (duplicate).

Please ask support questions on Drupal Answers.