Good day

just checked in Russian team, that unapproved users may post suggestions

need fix it

CommentFileSizeAuthor
#8 FireShot-capture--Ukrainian-team-localize_drupal_org---localize_drupal_org_node_176_edit.png49.84 KBpodarok
#2 unapproved_user.png9.64 KBpodarok
#2 unapproved_user_import.png14.81 KBpodarok

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Can you provide an example please?

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
StatusFileSize
new unapproved_user_import.png14.81 KB
new unapproved_user.png9.64 KB

I`ve deleted that 2 suggestions from unaproved user already
But
Just requested join into group for http://localize.drupal.org/user/138154 (my own testing account)
And with no appoving I can import po files (look at screenshots)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Project: Drupal.org site moderators » Localization server
Version: » 6.x-2.x-dev
Component: Localize.drupal.org » Code

Ok. Until this is fixed, I guess you can just go back to by invite mode.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Project: Localization server » Drupal.org site moderators
Version: 6.x-2.x-dev »
Component: Code » Localize.drupal.org
Status: Active » Fixed

Ok, it is indeed a configuration, not a code issue. The groups on localize.drupal.org are set up to grant "translation team member" roles to people who sign up. This happens automatically even for not approved members. I've just added a "passive member" role now, which does not have any additional permissions. You can edit the group at http://localize.drupal.org/node/2459/edit and set this role as default for new members. Then no new member will have permission to do anything until you approve them.

BUT them you'll need to manually add the "translation team member" role to them when / after you approve them as well(!) Remember that please.

I consider this fixed, please reopen if your editing of the group did not help in preventing new and unapproved members from importing or entering stuff.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented

I can`t see any of role management tab at the http://localize.drupal.org/node/2459/edit, (tested on http://localize.drupal.org/node/176/edit where I manager admin)

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Fixed » Needs work
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Postponed (maintainer needs more info)

This is what I wrote: You can edit the group at http://localize.drupal.org/node/2459/edit and set this role as default for new members. Now if you go to that page, you should be able to see a dropdown titled "Default role for new members", where you can set "passive member" as the default. Can you see that?

(The reason I'm not setting this myself is that you should be able to move back yourself to "translation team member" - or just set it to default), once you are fine with your migration.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
StatusFileSize
new FireShot-capture--Ukrainian-team-localize_drupal_org---localize_drupal_org_node_176_edit.png49.84 KB

Here is a screenshot from Ukrainian group (manager admin)

From Russian will be later (I`m not manager admin yet)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Ok, grated "override group default role" to "translation community manager" roles. You should now be able to see the setting if you have that role. Please double check. (I also set the default to "passive user" now, but please check you can see the setting now). Thanks!

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented

Double checked
In Ukrainian and Belarussian groups(no cache for that group in my browser)

There are no any tabs for setting (can provide screenshot as U want)

I see only passive user role in http://localize.drupal.org/og/users/GRP_ID/roles
But there is no any options at http://localize.drupal.org/og/users/GRP_ID/edit for default user role

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Well, ok, I'll not be able to debug this further today, but I already set the Russian team to default to "passive members", so if you can retest the original bug with a new not approved user, that would be great. I can continue debugging why you cannot set the default role later this week or next week.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented

Ok
I`ll do that in a few hours

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Title: unapproved users can post suggestions » unapproved users can post suggestions (fixed) adding (default to "passive members") option need work

Just checked it
reguested but not approved user got Access denied error when trying to go to http://localize.drupal.org/translate/languages/ru/import
So I think that #2 already fixed when default to "passive members"

Shoud I have to create another issue for debugging the option (default to "passive members")?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: unapproved users can post suggestions (fixed) adding (default to "passive members") option need work » even unapproved users get "translation team member" role
Status: Postponed (maintainer needs more info) » Fixed

Well, probably opening another issue would be better. Keep this closed. I suggest titling it something like "Unable to edit default team member role", and open it in the d.o webmaster queue.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented

#1005448: Team managers should be able to edit default team member role
done

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

japerry’s picture

japerry
Location KOMK
commented
Component: Localize.drupal.org » Project/Git problem
Issue summary: View changes

Just a note for Localize D7. Because subscriptions do require approval now, they should not get any access to post content as 'pending' users.

Thus we should be able to remove the Passive member role.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Project: Drupal.org site moderators » localize.drupal.org
Version: » 7.x-1.x-dev
Component: Project/Git problem » Code
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@japerry: do you have an issue for the things you mentioned here?

japerry’s picture

japerry
Location KOMK
commented

Its somewhat related to #2512324: "You are now a member" contradicts "Your membership request awaits approval"

I created a new issue to outline the new roles and permissions structure in OG 2.x here: #2549053: Localize OG membership roles and status