I saw a .info file was added to CVS. Here's a patch for kml.module that makes that Drupal 5 compat also.

Comments

AjK’s picture

Version: 4.7.x-1.x-dev » master
geodaniel’s picture

Status: Needs review » Reviewed & tested by the community

Thanks AjK! It looks like there were some things in there that shouldn't have been in the 4.7 code anyway, so I'll fix those in there and then release a 5.x version too.

hickory’s picture

Could this patch be committed and a DRUPAL-5 branch made?

The only thing I'd change about the patch is to leave kml_admin_settings named the way it was. Apart from that it's quite straightforward.

geodaniel’s picture

Assigned: Unassigned » geodaniel
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new11.49 KB

I've spent some time on this today working from AjK's patch. There were some other bits that needed fixing as well though, mostly due to changes in the location module (like adding more than one location, and one of the location table fields changing its name). I've still got some more work to do on this, but attached is the current patch for reference.

geodaniel’s picture

StatusFileSize
new14.3 KB

Some more updates to the patch... still not ready:

  • there are some links that just display as Array (in block and on ?q=kml page)
  • only one location is displayed, even if there are multiple
  • trying to load a kml feed with no nodes gives foreach error (probably the same in 4.7)
geodaniel’s picture

Status: Needs work » Fixed

A modified patch has been commited, the code branched for Drupal 5.0 and a release made. The last two issues from my previous comment have not yet been fixed but the module works now with 5.0, so they deserve their own issues.

I'd be very grateful if anyone interested in using the module on 5.0 could test it out and create new tickets for any issues they find.

geodaniel’s picture

Status: Fixed » Patch (to be ported)
StatusFileSize
new20.43 KB

Oh, and I need to backport a bunch of these things back to the 4.7 branch, so attaching patch for reference.

geodaniel’s picture

Status: Patch (to be ported) » Fixed
StatusFileSize
new13.71 KB

Backported to 4.7 branch too - KML module should now work happily with location module again.

Anonymous’s picture

Status: Fixed » Closed (fixed)