Signups incorrectly finalized across orders when products from uncompleted orders remain in $_SESSION

Getting the same bug:

I'm signing up 2 persons (one in the db, one i create the profil).
I complete the payment, users are signed up, good.

After that, i'm doing the same process.
But after i set the email addresses of the new subscriber, I can see the 2 first users info.

As TechnNikh said, it's a problem with the variable $_SESSION not being flushed after an order.

Any patch available?

Mat

Found a way to get rid of it :

If you're using Atos/Sips module, in uc_atos.module, Line 104:

unset($_SESSION['cart_order'], $_SESSION['do_complete']);

I just added the uc_signup session:

unset($_SESSION['cart_order'], $_SESSION['do_complete'], $_SESSION['uc_signup']);

Work for now, but I didn't test every possibilities and it's a module hack, so a real solution would be better.

Thanks for pointing this out. I was able to replicate this behavior, and this is definitely something we want to fix.

Purchase nid 20, pay via check:

mysql> select * from uc_signup_log;
+-----+-----+-----+------+
| oid | sid | uid | type |
+-----+-----+-----+------+
| 100 | 148 | 1 | 0 |
+-----+-----+-----+------+
1 row in set (0.00 sec)

mysql> select * from signup_log;
+-----+-----+-----+--------------------------------+-------------+-----------+----------+---------------------+
| sid | uid | nid | anon_mail | signup_time | form_data | attended | count_towards_limit |
+-----+-----+-----+--------------------------------+-------------+-----------+----------+---------------------+
| 148 | 0 | 20 | placeholder-101826@example.com | 1307026814 | a:0:{} | NULL | 1 |
+-----+-----+-----+--------------------------------+-------------+-----------+----------+---------------------+
1 row in set (0.00 sec)

Purchase nid 4, pay via credit card:

At the attendee contact form, "Please enter additional information about this attendee." displays nids 4 *and* 20 .
Checkout with the new order for nid 4:

mysql> select * from signup_log;
+-----+-----+-----+--------------------------------+-------------+-----------+----------+---------------------+
| sid | uid | nid | anon_mail | signup_time | form_data | attended | count_towards_limit |
+-----+-----+-----+--------------------------------+-------------+-----------+----------+---------------------+
| 148 | 0 | 20 | placeholder-101826@example.com | 1307026814 | a:0:{} | NULL | 1 |
| 149 | 1 | 20 | | 1307026907 | a:0:{} | NULL | 1 |
| 150 | 1 | 4 | | 1307026907 | a:0:{} | NULL | 1 |
+-----+-----+-----+--------------------------------+-------------+-----------+----------+---------------------+
3 rows in set (0.00 sec)

mysql> select * from uc_signup_log;
+-----+-----+-----+------+
| oid | sid | uid | type |
+-----+-----+-----+------+
| 100 | 148 | 1 | 0 |
| 101 | 149 | 1 | 1 |
| 101 | 150 | 1 | 1 |
+-----+-----+-----+------+
3 rows in set (0.00 sec)

We need to remove the signup information from the session when checkout doesn't fail, and we need to verify that products in the session are actually present in the order.

Here's a patch that in my testing corrects this issue in 2 ways: We check that all product nids in the session match product nids in the order, and we clear out the session when hook_order case 'submit' runs.

uc_signup_cart_view_form_submit() should make the data in the session more consistent with what's in the cart, but the submit handling currently in uc_signup is written to be compatible with Ubercart dev, or the upcoming 2.5 release.

It would be great to get feedback on whether this resolves the issue for you. In general, I plan to commit this.

This is committed. Thanks!
http://drupalcode.org/project/uc_signup.git/commit/1867919

Thanks for these steps. I will try to reproduce today.

I'm unable to reproduce this behavior with the latest dev version of uc_signup. Can you confirm that you're using this version?

If so, I'd like to make myself available today to see this issue in your environment. Please find me in IRC as ezra-g or use my Drupal.org contact form to get in touch.

Also, please specify the version of Ubercart core that you are using.

Thanks for the followup - Glad that's resolved!