A way for project maintainers to mark their projects for a code review when they feel ready for one (and for other contributors to see a list of such projects and so provide reviews) would be a great benefit to the quality of our code and for more entrypoints to contributing to Drupal.

There is no dedicated g.d.o group for code review for people who request it (as opposed to repository access review), yet, but some discussion took place in the code review group endorsing this approach.

The easiest way technically to implement it would be to add a Code review request vocabulary that applies to projects with multiselect for options such as General review, Security review, UX review, Accessibility review, etc.

The alternative approach is to tag issues as code review, which has the advantage of using present infrastructure and allowing the link to go to some context (what would the project maintainer like reviewed?), but the disadvantage of being an invisible feature and being available to non-maintainers.

Comments

mlncn’s picture

mlncn commented
Priority: Normal » Major

With the necessary reform of the project-creating application process to make it as low a barrier as possible, it's a critical time to redirect this community effort to peer review of code.

Because it has been an impressive effort, particularly by zzolo and kiamlaluno. The idea isn't to lower standards, just change them from an entrance examination to a mentoring process.

How to review applications, for instance, has great stuff:
http://drupal.org/node/894256

Looking to continue the standards of the CVS application process, bring back Morbus and Chx Drupal Tough Love idea, and bring the Drupal Dojo in but have central coordination of code review live at a revived http://groups.drupal.org/peer-review

... and all i need here is to know if we can have another vocabulary for projects, or if we'll be tagging issues instead. :-)

benjamin, agaric

mlncn’s picture

mlncn commented
Status: Active » Needs review
Issue tags: -code review +peer-review

Adopting the issue tag: peer-review

See all: http://groups.drupal.org/node/125424

tvn’s picture

tvn commented
Status: Needs review » Closed (won't fix)

Closing old issues. Please re-open if needed.