Current release 6.x-1.0-rc2 has several issues with the SimpleTests, a reference to a protected function from rc1 which has been removed, an issue with += usage (possibly only when using PHP 5.3?) and the setup function doesn't install the module/s correctly.

I'll post a patch tomorrow but wondered whether any work has been already done on fixing these tests?

Pobster

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Gee thanks. I've tend to ignore test results for D6 modules because the test bot has been so unreliable with testing modules. Patches are welcome.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Postponed (maintainer needs more info)

BTW, just ran the tests locally and got "123 passes, 0 fails, 0 exceptions, and 24 debug messages". The 24 debug messages are from verbose messages when pages were requested and didn't affect tests. So maybe try updating to 6.x-1.x-dev for both path_redirect and simpletest?

pobster’s picture

pobster commented

I'm a little bit limited for upgrading the SimpleTests module but the dev version of Path Redirect still uses the same revision of the .test file. Does a newer Simpletest module have a cronRun function? This is the function which has been removed...

BTW I did fix everything before I left work (I have to, it's The Economist - we run all tests!) so definitely can post a patch tomorrow morning.

Thanks,

Pobster
edit: This is from memory and I'm currently on the train hence can't check these things!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Testing always uses the latest 6.x-1.x-dev of SimpleTest, which includes the latest backport from D7's simpletest, which itself includes the cronRun() function, yes.

pobster’s picture

pobster commented

Balls... Okay... Thanks, I'll upgrade Simpletest locally and if it addresses all our errors I'll just patch our Path Redirect module separately.

Thanks, will report back tomorrow when I get into work.

Pobster

pobster’s picture

pobster commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

Yep can confirm that the tests pass just fine using the most up-to-date (dev) version of SimpleTest. I'll just patch ours to get them passing again; I assume Pressflow will probably only update to SimpleTest 6.x-2.11 when they tag a Drupal 6.20 release, so I've not a whole lot of choice here!

Thanks,

Pobster