Tested against dev from Dec 20 with default configuration. The editor does not load if the text format is set as "Full HTML". It also does not seem to change if you toggle between "Full HTML" and "Filtered HTML".

1. Save content in "Full HTML" text format.
2. Edit content (no editor).
3. Change to "Filtered HTML" (visually does not change) and save.
4. Edit content (editor appears).

CommentFileSizeAuthor
#11 1006230-editor_not_loading_for_full_html.patch1.77 KBamateescu

Comments

dczepierga’s picture

dczepierga commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: +D7, +#d7ux, +ckeditor-7.x

Hmmm i can't reproduce that. Which browser do u use?? Maybe one of modules that u install have conflict with CKEditor module??
If u give me more information and help to reproduce this I fix it asap.

yukare’s picture

yukare commented

I have the same problem, using firefox 3.6.13 on linux ubuntu.

I found this message on error console from firefox:
Erro: missing ] after element list
Arquivo-fonte: http://www.jaguaribe.net/sites/all/modules/ckeditor/includes/ckeditor.ut...
Linha: 71, Coluna: 4
Código-fonte:
'/',

The line in question is:

var body = $(ev.editor.document.$.body);

yukare’s picture

yukare commented

A litlle more info, i made a test, just copy and paste the toolbar definition from one profile to another and now it works, may be something wrong with the default content in the full profile.

nihonsei’s picture

nihonsei commented

CKEditor does not work after enabling "Performance->Aggregate JavaScript files.". Even can't customize CKEditor if "Performance->Aggregate JavaScript files" is enabled.

Is there any changes need to do for Drupal 7's .htaccess file (# Rules to correctly serve gzip compressed CSS and JS files).

By enabling "Aggregate and compress CSS files" also creating problem for themes. :(

Unchecked "Performance->Aggregate JavaScript files and Aggregate and compress CSS files", CKEditor and other themes are working fine for my public_html (main site) and for my public_html/subfolder (an another site).

akalata’s picture

akalata commented

Disabling aggregated JS also solved this for me.

tgf’s picture

tgf commented

My apologies for the incomplete information about browsers, I should know better. The following browsers have the issue:

Firefox 3.6.x (windows/linux)
IE 7
IE 8

I have all caching disabled. I am not aggregating JS. I have cleared caches just to be sure.

I have the same javascript error as #2:

Error: missing ] after element list
Source File: http://testsrv/drupal/sites/all/modules/ckeditor/includes/ckeditor.utils...
Line: 71, Column: 4
Source Code:
'/',

Hope that helps. Tested against dev from Dec 20.

tgf’s picture

tgf commented
Status: Postponed (maintainer needs more info) » Active

I have just tested against the Dec 29 dev release and the issue remains.

I hope that is enough information, let me know if you need more.

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented

I have the same issue with the editor not being loaded (no toggle on/off link either) and not being configurable when javascript aggregation is enabled. Browser is Google Chrome.

luxquarta’s picture

luxquarta commented

Same issue here on Drupal 7.0 and CKEditor 7.x-1.x-dev
Tested under Windows 7 with Chrome 8.0.552.224, Firefox 3.6.13, IE 8.0.....

CKEditor will show in Filtered HTML mode but not on Full HTML mode.

Create a Filtered HTML article. Save it. Edit the article again and only change mode to Full HTML mode. Save it. Edit again: CKEditor won't appear.

matsav’s picture

matsav commented
Version: 7.x-1.x-dev » 7.x-1.0-rc1

I have encountered this problem on two websites I am developing starting with a fresh install of drupal 7

I do have CK editor working properly with Full HTML and filtered on another website that I have been upgrading from Drupal 7 RC3 -> RC4 -> Drupal 7

amateescu’s picture

amateescu commented
Version: 7.x-1.0-rc1 » 7.x-1.x-dev
Assigned: Unassigned » amateescu
Priority: Normal » Major
Status: Active » Needs review
StatusFileSize
new 1006230-editor_not_loading_for_full_html.patch1.77 KB

The problem is that the 'Full' profile is missing a comma after ['DrupalBreak'] in the toolbar settings.

Attached is a patch that fixes this issue. The only downside of this patch is that users who customised the toolbar will lose their changes, but the major benefit is that everyone else should be ok after running update.php.

The problem reported in #4 is not related to this and I will open a new issue with a proper fix.

amateescu’s picture

amateescu commented

Patch for #4 is at http://drupal.org/node/1020820#comment-3924754.

dczepierga’s picture

dczepierga commented

Amateescu really thx for patch. I commit it to CVS.

Tgf and Yukare pls confirm that this fix solved your problems.

tgf’s picture

tgf commented
Assigned: amateescu » Unassigned
Priority: Major » Normal
Status: Needs review » Active

I can confirm as successful. I applied the fix in the following ways:

1. Manually edited the Full HTML [rofile to fix the comma for an existing install
2. Applied the patch to an existing install and ran update.php
3. Applied the patch to a fresh install before activating the module

Good find amateescu.

tgf’s picture

tgf commented
Priority: Normal » Major
Status: Active » Fixed

Updated status.

amateescu’s picture

amateescu commented

@dczepierga, I saw that when you commited this, you also deleted some new lines before the else statements in ckeditor_requirements().

According to the Drupal coding standards, they were placed correctly before. I suggest you read that page because it helped me a lot to write cleaner (and easier to read) code.

And because I started this discussion, would you accept a patch that would make the ckeditor module fully compatible with Drupal's coding standards?

dczepierga’s picture

dczepierga commented

@amateescu, Yes i know about Drupal coding standards, but as u know it's sometimes hard to remember all this things if u hole life write in other code standards :)
Before each release of CKEditor module i make code review with Coder, so in each release is full compatible with Drupal's coding standards.
In this week will be next release so I made code review and commit all changes to CVS (#1022494: CKEditor module - Compatibility with Drupal's coding standards)

Status: Fixed » Closed (fixed)
Issue tags: -D7, -#d7ux, -ckeditor-7.x

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +D7, +#d7ux, +ckeditor-7.x

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.