Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
“Submit” is a pretty generic and technical term. I prefer the more user friendly “Create” (for new items) and “Save” (for updating items).
Also see the issue Change "Submit %node-type" to "Create %node-type".
Comment | File | Size | Author |
---|---|---|---|
#15 | submit-to-save.patch | 8.15 KB | kkaefer |
#11 | save.not_.submit.patch | 7.11 KB | ChrisKennedy |
#6 | save.not.submit.patch | 7.32 KB | RobRoy |
#2 | submit-to-create-or-save_0.patch | 8.03 KB | ChrisKennedy |
submit-to-create-or-save.patch | 8.12 KB | kkaefer | |
Comments
Comment #1
m3avrck CreditAttribution: m3avrck commentedI agree, I use form_alter() on a variety of sites to make sure it says "create" when you are on a */add page and then "save" for any other page.
Really helps usability wise IMO.
Comment #2
ChrisKennedy CreditAttribution: ChrisKennedy commentedI tested add/edit for each of the affected areas and they all worked great. Syncing with CVS.
Comment #3
Dries CreditAttribution: Dries commentedI don't feel strong about this change ... I thought 'submit' was pretty well-understood.
Comment #4
m3avrck CreditAttribution: m3avrck commentedDries, I disagree, "submit" is not clear--all that says is your submitting the form, which is what the button does--submits a form, but what does submitting the form *do*?
Example, for links:
Click Here
Visit Drupal.org
They are both links but it's clear what the second one does--you click a link to visit Drupal.org, the first says click the link, but it doesn't tell you what it does.
Same thing applies to forms.
Delete
Preview
Submit
It's clear that clicking "delete" deletes this post, "preview" shows you a preview, but what does submit do? Delete and preview are submit buttons but they do something different. But "submit" isn't clear what it does---but "CREATE" or "SAVE" *clearly* states what it does.
This is a very nice, small, easy usability fix.
Comment #5
Steven CreditAttribution: Steven commentedI think the progression "Delete" "Preview" "Create" is weird. When I click the "create content" link, I start creating. I only push the button afterwards. In this case, Submit is appropriate as it follows the default web workflow of "fill + submit".
"Delete" "Preview" "Save" is more close to the desktop metaphor. I think we should just always use "Save" on the node form. Just like on the desktop, where there is no difference between saving to a new file or saving to an existing file.
Comment #6
RobRoy CreditAttribution: RobRoy commentedThis patch just changes those Submits to Saves a la what Steven suggested.
Comment #7
drummComment #8
dmitrig01 CreditAttribution: dmitrig01 commented+1
Comment #9
dmitrig01 CreditAttribution: dmitrig01 commentedComment #10
dmitrig01 CreditAttribution: dmitrig01 commentedSorry for doing all these seperate, this is the last
Comment #11
ChrisKennedy CreditAttribution: ChrisKennedy commentedSynced; fixed a hunk failure in taxonomy.module.
Comment #12
ChrisKennedy CreditAttribution: ChrisKennedy commentedLots of hunks fail.
Comment #13
hass CreditAttribution: hass commentedsubscribe, aside - why is this case as "task" and not a bug for translatability?
Comment #14
Gábor HojtsyI am with Steven, that 'Save' looks better, so I was about to apply this patch, but it needs updating:
$ patch -p0 < save.not_.submit.patch
patching file modules/aggregator/aggregator.module
Hunk #1 succeeded at 344 (offset 27 lines).
Hunk #2 FAILED at 358.
Hunk #3 succeeded at 478 (offset 30 lines).
Hunk #4 FAILED at 492.
2 out of 4 hunks FAILED -- saving rejects to file modules/aggregator/aggregator.module.rej
patching file modules/contact/contact.module
Hunk #1 FAILED at 182.
1 out of 1 hunk FAILED -- saving rejects to file modules/contact/contact.module.rej
patching file modules/forum/forum.module
Hunk #1 succeeded at 475 with fuzz 1 (offset 8 lines).
Hunk #2 FAILED at 527.
1 out of 2 hunks FAILED -- saving rejects to file modules/forum/forum.module.rej
patching file modules/menu/menu.module
Hunk #1 FAILED at 322.
Hunk #2 FAILED at 402.
2 out of 2 hunks FAILED -- saving rejects to file modules/menu/menu.module.rej
patching file modules/taxonomy/taxonomy.module
Hunk #1 FAILED at 269.
Hunk #2 succeeded at 459 (offset 35 lines).
1 out of 2 hunks FAILED -- saving rejects to file modules/taxonomy/taxonomy.module.rej
patching file modules/user/user.module
Hunk #1 succeeded at 1614 (offset 89 lines).
Comment #15
kkaefer CreditAttribution: kkaefer commentedRerolled.
Comment #16
Gábor HojtsyI agree with Steven's observations. Committed!
Comment #17
dwwThe D6 upgrade docs should mention this change if you want to encourage contribs to match this language/UI when porting.
Comment #18
kkaefer CreditAttribution: kkaefer commenteddww: added a section about the change to the upgrade docs: http://drupal.org/node/114774#submit-to-save
Comment #19
dww@kkaefer: looks fine. Thanks.
Comment #20
(not verified) CreditAttribution: commented