Notice: Undefined variable: skinr in include() (line 27 of /themes/fusion/fusion_core/panels-pane.tpl.php).

Because skinr is not required for fusion printing $skinr throws the error. We need to do a check for module_exists before we print $skinr.

The above patch has already been applied or was fixed at another point. The issue itself has not been fix fixed though.

I am not a coder, but I applied the patch above and deleted the print $skinr from line 27, which removes the error. I am not sure if this is correct, but I am assuming it is fine to do this until skinr for D7 is more stable. If I am wrong, please let me know.

This is still an issue. Skinr should not be called if it is not active (and right now it says D7 version is raw!)

Also getting Notice: Undefined variable: skinr in include() (line 26 of .../public_html/sites/all/themes/fusion/fusion_core/panels-pane.tpl.php).

The Skinr module is currently required to use Fusion. Please download at http://www.drupal.org/project/skinr

This problem occurs even if Skinr is enabled.

@realityloop,

Added your patch along with deleting the $skinr from line 27 and am now rocking.

Much love for the Patch !!!

Subscribing

Patch is fine. What about replacing print $skinr; with if (isset($skinr)) : print $skinr; endif; in panels-pane.tpl.php?

Can we get this committed so that we can update our modules without worrying about patches?

thanks again

Updated fusion to a new version this morning. Error still appears, although I can fix it by implementing #13.

Just did the update and the error is showing as well. Please commit patch to module.

thanks

#1 and #13 in one patch.

this is almost certainly RTBC methinx. not a complex patch!

print $skinr should be removed entirely (it's injected automatically in D7). That and the update to <?php print render($content); ?> are the only changes that should be made to Fusion's current panels-pane-tpl.php.

I've committed this to the DEV release. For those who rather base this off a patch, one is attached. (I recommend using "git am" to apply.) Thanks to everyone for submitting patches and reviewing, and for your patience !!

@aquariumtap: so there is no need to print the $skinr variable?

This also need to be fixed in 6.x-1.x-dev. Not sure if we need print $skinr; ... I created an equal patch to #13.

@aquariumtap: may you be so kind and check this patch: its just about checking if $skinr is set. If we don't need this skinr variable, we should just remove it.