Closed (fixed)
Project:
Drupal core
Version:
5.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Nov 2006 at 17:51 UTC
Updated:
19 Dec 2006 at 21:16 UTC
Jump to comment: Most recent file
The gap affects Safari (2.0.4 tested). Setting the resizable text area to "display: block" makes it happy. The text area inside the node edit form never formed the gap since it had its' own block property set in node.css.
All this patch will do is apply it to all resizable textareas.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | gap.png | 2 KB | dvessel |
| resizable_gap.patch | 514 bytes | dvessel |
Comments
Comment #1
dvessel commentedLittle preview from Garland.
Comment #2
RobRoy commentedThis gap affects a lot of themes. I'd love to see a solution that fixes it globally. Has this been tested on some other browsers/themes as well?
Comment #3
dvessel commentedThis is a global fix. The change is inside system.css which affects all themes.
It was only tested in Safari & Firefox 1.5 but I think it'll be safe since the resizable textarea from the node edit form already has it set to 'display:block'.
At the time of this writing, I couldn't get IE listed but I'll update it when they show up.
http://browsershots.org/website/http://drupalcvs.dvessel.com/contact
If anyone can check it in other browsers themselves it's right here:
http://drupalcvs.dvessel.com/contact
Comment #4
RobRoy commentedI meant global in the sense that it would work on all browsers and would fix most contrib themes. Looks like it does as I tested IE6 on Windows. Think this is RTBC since dvessel did a good job testing across a bunch of browsers. Good stuff! I hate that gap!
Comment #5
dvessel commentedHere are a few more screen shots.
safari with patch:
http://browsershots.org/png/full/eb/ebad71357879c02eb3ab12d3963a832a.png
list of shots with patch:
http://browsershots.org/website/http://drupalcvs.dvessel.com/contact
list of shots without patch:
http://browsershots.org/website/http://hyrcan.com/drupal/?q=contact
The only quirk I see is in IE 5.5 but I'm not sure if it's that way without the patch. I can't get hyrcan.com listed for it. It'll be up there eventually.
This is how it's shown with the patch in IE 5.5:
http://browsershots.org/png/full/ee/ee7dcb677013ebe83d82fa173ecb652b.png
The right side is misaligned by about 8px in.
Comment #6
dvessel commentedThere's actually a style in Garland that breaks the resizable textarea in 5.5. This this patch actually remedies that. minus the 8px offset .
in 5.5 without patch.
http://browsershots.org/png/full/05/05fe2c1d631fdb0a7aff7bcce336b0f1.png
Comment #7
dvessel commentedOr actually, it might not be Garland alone.
This is the style that is set in Garland but not sure if it's the reason.
Comment #8
Steven commentedGood catch. Committed to HEAD.
Comment #9
(not verified) commented