global $user declared one line below first use
scott.mclewin - November 30, 2006 - 19:28
| Project: | Auto Time Zone |
| Version: | 4.7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Darren Oh |
| Status: | closed |
Jump to:
Description
This is a simple patch - the global $user; declaration is below a conditional that tests a value within $user. I don't know that it is causing any actual problems, it came up when I was moving to php5.1 with a higher warning level set as using an undeclared variable. It looks wrong, so I patched it.
| Attachment | Size |
|---|---|
| autotimezone.module.patch | 1.19 KB |
#1
Without this patch my time zone is not set.
#2
I can commit to CVS in a couple of weeks unless someone else wants to.
#3
As far as I can tell, Moshe Weitzman (who is a very busy man) is the only other person with CVS commit access for this project. I would be happy to commit this if you give me commit access.
#4
Access granted.
I never noticed the new CVS access system before.
#5
Fixed in CVS commit 47009.
#6
Thanks for the quick turnaround. Perhaps I should make all of my patches one line at a time. :)
#7