Hi,

i think it might be usefull to have a "Full list" link to stream page on block beside the "Older message" link. This can be usefull, if block shows activity logs only very compacted via AJAX pager (less logs per page; no additionl infos like user pictures) and user should have a fast way to full sized logs on stream page beside the menu links.

I suggest to introduce for this this a 4th option of stream-block-settings for "older messages":
1. No more link
2. Display "full list" link in block display
3. Display an ajax-driven older messages link
4. Display an ajax-driven older messages link and the "full list" link

whereas options 4 leads to
(left border)"Older messages Full list"(right border)

CommentFileSizeAuthor
#8 patch-1007068.patch3.78 KBStalski
#3 patch-1007068.patch3.02 KBStalski

Comments

Stalski’s picture

Stalski commented

Sounds good. I already did this, but i will wait on your review for the other issue to commit this.

Stalski’s picture

Stalski commented

This issue i mentioned is #1007536: improved deletion of grouped acitvity logs

Stalski’s picture

Stalski commented
StatusFileSize
new patch-1007068.patch3.02 KB

Well i created a separate patch anyways :p

Stalski’s picture

Stalski commented
Status: Active » Needs review
TS79’s picture

TS79 commented
Status: Needs review » Needs work

hi,
some little bugs:
- the attributes of the new "full list link" should be empty (faulty survival of "more" link attributes atm; full list link does not work)

- the path of the full list link should not include the timestamp of earliest message to open stream page with latest message on top (link should be: /heartbeat/[stream] and not /heartbeat/[stream]/[time])

- at the beginning both links (more and full list) are on block bottom, but if you press the more-link after ajax respond the extenden messages are created under the full-list-link. the full list link is sticky, but should be moved to the bottom of the block like the "more-link": a simple example

----------------
[message 1]
[message 2]
[message 3]
[more link]
[full list link]
----------------

after pressing "more" it looks like this atm:
--------------
[message 1]
[message 2]
[message 3]
[full list link]
[message 4]
[message 5]
[message 6]
[more link]
--------------

Stalski’s picture

Stalski commented

bummer, indeed.

Stalski’s picture

Stalski commented

First two issues are fixed.

For the last, i see the bug as
----------------
[message 1]
[message 2]
[message 3]
[more link]
[full list link]
----------------

after pressing "more" it looks like this atm:
--------------
[message 1]
[message 2]
[message 3]
[full list link]
[message 4]
[message 5]
[message 6]
[more link]
[full list link]
--------------

Can't figure out why you don't have the full list link after older messages.

Stalski’s picture

Stalski commented
Status: Needs work » Needs review
StatusFileSize
new patch-1007068.patch3.78 KB

Next try. It works for me.

TS79’s picture

TS79 commented
Status: Needs review » Reviewed & tested by the community

... i did not see the second link, because there have been too less messages in my queue ;)
works all for me, too (testet with more messages). thx

Stalski’s picture

Stalski commented
Status: Reviewed & tested by the community » Fixed

Fixed and committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.