Since Drupal.org is using this, we'll need this module to be upgraded to Drupal 7 before we can move Drupal.org itself over.

CommentFileSizeAuthor
#9 paranoia_d7-1007074-9.patch6.45 KBmgifford
#1 paranoia_d7.patch6.27 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new paranoia_d7.patch6.27 KB

Here is a patch, please test.

Notes:
- AFAIK, everything PHP related should now go through php.module, correct? Completely removed the permission stuff...
- The structure of system_modules is a bit different now, I've changed to hook to also include the package name. Positive side of that change, only a single unset() is now required, not 10 or so anymore. Also removed the helper function because of that.
- In the user account form, I've also hidden the current password. Wondering if there is a reason to not hide the complete account fieldset?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
coltrane’s picture

coltrane
he/him
commented
Version: master » 6.x-1.x-dev

#1 is against DRUPAL-6--1 rather than HEAD, it seems that HEAD needs the hook_paranoia_revoke() and other recent commits.

Changing version till HEAD is in sync.

Niklas Fiekas’s picture

Niklas Fiekas commented

Subscribe.

seandunaway’s picture

seandunaway commented

subscribe

pwolanin’s picture

pwolanin commented

Should prevent permissions flagged as dangerous from being assigned to anonymous (and authenticated?) users.

mgifford’s picture

mgifford
he/him
Primary language English
commented

Thanks for the patch @Berdir - I'll try to look at the patch & run in through coder, but probably won't happen till the end of September. Hopefully someone can do this before hand. @webchick defined this issue well. Patch doesn't even look that big.

j0nathan’s picture

j0nathan commented

Subscribing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
StatusFileSize
new paranoia_d7-1007074-9.patch6.45 KB

@Berdir - that was good. There were a couple very minor things that coder pointed out (spacing & docs mostly). I cleaned those up. I also changed the wording in the install file so that the grammar is better.

Anyways, I didn't change anything of substance and think it will be fine to mark it RTBC. Like with #1 I went with DRUPAL-6--1 from git.

Now how to we get this into a release after one more review?

ximo’s picture

ximo commented
Status: Needs review » Reviewed & tested by the community

Code looks good, and it does what it's supposed to do. I'd say it's ready to be committed.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Reviewed & tested by the community » Fixed

Weee!
I committed this straight. It may be perfect (or may not) but at least we have something to work with http://drupalcode.org/project/paranoia.git/commit/f7f3b98

I created a release at http://drupal.org/node/1358516 - we may have to wait for that.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Release is on the project page - http://drupal.org/node/1358516

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

For those interested in this port, I've posted a patch where I renamed the hook_paranoia_hide to hook_paranoia_hide_modules. That way we can hide more things.

#1358612-1: Prevent granting permissions flagged as dangerous from being assigned to anonymous (and authenticated) users..