Password reset procedure no longer works when installed + activated

subscribing

Love this module. A Drupal 7 version would be great.

I've attached a 'first draft' version of the module for Drupal 7.

Only a few minor things changed for the Drupal 7 revision:
- the old link to the 'error reporting' page has been updated to its new location (system settings)
- the path to this module has been altered to fit with Drupal 7's path (admin/config/system/customerror)

For how *I* use this module, these tweaks worked. I'm still able to get my custom 403/404 pages, set a custom theme for those pages, and use a custom template. That being said, I haven't done any extensive testing at all -- this was just a quick attempt to get the module working in Drupal 7.

As well, there's one function in here (customerror_user) that hasn't been converted at all. I don't have time at the moment to see what that affects so, beware.

And, sorry Khalid, I'm not sure what the best approach is to submit a Drupal 7 version -- feel free to let me know if there's something I can do to make this easier!

Kendall
Abandoned Industry :: www.invisiblethreads.com ::

It appears in the 'Other' group/fieldset for me, using a clean install of Drupal 7. (Are you sure it's in the /sites/all/modules/etc.. folder?)

Kendall
Abandoned Industry :: www.invisiblethreads.com ::

I'm not able to duplicate that problem. Can you confirm that on a clean install?

I'm able to set a custom message, title and theme for 403, and then a completely different message, title and theme for 404, and both are retained upon saving the settings.

Maybe you're forcing a setting using $conf[...] in the settings.php file?

Kendall
Abandoned Industry :: www.invisiblethreads.com ::

Sub, tag,

subscribe

subscribe

thanks works great, include this in the main page as well I didn't even know until I searched google

How is this "fixed" if there is no release available for D7?
Its not on the main page, so it shouldn't be closed, unless a D7 version is rejected by the project developers.

If anything, this thread should be set to "needs review".

Please can we at least get a 7.x branch to work from in git?

Here is a patch against the 6.x-1.x head.

The uninstall routine needs work. _customerror_enum_errors does not exist.

Subscribing

Another round base on #14

- removed ramains of hook_user
- fixed theme function - added variable names
- fixed form alteration to more performant hook_form_FORM_ID_alter()
- fix for uninstall, needs to document that module is not loaded while drush uninstall
- fixes some docs

A bit of cleanup on tests still not works (core's simple test cant find tests)

Todo should point to
#1199946: Disabled modules are broken beyond repair so the "disable" functionality needs to be removed
#773828: Upgrade of disabled modules fails

subscribe

Can you please release at least a dev version of this in git with all the patches already enabled. Easier to download and apply.

subscribe

sub

Any reviews of #19 ? Suppose this is enough to start 7-dev branch

Contacted maintainer directly on this matter, to see if we can get a 7.x branch.

Nik, you want to be a co-maintainer for this module?

sub

Hi Khalid,

I am very interested to maintain this module. Please find my Drupal experience below.

* Module Development Trainer @ Drupal Con Sanfrancisco http://www.slideshare.net/anilsagar/blisstering-drupal-module-developmen...
http://www.slideshare.net/blisstering/drupal-module-development-blisster...
http://sf2010.drupal.org/conference/pre-conference-trainings/intro-modul...

* 3 Years of experience with Drupal

* Active forum community contributor http://drupal.org/user/402938/track

* Contributed a small module to drupal community http://drupal.org/project/peanutlabsmedia

* Organized several Drupal Meetups in bangalore India.
http://groups.drupal.org/node/112864
http://groups.drupal.org/node/76358
http://groups.drupal.org/node/177019#comment-587504

I am looking forward to hearing from you soon. Please accept me as maintainer for this module. Thank you very much.

@anil614sagar you should try contacting kbahey through his profile's contact form here too

Hi Paris Liakos,

I did contact Khalid through his contact form. Awaiting reply :-)

anil614sagar

You are a co-maintainer now. You can write to git, and create releases.

My advice is to be very careful with over complexity and adding too much code or features. Just make the module work the same way it is initially. Do not overburden it with features. Be sure of backward compatibility, or have an update.php function that will migrate/update the settings so users are not left stuck.

Let's mark this fixed, when a stable release is rolled out.
The module is very simple and useful, I hope @anil614sagar keep it the same

Hi Khalid,

Thank you very much for adding me as Co - Maintainer. I will make sure module is well maintained and free from bugs / issues. I will maintain the backward compatibility of the module always.

Thank you once again.

Cheers,
Anil Sagar,
Sr. Drupal Developer,
SourceN,
www.sourcen.com
www.anilsagar.com

Hi Guys,

Drupal Custom Error 7.x-1.x version is released. Thanks to kpander, mrfelton, andypost for porting to D7. We will release RC version in a week. In a couple of weeks we will have stable release. Thank you :-)

Cheers,
Anil Sagar

Awesome work guys, will look to try the 7.x-1.x branch

the dev version from Oct 4 has a bug: password reset procedure no longer works when installed + activated.
When I disable the error handler pages in admin/setup/system/information/error pages (sorry, names may be different, I use FR interface), the password reset procedure works again.
(my situation: anonymous has no access, not tested if the default setup also has the bug)

And initial port for D7 now exists (dated 2011-Oct-04).

The problem mentioned in #37 sounds like a bug, so I'm changing the title and set status to "active".

However, I am unable to reproduce this problem on my site (i.e. I've no problem getting password reset to work after installing and activating the module).

Please supply detailed step by step information about how to reproduce this problem (if possible from a clean install of current version of the core).

(I usually close issues with the "cannot reproduce" tag if no new information surfaces in 14 days.)

I am unable to reproduce this problem on my site. Two weeks has gone by with no new information.

Feel free to reopen if you can tell me how to reproduce this. Please supply detailed step by step information about how to reproduce this problem (if possible from a clean install of current version of the core).

I don't know whether to reopen this or submit as a new bug. I hope that I can add some useful information, though I was not able to test with a clean install.

Users following one-time login links to create new accounts or reset passwords were being sent to the front page rather than user/edit page. I don't have any actions set up to do this and had not intentionally set anything up to redirect, but all logins seemed to go to the front page.

The whole registration/reset procedure seemed to work fine until using the one-time login link from the email and hitting the 'Log In' button on the resulting password reset page. It should should have been taking me from something like http://mydomain/user/reset/[user id]/1111111111/[Big Long Key] to something like http://mydomain/user/reset/[user id]/edit?pass-reset-token=[Token] instead, I went right to the front page of my site.

Disabling the Custom Error module fixes the issue. Re-enabling reintroduces it. I can try to provide any additional info that might help.

I am using:
Custom Error 7.x-1.2
Drupal 7.32

jeramy,
thank you for reporting this.

We just had a similar issue: #2345967: Redirect to page on which 403 error occurred hijacks password reset. This has been fixed in 7.x-1.x-dev, but not in 7.x-1.2.

Can you be so kind and download and test Custom Error version 7.x-1.x-dev and check if that version fixes your issue?

Updating status.

Excellent. 7.x-1.x-dev does appear to resolve the issue. I updated and enabled the module and was able to successfully register new accounts and complete password changes. Thank you for the quick response!

Thanks for reviewing, jeramy. Settings this to RTBC for it to be part of the next tagged release.

Fixed in release 7.x-1.3.