I've noticed that the node check can correctly fail, then when run again (without removing php or JS from the offending nodes) it will pass.

I've traced this down to the $last_check['lastrun'], which incorrectly assumes we only want to look at new nodes.

CommentFileSizeAuthor
#2 1007294-security_review-node-comments-check.patch1.26 KBcoltrane

Comments

coltrane’s picture

coltrane
he/him
commented

There's a patch for this at #755766: Better handling for check timeouts http://drupal.org/node/755766#comment-3866772

coltrane’s picture

coltrane
he/him
commented
Status: Active » Needs review
StatusFileSize
new 1007294-security_review-node-comments-check.patch1.26 KB

Here it is on its own.

coltrane’s picture

coltrane
he/him
commented
Status: Needs review » Fixed

Committed with minor comment change http://drupal.org/cvs?commit=472912

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.