The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Hi,
I think the deletion process for grouped activity-logs in stream-view can be improved.
At the moment, the deletion link refers to deletion confirmation of one of the activity logs in the regarded group. This is not very intuitive to the end user.
I can imagine the following improvement with a little JS magic:
grouped message example:
**********************************
Some user changed the profile pictures:
user1, user2 and 2 more
- user3
- user4
------------------------------------------------
Delete
**********************************
To make deletion intuitive I propose a JS action, which fades in some deletion links per single activity-log, when the regular "Deletion"-button was pressed. These log-deletion-links should be some smart delete-icons, which do not destroy the whole message layout. I draw them as "(X)":
**********************************
Some user changed the profile pictures:
user1 (X), user2 (X) and 2 more
------------------------------------------------
Delete
**********************************
Via these links the regular log-deletion shoud be triggered.
Concerning implementation, these log-deletion-links can be hidden as long as the delete link is not pressed...
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | patch-1007536.patch | 5.8 KB | Stalski |
Comments
Comment #1
Stalski commentedHmm, hard :)
I am checking if there are cases where the user does not have delete access to all the activity in the merge.
Comment #2
Stalski commentedIn a first try, it does not seem easy to send information (uaid) for each separate message in the group. Since everything can be overridden, there is not a solution imo that can add other real delete buttons there.
I think the best solution is then to just split the messages into separate activity messages, to make it follow the normal flow.
So that's what i am working on now.
Comment #3
Stalski commentedReviewing this, i think this was really a bug. You delete a message and you don't know which message you are going to delete and may feel like somebody has stolen your activity message. The priority is major as well.
This also kind of clears the fact that this change is rather big. It will certainly not break anything, still i want to do this by patch.
Comment #4
Stalski commentedComment #5
TS79 commentedgreat JS vodoo :), which works so far.
may be there can be come classes/id's added for the ungrouped single messages, which might be usefull for theming. something like the following logic:
ID single message:
beat-item-[uaid 0]
ID's grouped message:
beat-item-[uaid 2]-grouped
beat-item-[uaid 2]-ungrouped
- beat-item-[uaid 1]
- beat-item-[uaid 2]
- beat-item-[uaid 3]
At the moment, adressing a single ungrouped message via css is difficult.
In general: the single ungrouped messages do not pass any theming function, isn't it? is there the possibility to change this?
Comment #6
Stalski commentedIt's not js voodoo. It's server side show the extra stuff in the template where js can toggle it.
And the other thing you say is not correct. All messages are rendered by theme functions. theme_heartbeat_messages, theme_heartbeat_list or theme_heartbeat_block and the template file "heartbeat-message-row.tpl.php" ... .
The ungrouped class is only there for the - at first - hidden ungrouped messages (so only if they are in fact merged). For the theme function, it does not know if the message it is theming is a merged message or a standalone one.
So you are always free to add custom classes if you override the template. You will find the new logic (if uaids > 0) for grouped/merged messages.
Comment #7
Stalski commentedFixed and committed.
Everything passes a theme function (was already like that)