For some reason the node preview is not a #prefix . I do not know the reason so I asked Adrian. He endorses the #prefix solution. Anyone has the shortest idea why we have not used #prefix last fall :) ?

CommentFileSizeAuthor
#9 node_60.patch1.3 KBchx
node_preview_should_be_prefix.patch.txt1.05 KBchx

Comments

chx’s picture

chx commented

Having read the relevant CVS logs, now I have an idea -- relate to my January post about how form API conversion commenced: we simply made an error here. This line comes from the first form API patch (400K) and we were inexperienced in form API. Unless this change breaks something, it's how it should be.

heine’s picture

heine commented
Status: Needs review » Reviewed & tested by the community

And brings node preview in line with node views on comment submission. I've not observed breakage during testing.

heine’s picture

heine commented
Status: Reviewed & tested by the community » Needs work

Let me revoke this. A view source shows that node previews are still rendered within the form tags.

heine’s picture

heine commented
Status: Needs work » Needs review

Set this back to 'needs review' and filed a seperate bug report http://drupal.org/node/100787.

heine’s picture

heine commented

Combined with the experimental patch in http://drupal.org/node/100787#comment-161931, the patch in #1 does what it is supposed to do. So once we fix issue #100787, this one should be RTBC.

chx’s picture

chx commented
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Now the other issue is solved , when that gets in this needs to get in as well. Note: less code we have.

dries’s picture

dries commented
Version: 5.x-dev » 4.7.x-dev

Committed to CVS HEAD.

I think this needs to be backported to Drupal 4.7 so I'm changing the version.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Patch (to be ported)

chx will re-roll later

chx’s picture

chx commented
Status: Patch (to be ported) » Reviewed & tested by the community
StatusFileSize
new node_60.patch1.3 KB
killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)