search-block-form.tpl.php refers to $search['submit'], which no longer exists

yeah, because this changes:
http://drupal.org/update/modules/6/7#actions_buttons

D7:

$form['actions']['submit'] = array(
    '#type' => 'submit',
    '#value' => t('Save'),
  );

Patch:

- * - $search['submit']: Form submit button.
+ * - $search['actions']: Form submit button.

Shouldn't this be: "$search['actions']['submit']: Form submit button." ???

can you provide a patch ? I have no idea :(. actions return a grouped set value.

Me neither but the original text tries to access a specific button "Form submit button". If it still tries to access that one button it needs to be $search['actions']['submit'];

If not, the text "Form submit button" is wrong :).
I don't write a patch before I know what to do :)

I think it should say something like:

$search['actions']: Buttons for the search form, including $search['actions']['submit'] (the submit button).

It's not exactly "including $search['actions']['submit']" ??
$search['actions'] is not an array and contains rendered array elements.

maybe:
$search['actions']: Buttons for the search form.
or
$search['actions']: Search form buttons ready for print.

if change $search['actions'] into an array requires API change.

OK, thanks for the correction. Still needs a patch.

Here's a patch, which also brings the tpl header up to standards.

patch seems ok.

** where can I see the docs about "tpl header up to standards", thanks.

http://drupal.org/node/1354 has all of our doc header standards

Committed to HEAD. Thanks!