When comments are set to collapsed, the links to open them (example: /node/1/1#comment-1 ) appear to be correct (identical to those in 4.7.x), but result in a "Page not found" error.

It appears that this may be due to changes to node_page().

CommentFileSizeAuthor
#2 patch_67.txt921 byteswebernet
#1 collapsed_comments.patch.txt773 bytesneclimdul

Comments

neclimdul’s picture

neclimdul
He/Him
commented
StatusFileSize
new collapsed_comments.patch.txt773 bytes

This fixes it for me.

webernet’s picture

webernet commented
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new patch_67.txt921 bytes

Patch appears to fix it.

Rerolled to fix coding style.

This is also critical since the functionality is broken.

chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community

Yup. While node_page relied on arg() node_page_view does not. And, node_page does not exist now.

(Congratulations for webernet on connecting this bug to the one I mentioned in the channel -- ie that node_page does not exist any more and this entry in comment menu does not seem needed but it is.)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)