Port tinymce to Drupal 5.x

I have changed the patch from http://drupal.org/node/92043#comment-158720 a little and added the .info file again.
Should work with Drupal 5.0 Beta 2.

status change...

I am having similar problems but also am unsure how to apply a patch. Can someone explain please.

mosh, the patch seems to work. I'm going ahead to deploy the patched mod, +1 to get this in.

Not sure why you moved the patch thread to this symptom-reporting issue, can't help with the continuity of the thread.

The patch did successfully (after some fussing with the fact that the .patch was for two files) cause the module to show up in the list, and it installed without error.

However, going to "add a new profile" -- besides the fact I had to go directly as that link has some weird em's in it and is broken -- takes me to a blank page. I even have memory_limit set to 32M.

Is this really working for anybody in 5.0 beta2? Help!

Thanks!

--D

I noticed the original issue reported many of the same errors. Maybe my blank page is indeed an internal server error.

So this doesn't work w/ 5.0beta2.

--D

Dave, works for me with recent HEAD versions of drupal and tinymce. I created a new profile, and was able to load the editor. Perhaps you could turn on error reporting...

Can you send your .module? (dave at digital202 {dot} com)

The "add a profile" link work? Clearly broken.

I'll try with HEAD, been on beta2.

Error reporting on (E_ALL and "On"), but no error, just blank.

--D

edrex, i moved the patch to this issue because this issue points to Drupal-5.0 beta 2 and the patch could be a solution for this issue.

DaveNotik,
i've tested the patch with a fresh install of Drupal-5.0 beta2 again and got no errors.

The things i have done:

01. install a fresh Drupal 5.0 beta 2
02. check out tinymce module from contrib-head
03. apply the tinymce-5.0-beta2.patch
04. unpack tinymce-2.0.8
05. create the first user account for drupal
06. login
07. activate the tinymce module
08. go to www.example.com?q=admin/settings/tinymce
09. click the create a new profile link
10. click on the assign to assign access tinymce permission for authenticated users
11. go to www.example.com?q=admin/settings/tinymce
12. click the create a new profile link
13. fill and submit the form
14. go to www.example.com?q=node/add/page and there it is :-)

I got the same result with clean-urls enabled.

I you still have errors please try to describe the way you tried it.

I have tinyMCE running with Drupal 5.0 b2 (using the patch above). However, the insert image and insert link (URLs) buttons do not work for me (i.e. nothing happens when these buttons are clicked). I just wonder if it is just me or there are others who have the same problem. This happens on both Firefox 2.0 and IE 7.0. IE reports script errors when these buttons are clicked (Error: Invalid argument).

We need to make a 5.x branch for this module as well when it works correctly...

trungdong, those symptons sound like as if you have installed the latest TinyMCE compressor 1.0.9. If so, have a look in http://drupal.org/node/91893. There is a patch for those problems. Alternatively you can downgrade to compressor 1.0.8

TinyMCE 5.0 RC1 has been uploaded. This version based on Drupal 5.0 RC1 which reduce many line-codes, from 30 KB to only 5 KB!

Unfortunately, the new version strips out most of the useful features of the module and is broken in many scenarios. For now, upgrading the 4.7 version with the patch in this thread is a much better solution than downloading the 5.0 version.

+1 works as affected. Please commit this version.

What about Eaton's comment #16? Is the RC1 dangerous to recommend and should the patch be used instead? Grrr.

--D

I would hazard a guess that the reason MOST people use a modular system such as Drupal is because they, like me, have NO IDEA how to code anything, or to apply patch files. I appreciate the hard work the patcher has done here, and I realize some people may want the patch file so they can see the differences. However: for the sake of people like me who like Drupal because it's modular and doesn't require coding experience, is there any chance an alread-patched version of this module could be posted in addition to the .patch file?

I would really appreciate if the maintainer of this module would chime in on this thread/issue.

Maybe I am misunderstanding things, but is there some type of disagreement on the inclusion of this patch and the update/port to 5.0?

Thanks

Re: #19 canadrian.electricteaparty.net

Here a patched (and little modified) 4.7x version to drupal 5.x.

Some info:
Base on mos' tinymce-5.0-beta2.patch.
I tested TinyMCE 2.0.9 and drupal 5 and IMCE, run smoothly. (Browsers: IE 6., FF 2.0, Opera 9.1, Theme: garlands and bluemarine.)
I have enabled drupal's textarea resizable function in the source of the module. (Eg.: Using TinyMCE -'rich text enabled-', the resize is controlled by TinyMCE , otherwise by drupal.)
Some useful TinyMCE config false in default ( horizont resizing, resizing use cookie).
The attached file use 7zip compress. ( Go http://www.7-zip.org/ more info.)

cheers

Thank you so much, that's awesome. I did eventually find a handbook page on how to patch modules, by all my effort were unsuccessful. This is a great help!

is there any chance we could have that in a more universally accessible format, like zip for example?

is there any chance we could have that in a more universally accessible format, like zip for example?

Sure. :)

have many tested mosh's patch?

I think we need to convert the current 5.0 tinymce to this with the patch.

changing to critical cause this needs to be resolved asap. the new maintainer seems to have gone awall!

Based on the .zip from #24 the settings page does not show any options and someone's settings.php is in the themes directory.

I followed the instructions in post #9, except I used the released 5.0, and TinyMCE 2.09.

Tested and looks good, but I'm not using IMCE.

#25 Re:

"I think we need to convert the current 5.0 tinymce to this with the patch."

NO! the patch work only 4.7.xdev or head. The current 'official' 5.x module totally new fork.

#26 Re:
Remove currently module and reinstall tiny_mce4.7.x_to_5.x.zip

#27 Re:

"I followed the instructions in post #9, except I used the released 5.0, and TinyMCE 2.09."

??? The patch work only 4.7.xdev or head.

Sorry, I should have been more specific.
I used the released 5.0 of Drupal no the beta 2 as mentioned in post #9.

Sorry, I should have been more specific.
I used the released 5.0 of Drupal not the beta 2 as mentioned in post #9.

Sorry, I should have been more specific.
I used the released 5.0 of Drupal not the beta 2 as mentioned in post #9.

Grrrr. Sorry about the triple post. Slow connection :(

tomsolo.

im saying the current drupal 5.0 tinymce that has all the features missing (cause it has been rewritten) should be 5_0__2_0 and not 5_0__1_0 .

1_0 should be the 4.7 (head) ported to 5.0 with the patch that is made from this issue.

Thanks for taking the lead on this, Steve!

My impression is that the new code should be rolled back rather than placed into a separate branch. While I agree with some of the motives that caused this code to exist, nobody is stepping forward to maintain *either* branch.

I feel that having 2 unmaintained branches is creating more problems than it solves. If we roll back the 5.0 changes and add the patch from this thread, we can revisit the changes and bring them in as needed.

+! - I want the button configuration options back!

I also agree - the usability of TinyMCE has definitely taken a hit in 5.0 - although it has become much simpler to set up.

I installed the module in line 24. I TRYED to uninstall the 5.0 version of TinyMCE module but it would not. I uploaded the line 24 module and drupal suggested I do a database update and came up with the following 4 database errors. I am not a coder so I am wondering how to fix the database manually? I do see how I can now setup the TinyMCE module where with the 5.0ver It was missing lots of setup. Can someone help me out?

Matthew

* user warning: Table 'culturej_drupal5.tinymce_settings' doesn't exist query: SELECT s.name FROM tinymce_settings s INNER JOIN tinymce_role r ON r.name = s.name WHERE r.rid IN (2) in /home/culturej/public_html/members/includes/database.mysql.inc on line 167.
* user warning: Table 'culturej_drupal5.tinymce_settings' doesn't exist query: SELECT * FROM tinymce_settings in /home/culturej/public_html/members/includes/database.mysql.inc on line 167.
* user warning: Table 'culturej_drupal5.tinymce_settings' doesn't exist query: SELECT s.name FROM tinymce_settings s INNER JOIN tinymce_role r ON r.name = s.name WHERE r.rid IN (2) in /home/culturej/public_html/members/includes/database.mysql.inc on line 167.
* user warning: Table 'culturej_drupal5.tinymce_settings' doesn't exist query: SELECT * FROM tinymce_settings in /home/culturej/public_html/members/includes/database.mysql.inc on line 167.

I have just tested the tomsolo version (#21) on a clean Drupal 5.0 install with TinyMCE 2.0.9.

The module installed fine and I tested it by creating 2 profiles with different settings. I could not find any obvious bug.
I think the current version for 5.0 by Drupal-id.com which provides no functionality at all and is totally not backward-compatible is not acceptable and should be replaced asap. Then more people will be able to test the port, hopefully.

IMO the current maintainer did not make is job and took too much liberty by commiting a new version instead of porting the 4.7 module. Hope this will be fixed now.

may you test if you can post/update a page/story in Internet Explorer ??

Sorry I did not mention it, but I use Firefox (2.0.0.1) under Linux (Ubuntu 6.10). I have no problem for editing or updating.
I cannot test it with IE though.

ok, the problem seems to only occur on IE and Safari.

Works for me in IE7

which version? do you use the 4.7 to 5.0 patch or the "real" 5.0?

And by working i assume you mean that you can edit/publish new material?

As I said above, this patch, applied to th 4.7 version of this module, with the 5.0 drupal works for me with Firefox and IE7. I can edit and publish new material.

If you're experiencing a problem, perhaps you could describe it.

i have described it: http://drupal.org/node/110827
but the version is wrong, should be "4.7 with 5.0 patch"

I have temporarily made a workaround for the 5.x version of this module for use in Internet Explorer 6.0 (and perhaps Safari?), (not the patched version of this module, although I assume it should work similar with this too)

see this post : http://drupal.org/node/110827#comment-187835

the problem still remains, but in the meantime one can use IE for editing and publishing.

I'm running drupal 5 and tinymce latest version and everything works fine, both in Firefox and in IE (6 and 7)...
Maybe i'm only lucky :), or more expert than you.

bye bye
L.D.

I've reviewed the patch in its final form and done some basic testing. It looks fine. This is a minimal upgrade to 5.x. There is more we can and should do to take advantage of 5.x features and approaches, but those we can pursue in separate issues.

This patch was previously applied to:

(a) the DRUPAL-5 branch of tinymce module. That branch had initially been a replacement module dropping the coding approaches of tinymce.module for an approach relying on manually coded configuration files. Then the 5 branch was overwritten with a version of the original module apparently patched with this patch, but missing some files (e.g., the plugins directory and its files).

(b) the moxie module, an interim solution for tinymce module users while the tinymce module wasn't available in Drupal 5 with its original features.

I've just applied this patch to tinymce module HEAD, so we have a clean starting point for moving forward. After a bit of use, we can replace the existing DRUPAL-5 branch with what's in HEAD.

I see there was a lot of issues and patches of TinyMCE recently (some quite massive / significant, like jquery one), for which I have the impression they are not applied in some sequence, but more in parallel - starting from more or less the same source. So, I am a bit lost now what to follow (I've also just posted an issue and don't really know where to look for a possible solution). It would be really good to make some temporary -dev version, with all latest patches included, so we know where we are. And, then to discuss and correct some issues starting from this point.

The current and previous release of the Drupal 5 compatible TinyMCE module were VERY different. We've tried to clear as much of the old support advice from the queue that no longer applies to the current 5.1 release. I hope things are much less confusing now than they were over the last month or so.

There will be a new release (5.2), that will incorporate many of the patches (or at least the features the patch writer wanted).

The current 5.1 release is stable, feature compatible with the 4.7 release, and nearly error free. Future development will be based on the 5.1 release.

Just wanted to say thanks to kreynen and others for actively taking this module in a much needed direction! Looking forward to further development.