Just wondering if this module will be considered for upgrade to Drupal 7 - D7?

CommentFileSizeAuthor
#14 d7upgrade-1008886.patch3.34 KBcallison
#13 1008886-image_caption_filter-d7--3.patch9.01 KBwebflo
#11 1008886-image_caption_filter-d7--2.patch8.41 KBwebflo
#10 1008886-image_caption_filter-d7--2.patch8.41 KBwebflo
#7 1008886-image_caption_filter-d7.patch5.45 KBwebflo

Comments

matthew petty’s picture

matthew petty commented

Me, too!

davidwhthomas’s picture

davidwhthomas commented

Yes, there will be a D7 upgrade.

In the meantime, patches are welcome :)

DT

davidwhthomas’s picture

davidwhthomas commented
Status: Active » Needs work
bryancasler’s picture

bryancasler commented

subscribe

vint’s picture

vint commented

subscribe

luco’s picture

luco commented

+1

webflo’s picture

webflo commented
StatusFileSize
new 1008886-image_caption_filter-d7.patch5.45 KB

Hi, here is a patch for image_caption_filter. Please test and review.

bryancasler’s picture

bryancasler commented

Any possibility of posting the necessary files with the path applied? I still can't figure out patching on windows.

webflo’s picture

webflo commented

Sure here is my github repository. https://github.com/webflo/image_caption Use the 7.x-2.x branch.

webflo’s picture

webflo commented
StatusFileSize
new 1008886-image_caption_filter-d7--2.patch8.41 KB

I rerolled the patch. I integrated the patch form dkingofpa in #777364: Major update for filter with some modifications.

webflo’s picture

webflo commented
Status: Needs review » Needs work
StatusFileSize
new 1008886-image_caption_filter-d7--2.patch8.41 KB
webflo’s picture

webflo commented
Status: Needs work » Needs review
webflo’s picture

webflo commented
Status: Needs work » Needs review
StatusFileSize
new 1008886-image_caption_filter-d7--3.patch9.01 KB

New patch. The last one is broken.

callison’s picture

callison commented
StatusFileSize
new d7upgrade-1008886.patch3.34 KB

I have updated the image_caption module to work with Drupal 7. Patch is attached - please don't confuse with webflo's patch of image_caption_filter.

One thing to note is the removal of the unnecessary id tags at the top of the files. See http://drupal.org/node/819874 for details.

bryancasler’s picture

bryancasler commented

Can we release and Beta version of this D7 module now?

davidwhthomas’s picture

davidwhthomas commented

There will be a new release soon, now that the git migration is complete :)
DT

sw3b’s picture

sw3b commented

Subscribe !

basicmagic.net’s picture

basicmagic.net commented

subscribe

joeyabbs’s picture

joeyabbs commented

Subscribing

marie.peters’s picture

marie.peters commented

subscribe!

bryancasler’s picture

bryancasler commented

davidwhthomas, any update on this? Can we get a D7 dev release?

davidwhthomas’s picture

davidwhthomas commented
Status: Needs review » Fixed

Hi peoples, I'm happy to say with the Git migration now complete, I've released a new -dev version of image_caption for Drupal 7.

It's tested and working fine for me, please try it out.

Cheers,

DT

webflo’s picture

webflo commented

Thats cool, but no support for image caption filter? Whats you plan?

Thanks.
Florian

davidwhthomas’s picture

davidwhthomas commented

image caption filter is actually maintained by a separate developer, so it's up to them at this stage.

If nothing is forthcoming, I may do a port, and test out those patches, myself in the future.

DT

davidwhthomas’s picture

davidwhthomas commented

Just an update to say thanks to Florian ( webflo ) for the D7 image caption filter patch.

The update has now been applied and available in the beta2 release.

cheers,
DT

P.S Thanks to callison too for the #14 patch, but I ended up simplfying the D7 version somewhat which made that unnecessary.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.