New users do not get default state settings

I've been noticing this as well, and while it's a bug, the module is still 'functioning', i.e. no error messages :)

I'm using the feb 25 dev version. For me, this bug only shows up for anonymous users. Registered users get default settings applied correctly to the form.

Attached is a patch to make the comment form pick up the correct default for anonymous users.

Lots of code missing, so basically doesn't work at all. Here the patch against dev.

If you signup a new user, the node notify will always be false. I think that's wrong, it should be the default setting. Here my proposed patch for comment_notify_form_alter():

-      '#value' => COMMENT_NOTIFY_DISABLED,
+      '#value' => $user->uid ? COMMENT_NOTIFY_DISABLED : comment_notify_variable_registry_get('node_notify_default_mailalert'),

Yes.

Put some time into combining all my changes into a single patch against dev, hopefully the maintainer can apply this ASAP.

Changes:
1. Properly sanitize comments, so mime mail gets them fine.

2. Properly store notification settings when creating/editing users.

3. For anonymous users, set default node creation to default setting (as they are not created, we can't check if they have permissions to create anything).

+++ comment_notify/comment_notify.module	(working copy)
@@ -317,8 +318,8 @@
-  foreach (node_type_get_names() as $type => $name) {
-    if (node_access('create', $type)) {
+  foreach (node_type_get_names() as $type => $description) {
+    if (user_access('create ' . $type . ' content')) {

What's the reason for this change? Using node_access() is the proper way to check this because this will fail on blog content types.

Powered by Dreditor.

Ah, my mistake. That's because I worked with the 1.0-alpha version (which had that) and bits have been inadvertedly copied over.

Rerolled patch.

This no longer applies:

greggles@biff:~/workspace/d7/sites/all/modules/comment_notify$ patch -p1 < comment_notify_full_0.patch 
patching file comment_notify.inc
patching file comment_notify.module
Hunk #2 succeeded at 294 (offset -5 lines).
Hunk #3 succeeded at 313 (offset -5 lines).
Hunk #4 succeeded at 331 (offset -5 lines).
Hunk #5 succeeded at 340 (offset -5 lines).
Hunk #6 succeeded at 348 (offset -5 lines).
Hunk #7 succeeded at 378 (offset -5 lines).
Hunk #8 succeeded at 413 (offset -5 lines).
Hunk #9 succeeded at 424 (offset -5 lines).
Hunk #10 succeeded at 439 (offset -5 lines).
Hunk #11 FAILED at 457.
Hunk #12 FAILED at 465.
Hunk #13 FAILED at 510.
Hunk #14 succeeded at 518 (offset -9 lines).
Hunk #15 succeeded at 711 with fuzz 1 (offset 14 lines).
3 out of 15 hunks FAILED -- saving rejects to file comment_notify.module.rej
greggles@biff:~/workspace/d7/sites/all/modules/comment_notify$ 

Can you re-roll?

if (node_access('create ' . $type . ' content')) {

That's just wrong. It should not have been modified. The most recent patch needs more than a re-roll it needs a fine-review. It has a lot of changes that are not appropriate.

comment_notify_user_insert needs a docblock.

I think the only problem specific to this issue that was remaining here was fixed in #1234818: comment notifications turned off for new users by default: variable misnamed.