Closed (fixed)
Project:
Nice Menus
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Dec 2006 at 01:35 UTC
Updated:
12 Nov 2007 at 22:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
add1sun commentedyou need to escape (by using the < code > tag) any kind of code you post so folks can actually read it ;)
I looked at the problem though and it does throw a XHTML strict warning (but not error). I'll have to see what can be done to maybe strip the brackets or encode.
For those following along at home this is the output if you use
<front>as the path for a menu item in a nice menu"If fixed, it needs to be done in both 4.7 and 5
Comment #2
add1sun commentedDuplicate issued filed here: http://drupal.org/node/151549. Let's keep the discussion and any patches in this thread though.
jsherman, if you would like to learn to patch here is the handbook page http://drupal.org/patch/create and I more than willing to help teach you. It is really easy once you know it.
Comment #3
add1sun commentedchanging name to be more generic since it isn't just the front tag that does this
Comment #4
add1sun commenteddamn, meant to change it to 5 as well
Comment #5
davemybes commentedI have posted a patch for this over here: http://drupal.org/node/176184, that replaces the < & > so that at least < front > is displayed correctly.
Comment #6
add1sun commentedHere is a patch that attempts to give a relatively clean class name by stripping out a number of characters as well as http://. I think urlencode would make pretty nasty class names and doing a manual list of ugliness-stripping is better in the end. If folks could test this out and make sure it doesn't muck anything up or can think of a better method/list of chars, please report back here.
Comment #7
davemybes commentedThe patch works fine for me - no odd results that I can see. Thanks. I'll let one more person respond in the positive before this can be set to RTBC.
Comment #8
add1sun commentedCommitted to HEAD and 5 dev.
Comment #9
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.